LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Differentiate between failed thumbnail url and emtpy url images. #1829

Merged
dan1d merged 3 commits from issue-1808 into master 2018-07-31 01:03:21 +02:00
Conversation 12 Commits 3 Files changed 2 +10 -4
dan1d commented 2018-07-27 23:02:04 +02:00 (Migrated from github.com)
Copy link

#1808
Hi, I would need an icon image to be inserted on this issue. Code is ready to be reviewed but I'm missing a second icon, I'm very bad at design, so if anyone can chime in, thanks a lot!

On Failed url:
screenshot from 2018-07-27 17-53-10
On Emtpy url:
screenshot from 2018-07-27 17-53-21

#1808 Hi, I would need an icon image to be inserted on this issue. Code is ready to be reviewed but I'm missing a second icon, I'm very bad at design, so if anyone can chime in, thanks a lot! On Failed url: ![screenshot from 2018-07-27 17-53-10](https://user-images.githubusercontent.com/3293616/43346318-15697ae6-91c7-11e8-8981-a87de04b2135.png) On Emtpy url: ![screenshot from 2018-07-27 17-53-21](https://user-images.githubusercontent.com/3293616/43346334-1e1efde6-91c7-11e8-9489-f826c0252334.png)
👍 1
tzarebczan commented 2018-07-27 23:06:06 +02:00 (Migrated from github.com)
Copy link

@NetOperatorWibby, think you can give us a hand?

Thanks for the contribution Dan!

@NetOperatorWibby, think you can give us a hand? Thanks for the contribution Dan!
NetOpWibby commented 2018-07-27 23:10:16 +02:00 (Migrated from github.com)
Copy link

@tzarebczan How do I add images to an existing PR?

@tzarebczan How do I add images to an existing PR?
tzarebczan commented 2018-07-27 23:20:41 +02:00 (Migrated from github.com)
Copy link

@dan1d where is the image pulling from? I don't see it in the PR.

@NetOperatorWibby since this is a community PR, the branch is on his forked repo. I'd assume you can edit there, or just add the thumbnail to this thread.

@dan1d where is the image pulling from? I don't see it in the PR. @NetOperatorWibby since this is a community PR, the branch is on his forked repo. I'd assume you can edit there, or just add the thumbnail to this thread.
dan1d commented 2018-07-28 00:26:45 +02:00 (Migrated from github.com)
Copy link

The image is being pulled from the state variable thumbnailErrorImage. Just change the references from warning.png to your image file.

The image is being pulled from the state variable `thumbnailErrorImage`. Just change the references from `warning.png` to your image file.
tzarebczan commented 2018-07-30 18:48:43 +02:00 (Migrated from github.com)
Copy link

@dan1d we'd probably want to define the warning thumbnail the same way, right?

@NetOperatorWibby might just be easier to include a png here (it would be the same size/aspect ratio as the one we provided for the no thumb scenario: https://github.com/lbryio/lbry-desktop/pull/1755/files

@dan1d we'd probably want to define the warning thumbnail the same way, right? @NetOperatorWibby might just be easier to include a png here (it would be the same size/aspect ratio as the one we provided for the no thumb scenario: https://github.com/lbryio/lbry-desktop/pull/1755/files
NetOpWibby commented 2018-07-30 19:40:14 +02:00 (Migrated from github.com)
Copy link

failed-thumbnail

This should work.

![failed-thumbnail](https://user-images.githubusercontent.com/1288356/43413438-ad7d0d86-93f5-11e8-813a-956e38516a94.png) This should work.
dan1d commented 2018-07-30 20:43:21 +02:00 (Migrated from github.com)
Copy link

Looks good!
screenshot from 2018-07-30 15-42-57

Looks good! ![screenshot from 2018-07-30 15-42-57](https://user-images.githubusercontent.com/3293616/43416644-42f0c560-940f-11e8-867c-4764086a6b3c.png)
😆 2
kauffj commented 2018-07-30 21:04:03 +02:00 (Migrated from github.com)
Copy link

Above could probably be done in pure CSS. More importantly, it should probably be the error color.

Above could probably be done in pure CSS. More importantly, it should probably be the error color.
NetOpWibby commented 2018-07-30 21:13:21 +02:00 (Migrated from github.com)
Copy link

+1 for error color but I went with image since the other message is also an image. Is there a unified icon set? It would make sense to take the CSS approach then.

+1 for error color but I went with image since the other message is also an image. Is there a unified icon set? It would make sense to take the CSS approach then.
NetOpWibby commented 2018-07-30 21:16:17 +02:00 (Migrated from github.com)
Copy link

error-thumbnail

Used the error color found here.

![error-thumbnail](https://user-images.githubusercontent.com/1288356/43418282-04f2b36a-9403-11e8-8210-8094eab1717d.png) Used the error color found [here](https://github.com/lbryio/lbry-desktop/blob/master/src/renderer/scss/_vars.scss#L44).
skhameneh (Migrated from github.com) requested changes 2018-07-30 22:09:09 +02:00
skhameneh (Migrated from github.com) left a comment
Copy link

Waiting on image updates

Waiting on image updates
dan1d commented 2018-07-30 22:14:41 +02:00 (Migrated from github.com)
Copy link

Image updated to red bg, but should we add them with CSS then ?

Image updated to red bg, but should we add them with CSS then ?
skhameneh commented 2018-07-30 22:22:52 +02:00 (Migrated from github.com)
Copy link

@dan1d CSS is ideal but we'd need to have an SVG or glyphs for that. I don't think we're in the right place to do this at the moment, I'll need to sync with @seanyesmunt

@dan1d CSS is ideal but we'd need to have an SVG or glyphs for that. I don't think we're in the right place to do this at the moment, I'll need to sync with @seanyesmunt
👍 1
skhameneh (Migrated from github.com) approved these changes 2018-07-30 22:22:58 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
skhameneh
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1829
No description provided.
Delete branch "issue-1808"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?