Enable modal enter #2648

Merged
johndoe01012 merged 4 commits from enable-modal-enter into master 2019-07-29 15:44:10 +02:00
johndoe01012 commented 2019-07-22 23:44:38 +02:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #2312

What is the current behavior?

.

What is the new behavior?

The modal of send tips, encrypt wallet, transaction confirmation, and remove/delete file are now enterable.

Other information

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #2312 ## What is the current behavior? . ## What is the new behavior? The modal of send tips, encrypt wallet, transaction confirmation, and remove/delete file are now enterable. ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
neb-b (Migrated from github.com) reviewed 2019-07-22 23:44:38 +02:00
neb-b commented 2019-07-23 18:13:48 +02:00 (Migrated from github.com)

Thanks for the PR! We are close to releasing a new version of the app. I will review this right after that happens.

Thanks for the PR! We are close to releasing a new version of the app. I will review this right after that happens.
tzarebczan commented 2019-07-24 15:57:27 +02:00 (Migrated from github.com)

After we get this reviewed/merged, can we show you some appreciation for the contribution?

After we get this reviewed/merged, can we show you some [appreciation](https://lbry.com/faq/appreciation) for the contribution?
neb-b commented 2019-07-29 15:44:06 +02:00 (Migrated from github.com)

Looks great! Thanks for the contribution! 🙂

Looks great! Thanks for the contribution! 🙂
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2648
No description provided.