LBRYCommunity/lbry-desktop

Fork 0

edit abandon claim to abandon support #3514

Merged

nestordominguez merged 4 commits from issue-3505 into master

2020-01-27 15:29:55 +01:00

nestordominguez commented

2020-01-20 02:03:17 +01:00

(Migrated from github.com)

PR Checklist

[x ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ x] I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

[ x] Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/3505

What is the current behavior?

The tooltip in remove icon from transaction list item show abandon claim in his text

What is the new behavior?

Now show abandon support

## PR Checklist - [x ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/3505 ## What is the current behavior? The tooltip in remove icon from transaction list item show abandon claim in his text ## What is the new behavior? Now show abandon support

neb-b (Migrated from github.com) requested changes 2020-01-20 17:35:45 +01:00

ui/component/transactionListTable/internal/transaction-list-item.jsx

neb-b (Migrated from github.com) commented

2020-01-20 17:35:41 +01:00

This isn't correct. We still want to show "Abandon Claim" in some cases.

nestordominguez (Migrated from github.com) reviewed 2020-01-22 02:06:31 +01:00

ui/component/transactionListTable/internal/transaction-list-item.jsx

nestordominguez (Migrated from github.com) commented

2020-01-22 02:06:31 +01:00

Can you explain to me in which case should be used Abandon claim and Abandon support?

neb-b (Migrated from github.com) reviewed 2020-01-22 23:18:59 +01:00

ui/component/transactionListTable/internal/transaction-list-item.jsx

neb-b (Migrated from github.com) commented

2020-01-22 23:18:58 +01:00

if "type === TXN_TYPES.SUPPORT"

nestordominguez (Migrated from github.com) reviewed 2020-01-26 03:53:10 +01:00

ui/component/transactionListTable/internal/transaction-list-item.jsx

nestordominguez (Migrated from github.com) commented

2020-01-26 03:53:09 +01:00

fixed, thanks

neb-b commented

2020-01-27 15:30:01 +01:00

(Migrated from github.com)

Nice!

tzarebczan commented

2020-01-29 03:41:33 +01:00

(Migrated from github.com)

Thanks for the PR @nestordominguez ! Can we show you some appreciation?

Thanks for the PR @nestordominguez ! Can we show you some [appreciation](https://lbry.com/faq/appreciation)?

nestordominguez commented

2020-02-04 01:36:14 +01:00

(Migrated from github.com)

Hi thanks, I finished thta issue in less tahn 10 minutes, this is my wallet: bT67CBafF9i2w9SYHqDyWjrHimtsupa4Wm

Regards!

De: Thomas Zarebczan notifications@github.com
Enviado: martes, 28 de enero de 2020 23:41
Para: lbryio/lbry-desktop lbry-desktop@noreply.github.com
Cc: nestordominguez oscardom80@hotmail.com; Mention mention@noreply.github.com
Asunto: Re: [lbryio/lbry-desktop] edit abandon claim to abandon support (#3514)

Thanks for the PR @nestordominguezhttps://github.com/nestordominguez ! Can we show you some appreciationhttps://lbry.com/faq/appreciation?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/lbryio/lbry-desktop/pull/3514?email_source=notifications&email_token=ABAIW6RGCAX7LCNCNKEUUI3RADUF7A5CNFSM4KI4YQ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFXZ3A#issuecomment-579566828, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABAIW6VMTWPUEQDY7LLXQKDRADUF7ANCNFSM4KI4YQ5A.

Hi thanks, I finished thta issue in less tahn 10 minutes, this is my wallet: bT67CBafF9i2w9SYHqDyWjrHimtsupa4Wm Regards! ________________________________ De: Thomas Zarebczan <notifications@github.com> Enviado: martes, 28 de enero de 2020 23:41 Para: lbryio/lbry-desktop <lbry-desktop@noreply.github.com> Cc: nestordominguez <oscardom80@hotmail.com>; Mention <mention@noreply.github.com> Asunto: Re: [lbryio/lbry-desktop] edit abandon claim to abandon support (#3514) Thanks for the PR @nestordominguez<https://github.com/nestordominguez> ! Can we show you some appreciation<https://lbry.com/faq/appreciation>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/lbryio/lbry-desktop/pull/3514?email_source=notifications&email_token=ABAIW6RGCAX7LCNCNKEUUI3RADUF7A5CNFSM4KI4YQ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFXZ3A#issuecomment-579566828>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABAIW6VMTWPUEQDY7LLXQKDRADUF7ANCNFSM4KI4YQ5A>.