LBRYCommunity/lbry-desktop

Fork

You've already forked lbry-desktop

Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Support drag-and-drop file publishing #4170

Merged

btzr-io merged 14 commits from drag-drop into master

2020-05-25 16:27:37 +02:00

Conversation 11 Commits 14 Files changed 18 +598 -23

btzr-io commented

2020-05-11 08:41:59 +02:00

(Migrated from github.com)

Copy link

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Support drag-and-drop file publishing #350

What is the current behavior?

What is the new behavior?

Todo

Reduce fileDrop complexity.
Smooth transition to publish page
Add option to cancel publish navigation.
Use a modal for the file selector.
Rewrite file selection flow on publish page.

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [x] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes - Support drag-and-drop file publishing #350 ## What is the current behavior? ## What is the new behavior? ## Todo - [x] Reduce `fileDrop` complexity. - [x] Smooth transition to publish page - [x] Add option to cancel publish navigation. - [x] Use a modal for the file selector. - [x] Rewrite file selection flow on publish page.

❤️ 2

btzr-io commented

2020-05-11 21:23:21 +02:00

(Migrated from github.com)

Copy link

@seanyesmunt What do you think? https://github.com/lbryio/lbry-redux/pull/314

btzr-io commented

2020-05-13 05:59:03 +02:00

(Migrated from github.com)

Copy link

Still work in progress, here is a preview:

Still work in progress, here is a preview: ![drop](https://user-images.githubusercontent.com/14793624/81769704-efae9e80-94a3-11ea-8354-469c179a527a.gif)

btzr-io commented

2020-05-15 08:09:17 +02:00

(Migrated from github.com)

Copy link

I think is ready for a review, before I continue to work on this.

neb-b commented

2020-05-15 15:52:42 +02:00

(Migrated from github.com)

Copy link

Great. Will give this a test/review today!

neb-b (Migrated from github.com) requested changes 2020-05-15 17:39:47 +02:00

neb-b (Migrated from github.com) left a comment

Copy link

This is awesome. It seems to work good and feels super smooth. I just have one comment on the radio styles

ui/component/common/file-list.jsx

					
				@ -0,0 +62,4 @@

				  return (

				    <div className={'file-list'}>

				      <RadioGroup {...radio} aria-label="files">

neb-b (Migrated from github.com) commented

2020-05-15 17:36:05 +02:00

Copy link

I would like avoid creating another radio button style. Can you use the current radio buttons? Or update <FormField type="radio" /> (And maybe creating <FormFieldRadioGroup />)

I would like avoid creating another radio button style. Can you use the current radio buttons? Or update `<FormField type="radio" />` (And maybe creating `<FormFieldRadioGroup />`)

ui/component/fileDrop/view.jsx

neb-b (Migrated from github.com) commented

2020-05-15 17:37:44 +02:00

Copy link

Please wrap this in __()

Please wrap this in `__()`

ui/component/fileDrop/view.jsx

					
				@ -0,0 +51,4 @@

				  }, [history]);

				  // Delay hide and navigation for a smooth transition

				  const hideDropArea = () => {

neb-b (Migrated from github.com) commented

2020-05-15 17:37:14 +02:00

Copy link

This feels really smooth 👍

btzr-io (Migrated from github.com) reviewed 2020-05-17 22:54:51 +02:00

ui/component/common/file-list.jsx

					
				@ -0,0 +62,4 @@

				  return (

				    <div className={'file-list'}>

				      <RadioGroup {...radio} aria-label="files">

btzr-io (Migrated from github.com) commented

2020-05-17 22:54:51 +02:00

Copy link

Where are the radio styles? I can't find it

btzr-io (Migrated from github.com) reviewed 2020-05-18 01:18:50 +02:00

ui/component/common/file-list.jsx

					
				@ -0,0 +62,4 @@

				  return (

				    <div className={'file-list'}>

				      <RadioGroup {...radio} aria-label="files">

btzr-io (Migrated from github.com) commented

2020-05-18 01:18:50 +02:00

Copy link

I can't use the current FormField component with reakit, but now it has the same styles

I can't use the current `FormField` component with `reakit`, but now it has the same styles

btzr-io (Migrated from github.com) reviewed 2020-05-18 01:19:54 +02:00

ui/component/fileDrop/view.jsx

btzr-io (Migrated from github.com) commented

2020-05-18 01:19:54 +02:00

Copy link

ok, done.

btzr-io commented

2020-05-18 01:21:47 +02:00

(Migrated from github.com)

Copy link

Should I limit the drop area to the card ?

Right now it works if you drop on any place in the window. Maybe change the message to "Drop anywhere..." ?

Should I limit the drop area to the card ? Right now it works if you drop on any place in the window. Maybe change the message to "Drop anywhere..." ?

btzr-io commented

2020-05-18 05:26:08 +02:00

(Migrated from github.com)

Copy link

I didn't like the new look when dropping one file and also it didn't make sense to have a radio input just for one choice, so I made it more simple. let me know what you think.

neb-b commented

2020-05-18 23:05:23 +02:00

(Migrated from github.com)

Copy link

@btzr-io I just tried running this branch again and nothing happened when I dropped a file on the page.

I think dropping should work for the entire window, not just the card.

@btzr-io I just tried running this branch again and nothing happened when I dropped a file on the page. I think dropping should work for the entire window, not just the card.

btzr-io commented

2020-05-18 23:19:49 +02:00

(Migrated from github.com)

Copy link

@seanyesmunt is working for me, what file did you use ? any errors ? 🙃

Can you try a different file ?

@seanyesmunt is working for me, what file did you use ? any errors ? 🙃 Can you try a different file ?

btzr-io commented

2020-05-19 19:55:28 +02:00

(Migrated from github.com)

Copy link

Also keep in mind folders are not scanned recursively.

neb-b commented

2020-05-19 21:42:14 +02:00

(Migrated from github.com)

Copy link

Sorry for the wait. Busy working with paid content on lbry.tv.

Testing again

Sorry for the wait. Busy working with paid content on lbry.tv. Testing again

neb-b commented

2020-05-19 21:45:28 +02:00

(Migrated from github.com)

Copy link

Hm it is working for me now! I like the simplified look. Will give this another code review after I merge the big paid content PR!

👍 1

neb-b (Migrated from github.com) approved these changes 2020-05-25 16:27:24 +02:00

Reviewers

No reviewers

neb-b

Labels

Clear labels

Work is part of a proposal

Beamer is waiting on you!

Discuss this issue at the next planning meeting, then remove this label

Welcome to Hacktoberfest

No knowledge of the existing code required

level: 2

Some knowledge of the existing code is recommended

level: 3

Significant knowledge of the existing code is recommended

level: 4

Intimate knowledge of the existing code is recommended

merge when green

needs: exploration

Solution unclear, needs research

needs: grooming

Issue needs to be groomed before work can start

needs: priority

Priority level needs to be defined

needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

needs: tech design

Needs technical design signoff before implementation can begin

Issue is blocking release, do ASAP

priority: high

Work needs to be moved into sprint ASAP

priority: low

Work should be done but can stay in the backlog for now

priority: medium

Work needs to be done within 2-3 sprints

protocol dependent

recsys

redesign

general redesign not prioritize for anyone release

regression

resilience

sdk dependent

Requires work on lbry-sdk repo

Tom's Wishlist

trending

type: bug

Existing functionality is wrong or broken

type: discussion

A conversation. No specific changes requested

type: improvement

Existing (or partially existing) functionality needs to be changed

type: new feature

New functionality that does not exist yet

type: refactor

Minimal user-visible changes, but significant internal work

type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

type: testing

Solution needs additional user testing

unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#4170

Reference in a new issue

Repository

LBRYCommunity/lbry-desktop

Title

Body

No description provided.

Delete branch "drag-drop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?