LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

disables page scroll when pressing spacebar #4204

Merged
cassidypignatello merged 5 commits from fix/3870-prevent-spacebar-from-scrolling-page into master 2020-05-25 19:36:18 +02:00
Conversation 10 Commits 5 Files changed 2 +16
cassidypignatello commented 2020-05-17 13:37:16 +02:00 (Migrated from github.com)
Copy link

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #3870

What is the current behavior?

If playing a video and then navigating to a new page to cause the miniplayer to appear out of focus, pressing spacebar causes the video to pause and the page to scroll down in the background.

What is the new behavior?

Ensures that pressing spacebar only pauses the video on the miniplayer and doesn't cause the page to scroll.

Other information

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #3870 ## What is the current behavior? If playing a video and then navigating to a new page to cause the miniplayer to appear out of focus, pressing spacebar causes the video to pause and the page to scroll down in the background. ## What is the new behavior? Ensures that pressing spacebar only pauses the video on the miniplayer and doesn't cause the page to scroll. ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
neb-b (Migrated from github.com) reviewed 2020-05-17 13:37:16 +02:00
neb-b (Migrated from github.com) requested changes 2020-05-18 22:53:47 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

Two small comments.

Two small comments.
CHANGELOG.md
neb-b (Migrated from github.com) commented 2020-05-18 22:53:40 +02:00
Copy link

Can you move this up to the unreleased section?

Can you move this up to the unreleased section?
ui/component/app/view.jsx
neb-b (Migrated from github.com) commented 2020-05-18 22:53:29 +02:00
Copy link

The second argument to this effect should be [] so it isn't re-ran on every render

The second argument to this effect should be `[]` so it isn't re-ran on every render
cassidypignatello (Migrated from github.com) reviewed 2020-05-19 14:21:10 +02:00
CHANGELOG.md
cassidypignatello (Migrated from github.com) commented 2020-05-19 14:21:10 +02:00
Copy link

This looks like it's already under the unreleased section, did you want me to move it from Fixed to Changed maybe?

This looks like it's already under the unreleased section, did you want me to move it from `Fixed` to `Changed` maybe?
cassidypignatello (Migrated from github.com) reviewed 2020-05-19 14:54:00 +02:00
ui/component/app/view.jsx
cassidypignatello (Migrated from github.com) commented 2020-05-19 14:54:00 +02:00
Copy link

Ahh good catch, thanks Sean! Updated

Ahh good catch, thanks Sean! Updated
cassidypignatello commented 2020-05-21 10:42:32 +02:00 (Migrated from github.com)
Copy link

@seanyesmunt I just wanted to check in when you have a sec. I updated and pushed up the view.jsx file already, but didn't touch the CHANGELOG.md yet because it was already in the Unreleased section when I checked, but maybe I'm confused there. Let me know if you need any other changes, thanks!

@seanyesmunt I just wanted to check in when you have a sec. I updated and pushed up the `view.jsx` file already, but didn't touch the `CHANGELOG.md` yet because it was already in the Unreleased section when I checked, but maybe I'm confused there. Let me know if you need any other changes, thanks!
neb-b (Migrated from github.com) reviewed 2020-05-21 19:29:23 +02:00
CHANGELOG.md
neb-b (Migrated from github.com) commented 2020-05-21 19:29:22 +02:00
Copy link

Sorry. I didn't realize it was already in the correct section.

Sorry. I didn't realize it was already in the correct section.
neb-b commented 2020-05-21 19:30:11 +02:00 (Migrated from github.com)
Copy link

Nope. Sorry we've been pretty busy with paid content on lbry.tv. I'll give this another pass/merge later tonight or tomorrow morning.

Nope. Sorry we've been pretty busy with paid content on lbry.tv. I'll give this another pass/merge later tonight or tomorrow morning.
👍 1
cassidypignatello commented 2020-05-22 08:27:21 +02:00 (Migrated from github.com)
Copy link

Sounds good, no rush!

Sounds good, no rush!
neb-b commented 2020-05-25 16:17:28 +02:00 (Migrated from github.com)
Copy link

@cassidypignatello Can you please rebase this? It looks like it includes a lot of changes that have already been merged to master.

@cassidypignatello Can you please rebase this? It looks like it includes a lot of changes that have already been merged to master.
cassidypignatello commented 2020-05-25 18:23:00 +02:00 (Migrated from github.com)
Copy link

@seanyesmunt No problem, I just rebased this. Let me know if you need anything else!

@seanyesmunt No problem, I just rebased this. Let me know if you need anything else!
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#4204
No description provided.
Delete branch "fix/3870-prevent-spacebar-from-scrolling-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?