spacebar doesnt work flawless with handlers #3870

New issue

Open

opened 2020-03-21 17:07:05 +01:00 by 8bitbunny · 6 comments

8bitbunny commented

2020-03-21 17:07:05 +01:00

(Migrated from github.com)

Bug
when i press on the spacebar on my keyboard with the miniplayer playing a video, 2 things happen: the page scrolls down, and the video pauses playing in miniview.

To Reproduce
as explained above

Expected behavior
expected behaviour to me would naturally be in this case: spacebar press to only pause/resume and not scroll the page. maybe use the page up/down keys for that specific?

System Configuration

LBRY Daemon version: 0.63.0
LBRY App version: 0.43.4
LBRY Installation ID: not needed for this(?)
Operating system: 64bit based Ubuntu 19.10 Linux. (KDE desktop environment)

Additional context
love LBRY alot! just wish i could help fixing the issues i come across :)

**Bug** when i press on the spacebar on my keyboard with the miniplayer playing a video, 2 things happen: the page scrolls down, and the video pauses playing in miniview. **To Reproduce** as explained above **Expected behavior** expected behaviour to me would naturally be in this case: spacebar press to only pause/resume and not scroll the page. maybe use the page up/down keys for that specific? **System Configuration** - LBRY Daemon version: 0.63.0 - LBRY App version: 0.43.4 - LBRY Installation ID: not needed for this(?) - Operating system: 64bit based Ubuntu 19.10 Linux. (KDE desktop environment) **Additional context** love LBRY alot! just wish i could help fixing the issues i come across :)

tzarebczan commented

2020-03-23 16:47:09 +01:00

(Migrated from github.com)

Thanks for filing this issue, I can confirm it's happening. Can we show you some appreciation for the report?

Thanks for filing this issue, I can confirm it's happening. Can we show you some [appreciation](https://lbry.com/faq/appreciaiton) for the report?

8bitbunny commented

2020-03-23 16:52:43 +01:00

(Migrated from github.com)

sure thing,
i will send an email from my domain i linked my lbry profile to.
which is not my github email, but it will be coming from 8bit-bun.nl
ramon :)

sure thing, i will send an email from my domain i linked my lbry profile to. which is not my github email, but it will be coming from 8bit-bun.nl ramon :)

harshkhandeparkar commented

2020-04-19 09:57:00 +02:00

(Migrated from github.com)

Is this browser specific? Didn't happen to me on Firefox.

harshkhandeparkar commented

2020-04-19 09:58:42 +02:00

(Migrated from github.com)

I couldn't reproduce it on any browser or even the app. 😕

I couldn't reproduce it on any browser or even the app. :confused:

cassidypignatello commented

2020-05-14 15:14:59 +02:00

(Migrated from github.com)

I think the best way to handle this would be to add an event listener that would disable the default behavior if a user presses spacebar. I'm not sure if there's any situation where you would want to keep this default behavior in place, so just thought I'd mention it just in case. Either way, I can start working on this within the next couple days.

I've been able to reproduce this in both the app and on Chrome. It's my understanding that the default spacebar behavior in most browsers is to scroll down when the miniplayer isn't in focus. However, as soon as the miniplayer is brought back into focus it only pauses the video. I think the best way to handle this would be to add an event listener that would disable the default behavior if a user presses spacebar. I'm not sure if there's any situation where you would want to keep this default behavior in place, so just thought I'd mention it just in case. Either way, I can start working on this within the next couple days.

DispatchCommit commented

2021-01-21 09:30:07 +01:00

(Migrated from github.com)

Disabling spacebar seems like an overzealous solution. The player should just consume the spacebar input and stop the event from bubbling up so only 1 of the two actions occurs.

The solution in #4204 led to #4162 being opened, and goes against the standard behavior for the spacebar.

Disabling spacebar seems like an overzealous solution. The player should just consume the spacebar input and stop the event from bubbling up so only 1 of the two actions occurs. The solution in #4204 led to #4162 being opened, and goes against the standard behavior for the spacebar.