LBRYCommunity/lbry-desktop

Fork 0

Clicking claim in Invites screen causes console error #552

New issue

Closed

opened 2017-09-11 15:56:21 +02:00 by tzarebczan · 8 comments

tzarebczan commented

2017-09-11 15:56:21 +02:00

(Migrated from github.com)

The Issue

I already redeemed a referral reward and now when I try to claim another, I don't get any feedback but instead a console error is thrown. Earlier last week I remember getting a "You already redeemed your max reward for this" message.

bundle.js:17726 Uncaught TypeError: Cannot read property 'reward_type' of undefined
    at claimReward (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:17726:62)
    at onClick (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:36442:9)
    at Object.ReactErrorUtils.invokeGuardedCallback (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:16100:16)
    at executeDispatch (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:15629:21)
    at Object.executeDispatchesInOrder (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:15652:5)
    at executeDispatchesAndRelease (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10245:22)
    at executeDispatchesAndReleaseTopLevel (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10256:10)
    at Array.forEach (native)
    at forEachAccumulated (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:26138:9)
    at Object.processEventQueue (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10456:7)

Steps to reproduce

Click Claim in Invites screen
Nothing happens, check console
Console has error

Expected behaviour

Tell me that I'm maxed out

Actual behaviour

Nothing, console error

System Configuration

LBRY Daemon version: 0.15.2
LBRY App version: 0.15.1
LBRY Installation ID:
Operating system: Windows

Anything Else

Screenshots

## The Issue I already redeemed a referral reward and now when I try to claim another, I don't get any feedback but instead a console error is thrown. Earlier last week I remember getting a "You already redeemed your max reward for this" message. ``` bundle.js:17726 Uncaught TypeError: Cannot read property 'reward_type' of undefined at claimReward (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:17726:62) at onClick (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:36442:9) at Object.ReactErrorUtils.invokeGuardedCallback (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:16100:16) at executeDispatch (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:15629:21) at Object.executeDispatchesInOrder (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:15652:5) at executeDispatchesAndRelease (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10245:22) at executeDispatchesAndReleaseTopLevel (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10256:10) at Array.forEach (native) at forEachAccumulated (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:26138:9) at Object.processEventQueue (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10456:7) ``` ### Steps to reproduce 1. Click Claim in Invites screen 2. Nothing happens, check console 3. Console has error ### Expected behaviour Tell me that I'm maxed out ### Actual behaviour Nothing, console error ## System Configuration   - LBRY Daemon version: 0.15.2 - LBRY App version: 0.15.1 - LBRY Installation ID: - Operating system: Windows ## Anything Else  ## Screenshots

kauffj commented

2017-09-18 23:51:02 +02:00

(Migrated from github.com)

@tzarebczan please verify this is fixed once you see a v0.16 app draft or RC posted. If fixed, close, if not, reassign to me.

kauffj commented

2017-09-19 16:22:09 +02:00

(Migrated from github.com)

#588

tzarebczan commented

2017-09-22 18:11:03 +02:00

(Migrated from github.com)

Reopening so we can track this, lower priority for now.

kauffj commented

2017-09-22 23:00:14 +02:00

(Migrated from github.com)

I thought this error was fixed and it was more of a UX issue at this point?

tzarebczan commented

2017-09-22 23:15:17 +02:00

(Migrated from github.com)

Nope, still there. I think it was suppressed on the original v16RC when my transaction list was broken. https://github.com/lbryio/lbry-app/issues/588#issuecomment-330873538 shows the code its failing on. It could be related to the fact that I redeemed all my rewards?

I'd say its low priority, I haven't seen this from anyone else.

liamcardenas commented

2017-11-17 18:12:21 +01:00

(Migrated from github.com)

@tzarebczan can you see if this is still happening?

tzarebczan commented

2017-12-08 15:09:15 +01:00

(Migrated from github.com)

Yep, still happening (only on 2nd claim, not first) This is the line:

`  return dispatch((0, _rewards2.doClaimRewardType)(reward.reward_type, true));`

Yep, still happening (only on 2nd claim, not first) This is the line: ` return dispatch((0, _rewards2.doClaimRewardType)(reward.reward_type, true));`

tzarebczan commented

2017-12-15 16:49:07 +01:00

(Migrated from github.com)

Closing this in favor of https://github.com/lbryio/lbry-app/issues/829

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#552

No description provided.

Rows
Columns