Fix whatever is wrong or confusing with invite claims #588

New issue

Closed

opened 2017-09-19 16:01:17 +02:00 by kauffj · 5 comments

kauffj commented

2017-09-19 16:01:17 +02:00

(Migrated from github.com)

No description provided.

tzarebczan commented

2017-09-19 16:49:38 +02:00

(Migrated from github.com)

Have an internal issue open for some discrepancies with what the app is showing as claimable vs what's actually claimed when Claim is clicked.

Regarding the original issue in #552 - the error is now suppressed, but don't get feedback from the app that I already claimed my 1 referral reward.

Have an internal issue open for some discrepancies with what the app is showing as claimable vs what's actually claimed when `Claim` is clicked. Regarding the original issue in #552 - the error is now suppressed, but don't get feedback from the app that I already claimed my 1 referral reward.

tzarebczan commented

2017-09-19 21:03:11 +02:00

(Migrated from github.com)

Odd, it looks like the console error is back again:

index.js:27 Uncaught TypeError: Cannot read property 'reward_type' of undefined
    at claimReward (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:17842:62)
    at onClick (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:36449:9)
    at Object.ReactErrorUtils.invokeGuardedCallback (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:16132:16)
    at executeDispatch (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:15661:21)
    at Object.executeDispatchesInOrder (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:15684:5)
    at executeDispatchesAndRelease (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10184:22)
    at executeDispatchesAndReleaseTopLevel (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10195:10)
    at Array.forEach (native)
    at forEachAccumulated (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:26161:9)
    at Object.processEventQueue (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10395:7)

Odd, it looks like the console error is back again: ``` index.js:27 Uncaught TypeError: Cannot read property 'reward_type' of undefined at claimReward (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:17842:62) at onClick (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:36449:9) at Object.ReactErrorUtils.invokeGuardedCallback (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:16132:16) at executeDispatch (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:15661:21) at Object.executeDispatchesInOrder (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:15684:5) at executeDispatchesAndRelease (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10184:22) at executeDispatchesAndReleaseTopLevel (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10195:10) at Array.forEach (native) at forEachAccumulated (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:26161:9) at Object.processEventQueue (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10395:7) ```

tzarebczan commented

2017-09-20 16:41:48 +02:00

(Migrated from github.com)

@kauffj , per our convo, it's happening here:

var perform = function perform(dispatch) {
  return {
    claimReward: function claimReward(reward) {
      return dispatch((0, _rewards2.doClaimRewardType)(reward.reward_type, true));
    },
    clearError: function clearError(reward) {
      return dispatch((0, _rewards2.doClaimRewardClearError)(reward));
    },
    navigate: function navigate(path) {
      return dispatch((0, _navigation.doNavigate)(path));
    }
  };
};

@kauffj , per our convo, it's happening here: ``` var perform = function perform(dispatch) { return { claimReward: function claimReward(reward) { return dispatch((0, _rewards2.doClaimRewardType)(reward.reward_type, true)); }, clearError: function clearError(reward) { return dispatch((0, _rewards2.doClaimRewardClearError)(reward)); }, navigate: function navigate(path) { return dispatch((0, _navigation.doNavigate)(path)); } }; }; ```

tzarebczan commented

2017-09-20 19:47:38 +02:00

(Migrated from github.com)

Other issue is here: https://github.com/lbryio/lbry-app/blob/master/ui/js/component/inviteList/view.jsx#L50

That should point to Claimable
API:

         "invite_accepted": true,
       "invite_reward_claimable": false,
       "invite_reward_claimed": false

Update: the above is fixed in latest v16RC7. The original Reward_type error still exists.

Other issue is here: https://github.com/lbryio/lbry-app/blob/master/ui/js/component/inviteList/view.jsx#L50 That should point to Claimable API: ``` "invite_accepted": true, "invite_reward_claimable": false, "invite_reward_claimed": false ``` Update: the above is fixed in latest v16RC7. The original Reward_type error still exists.

tzarebczan commented

2017-09-22 18:10:07 +02:00

(Migrated from github.com)

If we are closing this, I'm going to re-open https://github.com/lbryio/lbry-app/issues/552

Maybe it's happening because I've redeemed all my rewards?

If we are closing this, I'm going to re-open https://github.com/lbryio/lbry-app/issues/552 Maybe it's happening because I've redeemed all my rewards?