UX patch #673
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#673
Loading…
Reference in a new issue
No description provided.
Delete branch "ux-patch"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Changes
readonly
style.tileFile
.Fixes
Issues #666, #656, #667, and some fixes for #657
More fixes...
Fantastic stuff here! Two issues I noticed:
A few minor things I probably should have noticed before merging.
This should probably be
form-field__label--focus
@ -1,5 +1,5 @@
import React from "react";
import { Icon } from "component/common.js";
import Icon from "component/icon";
❤️
@ -112,3 +112,3 @@
if (fetchingChannels) {
channelContent.push(
channelContent = (
<BusyMessage message="Updating channels" key="loading" />
It's probably would have been fine to keep this as an array, switching the type of a variable via assignment is bad practice IMO.
@btzr-io also mixed feelings about the introduction of an
h4
solely for the description label.