UX patch #673

Merged
btzr-io merged 28 commits from ux-patch into master 2017-10-15 14:25:38 +02:00
btzr-io commented 2017-10-12 04:55:23 +02:00 (Migrated from github.com)

Changes

  • New simple readonly style.
  • More improvements for file selector component.
  • Remove uri from tileFile.
  • Better text selection ( less messy )
  • New style for checkbox input + nice animation.
  • New style for radio input + nice animation.
  • Minor cleanup for publish layout.
  • Minor cleanup for settings layout.
  • More css fixes.

Fixes

Issues #666, #656, #667, and some fixes for #657

The new file chooser is mildly confusing without a readonly styling.
The width of the input cuts off the path when there is space to render

More fixes...

Empty file tiles ( from search results) #677

### Changes - New simple `readonly` style. - More improvements for file selector component. - Remove uri from `tileFile`. - Better text selection ( less messy ) - New style for checkbox input + nice animation. - New style for radio input + nice animation. - Minor cleanup for publish layout. - Minor cleanup for settings layout. - More css fixes. ### Fixes Issues #666, #656, #667, and some fixes for #657 > The new file chooser is mildly confusing without a readonly styling. > The width of the input cuts off the path when there is space to render More fixes... > Empty file tiles ( from search results) #677
kauffj commented 2017-10-15 14:28:43 +02:00 (Migrated from github.com)

Fantastic stuff here! Two issues I noticed:

Fantastic stuff here! Two issues I noticed: - https://github.com/lbryio/lbry-app/issues/678 (this is likely new from this commit) - https://github.com/lbryio/lbry-app/issues/679 (this one existed, but is more noticeable now)
kauffj (Migrated from github.com) reviewed 2017-10-15 14:32:49 +02:00
kauffj (Migrated from github.com) left a comment

A few minor things I probably should have noticed before merging.

A few minor things I probably should have noticed before merging.
kauffj (Migrated from github.com) commented 2017-10-15 14:30:11 +02:00

This should probably be form-field__label--focus

This should probably be `form-field__label--focus`
@ -1,5 +1,5 @@
import React from "react";
import { Icon } from "component/common.js";
import Icon from "component/icon";
kauffj (Migrated from github.com) commented 2017-10-15 14:30:34 +02:00

❤️

:heart:
@ -112,3 +112,3 @@
if (fetchingChannels) {
channelContent.push(
channelContent = (
<BusyMessage message="Updating channels" key="loading" />
kauffj (Migrated from github.com) commented 2017-10-15 14:31:23 +02:00

It's probably would have been fine to keep this as an array, switching the type of a variable via assignment is bad practice IMO.

It's probably would have been fine to keep this as an array, switching the type of a variable via assignment is bad practice IMO.
kauffj commented 2017-10-15 15:06:41 +02:00 (Migrated from github.com)

@btzr-io also mixed feelings about the introduction of an h4 solely for the description label.

@btzr-io also mixed feelings about the introduction of an `h4` solely for the description label.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#673
No description provided.