Thumbnail fixes

saltrafael commented

2021-08-11 14:26:14 +02:00

(Migrated from github.com)

Fixes

Issue Number: Closes #6082, closes #6098, closes #6097, closes #6835

Can re-select file on thumbnail upload
Channel thumbnail isn't uploaded immediately
Channel create checks if URL is valid
Editing profile picture reflects newly uploaded photo
Editing Channel allows empty values (can remove profile picture and go back to Gerbil)

PR Type & Checklist

PR Type...

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

PR Checklist...

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I added a line describing my change to CHANGELOG.md
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

## Fixes Issue Number: Closes #6082, closes #6098, closes #6097, closes #6835 - Can re-select file on thumbnail upload - Channel thumbnail isn't uploaded immediately - Channel create checks if URL is valid - Editing profile picture reflects newly uploaded photo - Editing Channel allows empty values (can remove profile picture and go back to Gerbil)  ## PR Type & Checklist <details><summary>PR Type...</summary> What kind of change does this PR introduce? - [X] Bugfix - [X] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: </details>  <details><summary>PR Checklist...</summary>  Please check all that apply to this PR using "x": - [X] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I added a line describing my change to CHANGELOG.md - [X] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below </details>

jessopb (Migrated from github.com) reviewed 2021-08-11 14:26:14 +02:00

tzarebczan commented

2021-08-19 20:04:56 +02:00

(Migrated from github.com)

Found a new crash due to this:

Select thumbnail on upload page, click cancel - page crash at

Cannot read property 'path' of undefined
    at n.value (view.jsx:36)

from view.jsx:36:

        <blockquote>{file.path || file.name}</blockquote>

how can one clear out channel profile as you mention?

Found a new crash due to this: - [ ] Select thumbnail on upload page, click cancel - page crash at ``` Cannot read property 'path' of undefined at n.value (view.jsx:36) ``` from view.jsx:36: ``` <blockquote>{file.path || file.name}</blockquote> ``` how can one clear out channel profile as you mention?

saltrafael commented

2021-08-23 12:35:56 +02:00

(Migrated from github.com)

Found a new crash due to this:

should be fixed now?

how can one clear out channel profile as you mention?

you can go on URL mode and clear it, then it defaults to empty values, which is not possible today (the URL mode is already empty and you can't remove the current avatar or cover thumbnail)

> Found a new crash due to this: should be fixed now? > how can one clear out channel profile as you mention? you can go on URL mode and clear it, then it defaults to empty values, which is not possible today (the URL mode is already empty and you can't remove the current avatar or cover thumbnail)