LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Swap comment servers without going to settings page #7365 #7670

Merged
ByronEricPerez merged 1 commit from Swap_comment_servers_without_going_to_settings_page_#7365 into master 2022-10-24 18:36:31 +02:00
Conversation 7 Commits 1 Files changed 6 +112 -18
ByronEricPerez commented 2022-08-09 20:21:36 +02:00 (Migrated from github.com)
Copy link

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/7365

What is the current behavior?

What is the new behavior?

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below
## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/7365 <!-- Tip: - Add keywords to directly close the Issue when the PR is merged. - Skip the keyword if the Issue contains multiple items. - https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## What is the current behavior? ## What is the new behavior? ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. --> ## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> <details><summary>Toggle...</summary> What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I added a line describing my change to CHANGELOG.md - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below </details>
jessopb commented 2022-08-11 23:57:16 +02:00 (Migrated from github.com)
Copy link

Good progress. Besides fixing styling, this should be at the top next to the refresh button.

The refresh button reloads all comments. The server selector changes the server for all comments.

Below, the comment field adds one comment.

Also, don't forget to make the selector only show up when the number of servers is > 1.

Good progress. Besides fixing styling, this should be at the top next to the refresh button. The refresh button reloads all comments. The server selector changes the server for all comments. Below, the comment field adds one comment. Also, don't forget to make the selector only show up when the number of servers is > 1.
kodxana commented 2022-08-15 17:57:12 +02:00 (Migrated from github.com)
Copy link

@ByronEricPerez What do you think if we could have option in app to integrate using multiple comments servers into single feed.
Aka at the same time user could see Odysee comments and also other comments server, or user can decide to limit to selected comments servers or just use single one.

@ByronEricPerez What do you think if we could have option in app to integrate using multiple comments servers into single feed. Aka at the same time user could see Odysee comments and also other comments server, or user can decide to limit to selected comments servers or just use single one.
ByronEricPerez commented 2022-08-22 14:37:29 +02:00 (Migrated from github.com)
Copy link

Hi @jessopb how are you, I have already corrected the location, in addition to the fact that it only shows if there are 2 or more commentServer, I just need to add that it shows the comments. And finally some css.

Hi @kodxana , I think the idea is good, it would also be more practical to have the option of being able to show them all in one.

image
image

Hi @jessopb how are you, I have already corrected the location, in addition to the fact that it only shows if there are 2 or more commentServer, I just need to add that it shows the comments. And finally some css. Hi @kodxana , I think the idea is good, it would also be more practical to have the option of being able to show them all in one. ![image](https://user-images.githubusercontent.com/89370060/185919503-a49a1f3a-3e3b-4f0b-b689-c68ffabcbcc0.png) ![image](https://user-images.githubusercontent.com/89370060/185919779-60ca9c1a-d5cb-496c-8569-01608218ad66.png)
ByronEricPerez commented 2022-08-26 21:34:21 +02:00 (Migrated from github.com)
Copy link

Hi @jessopb , I'm having trouble seeing the comments on all the videos.
The btn moved it to the correct component, it already synchronizes, I need to align it a little more. What do you think?

image

Although I comment I get an error asking me to restart, but I have that comment in my history.
I also don't see comments on any video. This error started appearing yesterday.

Hi @jessopb , I'm having trouble seeing the comments on all the videos. The btn moved it to the correct component, it already synchronizes, I need to align it a little more. What do you think? ![image](https://user-images.githubusercontent.com/89370060/186974425-9c8ceb05-008b-46cd-8d93-8d8cd2804d5a.png) Although I comment I get an error asking me to restart, but I have that comment in my history. I also don't see comments on any video. This error started appearing yesterday.
ByronEricPerez commented 2022-08-26 22:30:41 +02:00 (Migrated from github.com)
Copy link

Fixed why it didn't show comments , the error was in index.js

image

Fixed why it didn't show comments , the error was in index.js ![image](https://user-images.githubusercontent.com/89370060/186985740-e571cd50-e98d-4d41-af13-b8a9184375e9.png)
❤️ 1
jessopb (Migrated from github.com) requested changes 2022-08-29 14:58:46 +02:00
jessopb (Migrated from github.com) left a comment
Copy link

Good progress!
I think we keep refresh button all the way to the right.
And the alignment issue you mentioned.

Good progress! I think we keep refresh button all the way to the right. And the alignment issue you mentioned.
ui/scss/component/_card.scss
jessopb (Migrated from github.com) commented 2022-08-29 14:58:01 +02:00
Copy link

We should prefer spacing vars instead of px values wherever possible.

We should prefer spacing vars instead of px values wherever possible.
ByronEricPerez (Migrated from github.com) reviewed 2022-08-30 19:47:50 +02:00
ui/scss/component/_card.scss
ByronEricPerez (Migrated from github.com) commented 2022-08-30 19:47:50 +02:00
Copy link

Hi @jessopb , Alignment fixed. Create a new class for the element.

image

image

What do you think?

Hi @jessopb , Alignment fixed. Create a new class for the element. ![image](https://user-images.githubusercontent.com/89370060/187506878-e28a53df-2d21-46eb-ad5a-ace45f039a1e.png) ![image](https://user-images.githubusercontent.com/89370060/187507024-34263797-6b74-4cf3-98a5-0ab430be5fb1.png) What do you think?
jessopb commented 2022-08-30 19:52:38 +02:00 (Migrated from github.com)
Copy link

Put the refresh button last, and it's a bit too wide, I think.

Put the refresh button last, and it's a bit too wide, I think.
jessopb (Migrated from github.com) reviewed 2022-08-30 19:53:26 +02:00
ui/scss/component/_card.scss
jessopb (Migrated from github.com) commented 2022-08-30 19:53:26 +02:00
Copy link

Ideally, it's only as wide as the longest server name, but also up to a limit.

Ideally, it's only as wide as the longest server name, but also up to a limit.
ByronEricPerez (Migrated from github.com) reviewed 2022-09-05 16:15:58 +02:00
ui/scss/component/_card.scss
ByronEricPerez (Migrated from github.com) commented 2022-09-05 16:15:58 +02:00
Copy link

Hi @jessopb , what do you think?

minim
image

max
image

What do you think of what @kodxana said?

Hi @jessopb , what do you think? minim ![image](https://user-images.githubusercontent.com/89370060/188451151-68b09e79-bdea-464c-8ee4-aca5eef15e77.png) max ![image](https://user-images.githubusercontent.com/89370060/188451662-bf6ea379-a849-43c2-8d5c-fb857aafa523.png) What do you think of what @kodxana said?
jessopb commented 2022-09-05 18:21:28 +02:00 (Migrated from github.com)
Copy link

@kodxana would you like to test this branch?

@kodxana would you like to test this branch?
jessopb (Migrated from github.com) reviewed 2022-09-05 18:22:22 +02:00
ui/scss/component/_card.scss
jessopb (Migrated from github.com) commented 2022-09-05 18:22:22 +02:00
Copy link

I think merging comments sounds really interesting, but sounds like a heavy lift, given how it currently works.

I think merging comments sounds really interesting, but sounds like a heavy lift, given how it currently works.
jessopb (Migrated from github.com) reviewed 2022-09-05 19:01:31 +02:00
jessopb (Migrated from github.com) left a comment
Copy link

Almost there!

Almost there!
ui/scss/component/_card.scss
jessopb (Migrated from github.com) commented 2022-09-05 18:33:50 +02:00
Copy link

These variables don't quite make sense. It may work now, but if that component changes, we don't want unexpected changes here too.

These variables don't quite make sense. It may work now, but if that component changes, we don't want unexpected changes here too.
jessopb (Migrated from github.com) commented 2022-09-05 18:57:57 +02:00
Copy link

Was something broken without this -10px here?

Because these two or three items are in a container 'card__title-actions', you can do this on the container:
&:not(:last-child) {
margin-right: var(--spacing-s);
}

then you shouldn't need each class to add a margin on one side.

Was something broken without this -10px here? Because these two or three items are in a container 'card__title-actions', you can do this on the container: &:not(:last-child) { margin-right: var(--spacing-s); } then you shouldn't need each class to add a margin on one side.
jessopb (Migrated from github.com) commented 2022-09-05 19:00:35 +02:00
Copy link

Also, did you try a text-overflow: ellipsis;

Also, did you try a `text-overflow: ellipsis;`
ByronEricPerez (Migrated from github.com) reviewed 2022-09-08 18:06:05 +02:00
ui/scss/component/_card.scss
ByronEricPerez (Migrated from github.com) commented 2022-09-08 18:06:05 +02:00
Copy link

Hi @jessopb , what do you think?

image

I limit it to 10 characters, how much do you think is optimal?

Hi @jessopb , what do you think? ![image](https://user-images.githubusercontent.com/89370060/189170808-a5f1c58c-5e1b-4267-9bf9-fa0e8679f8af.png) I limit it to 10 characters, how much do you think is optimal?
ByronEricPerez (Migrated from github.com) reviewed 2022-09-08 18:06:25 +02:00
ui/scss/component/_card.scss
ByronEricPerez (Migrated from github.com) commented 2022-09-08 18:06:24 +02:00
Copy link

What would be the ideal space?

this?
image

or this?
image

What would be the ideal space? this? ![image](https://user-images.githubusercontent.com/89370060/189169420-da42cd02-b425-4422-a622-76a9144ef094.png) or this? ![image](https://user-images.githubusercontent.com/89370060/189170403-0925e089-cf8b-44bd-89ec-29cd16aacf7a.png)
jessopb (Migrated from github.com) reviewed 2022-09-16 15:54:02 +02:00
ui/scss/component/_card.scss
jessopb (Migrated from github.com) commented 2022-09-16 15:54:01 +02:00
Copy link

I think the second one, but it's good to check how other places in the app look so that it's consistent.

I think the second one, but it's good to check how other places in the app look so that it's consistent.
jessopb (Migrated from github.com) requested changes 2022-10-04 18:20:57 +02:00
ui/component/commentsList/view.jsx
@ -360,0 +394,4 @@
Comments.setServerUrl(undefined);
} else {
Comments.setServerUrl(selectedServer);
}
jessopb (Migrated from github.com) commented 2022-10-04 18:08:13 +02:00
Copy link

Interesting technique. Try using CSS overflow: and text-overflow: ellipsis

Interesting technique. Try using CSS overflow: and text-overflow: ellipsis
ui/scss/component/_card.scss
@ -642,3 +658,25 @@
}
}
}
jessopb (Migrated from github.com) commented 2022-10-04 18:20:11 +02:00
Copy link

It's good to use variables when the variable is going to be reused multiple places, but this is pretty specific here.
In this code, probably something like: max-width: 12rem - pick some rem number that is reasonable.
Then shrink down to "mobile" size and see if you need a
@media (max-width: $breakpoint-small) { ... } to adjust.

It's good to use variables when the variable is going to be reused multiple places, but this is pretty specific here. In this code, probably something like: max-width: 12rem - pick some rem number that is reasonable. Then shrink down to "mobile" size and see if you need a `@media (max-width: $breakpoint-small) { ... }` to adjust.
jessopb (Migrated from github.com) reviewed 2022-10-22 21:46:47 +02:00
jessopb (Migrated from github.com) left a comment
Copy link

I tested it out and it looks pretty good. Two more things.

  • Rebase it on master
  • call refresh when it switches
I tested it out and it looks pretty good. Two more things. - Rebase it on master - call refresh when it switches
jessopb (Migrated from github.com) approved these changes 2022-10-24 18:36:12 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
jessopb
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#7670
No description provided.
Delete branch "Swap_comment_servers_without_going_to_settings_page_#7365"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?