hide price form field #1247

2018-04-02T19:54:02+02:00

ykris45 commented

2018-04-02 19:54:02 +02:00

(Migrated from github.com)

redesign fixes https://spee.ch/8/ScreenCapture2018-4-3-004459.mp4

ykris45 commented

2018-04-02 21:25:52 +02:00

(Migrated from github.com)

@seanyesmunt please looked my screen capture

neb-b (Migrated from github.com) requested changes

2018-04-03 04:12:01 +02:00

neb-b (Migrated from github.com) left a comment

You can also remove the disabled prop since we aren't showing it anymore. Nice work!

You can also remove the `disabled` prop since we aren't showing it anymore. Nice work!

src/renderer/page/settings/view.jsx

Instead of adding a class, lets just not render this:

{!daemonSettings.disable_max_key_fee && (
<FormFieldPrice ... />
)}

Instead of adding a class, lets just not render this: ``` {!daemonSettings.disable_max_key_fee && ( <FormFieldPrice ... /> )} ```

src/renderer/page/settings/view.jsx

					
				@ -227,13 +227,14 @@ class SettingsPage extends React.PureComponent<Props, State> {

				                    this.onInstantPurchaseEnabledChange(true);

Same here

{instantPurchaseEnabled && (
<FormFieldPrice ... />
)}

Same here ``` {instantPurchaseEnabled && ( <FormFieldPrice ... /> )} ```

ykris45 commented

2018-04-03 04:46:33 +02:00

(Migrated from github.com)

@seanyesmunt if this guys

neb-b commented

2018-04-03 05:49:38 +02:00

(Migrated from github.com)

You still need to get rid of the span

change

<span ... >
    <FormFieldPrice ... />
</span>

to

{!daemonSettings.disable_max_key_fee && (
<FormFieldPrice ... />
)}

You still need to get rid of the span change ``` <span ... > <FormFieldPrice ... /> </span> ``` to ``` {!daemonSettings.disable_max_key_fee && ( <FormFieldPrice ... /> )} ```

ykris45 commented

2018-04-03 12:27:51 +02:00

(Migrated from github.com)

error compiling sean

![image](https://user-images.githubusercontent.com/26609573/38244249-44eff794-3764-11e8-8530-c6759e163ea0.png) error compiling sean

tzarebczan commented

2018-04-03 15:27:13 +02:00

(Migrated from github.com)

@ykris45 can you post the entire error from the console?

ykris45 commented

2018-04-03 15:45:19 +02:00

(Migrated from github.com)

@tzarebczan /src/renderer/page/settings/view.jsx
Module build failed: SyntaxError: C:/Users/CHRIS/Documents/GitHub/lbry-app/src/renderer/page/settings/view.jsx: Unexpected token (188:54)

186 | postfix={__('Choose limit')}
187 | />

188 | {daemonSettings.disable_max_key_fee ? && (
| ^
189 | <FormFieldPrice
190 | name="max_key_fee"
191 | label="Max purchase price"

@ ./src/renderer/page/settings/index.js 21:12-29
@ ./src/renderer/component/router/view.jsx
@ ./src/renderer/component/router/index.js
@ ./src/renderer/component/app/view.jsx
@ ./src/renderer/component/app/index.js
@ ./src/renderer/index.js
@ multi (webpack)-dev-server/client?http://localhost:9080 webpack/hot/dev-server ./src/renderer/index.js "here it is"

@tzarebczan /src/renderer/page/settings/view.jsx Module build failed: SyntaxError: C:/Users/CHRIS/Documents/GitHub/lbry-app/src/renderer/page/settings/view.jsx: Unexpected token (188:54) 186 | postfix={__('Choose limit')} 187 | /> > 188 | {daemonSettings.disable_max_key_fee ? && ( | ^ 189 | <FormFieldPrice 190 | name="max_key_fee" 191 | label="Max purchase price" @ ./src/renderer/page/settings/index.js 21:12-29 @ ./src/renderer/component/router/view.jsx @ ./src/renderer/component/router/index.js @ ./src/renderer/component/app/view.jsx @ ./src/renderer/component/app/index.js @ ./src/renderer/index.js @ multi (webpack)-dev-server/client?http://localhost:9080 webpack/hot/dev-server ./src/renderer/index.js "here it is"

tzarebczan commented

2018-04-04 00:48:08 +02:00

(Migrated from github.com)

@ykris45 double check Sean's suggestion for the code edit, I don't think you implemented it properly.

ykris45 commented

2018-04-04 00:53:40 +02:00

(Migrated from github.com)

i'll check it now.. and double check sean suggestion

ykris45 commented

2018-04-04 01:27:18 +02:00

(Migrated from github.com)

@seanyesmunt please review this. i will tested it on my local machine

neb-b commented

2018-04-04 02:23:48 +02:00

(Migrated from github.com)

Looking good. It seems there is still the issue of starting out with 0, same as in https://github.com/lbryio/lbry-app/pull/1232

I left a comment about the error I'm seeing

Looking good. It seems there is still the issue of starting out with 0, same as in https://github.com/lbryio/lbry-app/pull/1232 I left a comment about the error I'm seeing

ykris45 commented

2018-04-04 21:01:10 +02:00

(Migrated from github.com)

@seanyesmunt what about this PR guys

neb-b commented

2018-04-10 22:21:19 +02:00

(Migrated from github.com)

Sorry @ykris45. I think that error was from another issue. If you squash these commits into 1 I will merge the PR

neb-b (Migrated from github.com) approved these changes

2018-04-10 22:21:23 +02:00

ykris45 commented

2018-04-10 23:15:00 +02:00