LBRYCommunity/lbry-desktop

Pre-fill publish URL after clicking "Put something here" link #1303

Merged

miikkatu merged 2 commits from pre-fill-publish-url into master

2018-04-18 11:30:23 +02:00

miikkatu commented

2018-04-08 13:08:17 +02:00

(Migrated from github.com)

This addresses #1284.

When "put something here" link is clicked, the URL here is first stripped of the lbry:// prefix, and then given as a navigation parameter. Then, the publish page uses this parameter to pre-fill the URL field in the form. Also, if the parameter exists, adding the actual file to be published will not overwrite the URL with the chosen file name.

This addresses #1284. When "put something here" link is clicked, the URL here is first stripped of the lbry:// prefix, and then given as a navigation parameter. Then, the publish page uses this parameter to pre-fill the URL field in the form. Also, if the parameter exists, adding the actual file to be published will not overwrite the URL with the chosen file name.

neb-b (Migrated from github.com) requested changes 2018-04-16 23:59:10 +02:00

neb-b (Migrated from github.com) left a comment

No description provided.

src/renderer/component/fileTile/view.jsx

neb-b (Migrated from github.com) commented

2018-04-16 23:58:47 +02:00

I'm hoping to avoid using navigation params for the publish section. Instead you can use something like:

doClearPublish() // to remove any existing publish data
doUpdatePublishForm({ name: nameFromUri }); // to populate the name
navigate('/publish')

Then nothing should need to be changed inside the publishForm/view.jsx

I'm hoping to avoid using navigation params for the publish section. Instead you can use something like: ``` doClearPublish() // to remove any existing publish data doUpdatePublishForm({ name: nameFromUri }); // to populate the name navigate('/publish') ``` Then nothing should need to be changed inside the `publishForm/view.jsx`

miikkatu commented

2018-04-17 07:41:08 +02:00

(Migrated from github.com)

PR updated per review!

PR updated per review!

neb-b (Migrated from github.com) requested changes 2018-04-18 07:37:27 +02:00

neb-b (Migrated from github.com) left a comment

Sweet 😎

I will merge after fixing the the changelog

Sweet 😎 I will merge after fixing the the changelog

neb-b (Migrated from github.com) commented

2018-04-18 07:36:44 +02:00

Guessing you accidentally added this

Guessing you accidentally added this

neb-b commented

2018-04-18 07:38:05 +02:00

(Migrated from github.com)

Also looks like there are some conflicts after merging the lbry-redux pr's

Also looks like there are some conflicts after merging the `lbry-redux` pr's

miikkatu commented

2018-04-18 08:15:43 +02:00

(Migrated from github.com)

@seanyesmunt I fixed the conflicts and removed that extra line from changelog.

@seanyesmunt I fixed the conflicts and removed that extra line from changelog.

neb-b commented

2018-04-18 08:19:00 +02:00

(Migrated from github.com)

Looks like you still have some extra stuff in the changelog

Looks like you still have some extra stuff in the changelog

miikkatu commented

2018-04-18 08:25:58 +02:00

(Migrated from github.com)

Maybe the changelog is now ok...

Maybe the changelog is now ok...

neb-b (Migrated from github.com) approved these changes 2018-04-18 11:28:32 +02:00

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1303

No description provided.