Validate thumbnails #1755

Merged

daovist merged 6 commits from verify-thumbnail-url into master

2018-07-19 17:12:11 +02:00

daovist commented

2018-07-11 20:49:35 +02:00

(Migrated from github.com)

#1362

Inform the user whether their manually entered thumbnail URL is valid and display a preview of it.

I mostly forgot how to do CSS after Bootstrap came out and most of my early website gigs were pixel-to-HTML so my design skills are severely lacking. This will probably need some input/touchup from others.

#1362 Inform the user whether their manually entered thumbnail URL is valid and display a preview of it. I mostly forgot how to do CSS after Bootstrap came out and most of my early website gigs were pixel-to-HTML so my design skills are severely lacking. This will probably need some input/touchup from others. ![manual thumbnail preview](https://user-images.githubusercontent.com/34498824/42593132-9d773262-8519-11e8-9e12-ef70f73948fd.png)

kauffj commented

2018-07-11 20:51:29 +02:00

(Migrated from github.com)

Great idea! (Agreed UI should likely change a bit)

neb-b commented

2018-07-12 04:56:14 +02:00

(Migrated from github.com)

This is awesome. Will think about how we can display this in the app.

neb-b commented

2018-07-18 17:57:05 +02:00

(Migrated from github.com)

Current design:

Manual mode with no/invalid thumbnail
Manual mode with valid thumbnail
Upload thumbnail complete

Current design: - Manual mode with no/invalid thumbnail <img width="400" alt="screen shot 2018-07-18 at 11 56 20 am" src="https://user-images.githubusercontent.com/16882830/42893195-ae0728ae-8a81-11e8-850d-c31098684aab.png"> - Manual mode with valid thumbnail <img width="400" alt="screen shot 2018-07-18 at 11 53 45 am" src="https://user-images.githubusercontent.com/16882830/42893175-a4b8c410-8a81-11e8-81ea-a65b114ddf91.png"> - Upload thumbnail complete <img width="400" alt="screen shot 2018-07-18 at 12 00 11 pm" src="https://user-images.githubusercontent.com/16882830/42893378-2c8e2cb8-8a82-11e8-8d92-5c27a832dc21.png">

neb-b commented

2018-07-18 18:02:39 +02:00

(Migrated from github.com)

I think the only thing left would be to create a proper "No thumbnail chosen" (or whatever we want to call it) image to use instead of the quick one I added.