recommended content v1 #1817

2018-07-25T02:50:45+02:00

neb-b commented

2018-07-25 02:50:45 +02:00

(Migrated from github.com)

Changes

Brings in page 1 of a channel's content
- doesn't do anything for anonymous videos (will be implemented with #1743)
New styling for file price amount. No longer covers part of the thumbnail
FileTile now has two styles (normal and small)
- Normal is the tile used on the search page
- Small is the tile used in recommended videos

Aware of a style issue on the search page re: file price location

I will do another pass on overall styling with the addition of search results from recommended content

### Changes - Brings in page 1 of a channel's content - doesn't do anything for anonymous videos (will be implemented with #1743) - New styling for file price amount. No longer covers part of the thumbnail - FileTile now has two styles (normal and small) - Normal is the tile used on the search page - Small is the tile used in recommended videos Aware of a style issue on the search page re: file price location I will do another pass on overall styling with the addition of search results from recommended content <img width="1274" alt="screen shot 2018-07-25 at 2 39 23 pm" src="https://user-images.githubusercontent.com/16882830/43220664-95ea1f64-9018-11e8-859c-16040fa046b9.png">

neb-b (Migrated from github.com) reviewed 2018-07-25 20:16:22 +02:00

src/renderer/component/recommendedContent/view.jsx

					
				@ -0,0 +28,4 @@

				    let recommendedContent;

				    if (claimsInChannel) {

				      recommendedContent = claimsInChannel.filter(claim => {

neb-b (Migrated from github.com) commented

2018-07-25 20:16:22 +02:00

This will be moved into a selector when I add recommended content from search results (my next PR)

skhameneh (Migrated from github.com) approved these changes 2018-07-25 21:34:13 +02:00

skhameneh (Migrated from github.com) left a comment

Looks good, I still need to test it out myself

src/renderer/component/common/form-components/form-field.jsx

skhameneh (Migrated from github.com) commented

2018-07-25 20:48:27 +02:00

Should this be done in pure CSS instead?

src/renderer/component/filePrice/view.jsx

					
				@ -42,4 +50,3 @@

				        showFree

				        showFullPrice={showFullPrice}

				      />

				    ) : null;

skhameneh (Migrated from github.com) commented

2018-07-25 20:47:44 +02:00

Minor: Split to multiple lines.

src/renderer/component/recommendedContent/view.jsx

					
				@ -0,0 +28,4 @@

				    let recommendedContent;

				    if (claimsInChannel) {

				      recommendedContent = claimsInChannel.filter(claim => {

skhameneh (Migrated from github.com) commented

2018-07-25 20:59:00 +02:00

👍

src/renderer/page/file/view.jsx

skhameneh (Migrated from github.com) commented

2018-07-25 21:06:31 +02:00

Single quotes for consistency

neb-b (Migrated from github.com) reviewed 2018-07-31 21:24:37 +02:00

src/renderer/component/common/form-components/form-field.jsx

neb-b (Migrated from github.com) commented

2018-07-31 21:24:36 +02:00

I'm not super happy with this but currently there is a padding-top on all input elements. I plan to remove that because it's caused a lot of issues with input elelements that are in non-standard places (like this autoplay toggle).