Watch lbry-redux for changes #1822

Merged
skhameneh merged 2 commits from watch-lbry-redux into master 2018-07-26 18:02:27 +02:00
3 changed files with 682 additions and 52 deletions

View file

@ -44,6 +44,7 @@
"electron-publisher-s3": "^20.8.1",
"electron-updater": "^2.23.3",
"electron-window-state": "^4.1.1",
"filewatcher-webpack-plugin": "^1.2.0",
"find-process": "^1.1.0",
"formik": "^0.10.4",
"hast-util-sanitize": "^1.1.2",

View file

@ -1,7 +1,16 @@
const path = require('path');
const FilewatcherPlugin = require('filewatcher-webpack-plugin');
const ELECTRON_RENDERER_PROCESS_ROOT = path.resolve(__dirname, 'src/renderer/');
let PROCESS_ARGV = process.env.npm_config_argv;
if (PROCESS_ARGV) {
PROCESS_ARGV = JSON.parse(PROCESS_ARGV);
}
const isDev = PROCESS_ARGV && PROCESS_ARGV.original &&
neb-b commented 2018-07-26 07:32:03 +02:00 (Migrated from github.com)
Review

Could electron-is-dev be used here?

Could `electron-is-dev` be used here?
skhameneh commented 2018-07-26 07:48:31 +02:00 (Migrated from github.com)
Review

Nope because this isn't inside the Electron runtime, this is for Webpack at build time.

Nope because this isn't inside the Electron runtime, this is for Webpack at build time.
neb-b commented 2018-07-26 07:59:09 +02:00 (Migrated from github.com)
Review

Ah duh.

Ah duh.
(PROCESS_ARGV.original.indexOf('dev') !== -1);
module.exports = {
// This rule is temporarily necessary until https://github.com/electron-userland/electron-webpack/issues/60 is fixed.
module: {
@ -20,4 +29,9 @@ module.exports = {
modules: [ELECTRON_RENDERER_PROCESS_ROOT, 'node_modules', __dirname],
extensions: ['.js', '.jsx', '.scss'],
},
plugins: isDev ? [
new FilewatcherPlugin({
watchFileRegex: [require.resolve('lbry-redux')],
}),
] : [],
};

719
yarn.lock

File diff suppressed because it is too large Load diff