LBRYCommunity/lbry-desktop

Add timeout for jayson client requests #191

Merged

krrishnarraj merged 1 commit from master into master

2017-06-05 01:06:38 +02:00

krrishnarraj commented

2017-06-03 10:16:27 +02:00

(Migrated from github.com)

request() didn't hit the callback sometimes
fixes #19
fixes #188

Timeout is currently set to 1000 ms, please choose an optimal number

request() didn't hit the callback sometimes fixes #19 fixes #188 Timeout is currently set to 1000 ms, please choose an optimal number

krrishnarraj commented

2017-06-03 10:31:17 +02:00

(Migrated from github.com)

I still see one more problem.
The daemon when launched by app, takes around 10-12 secs to initialize completely. By then app timeouts and reports 'Connection Failure'. Can this time be increased or retried?

I still see one more problem. The daemon when launched by app, takes around 10-12 secs to initialize completely. By then app timeouts and reports 'Connection Failure'. Can this time be increased or retried?

kauffj commented

2017-06-05 01:06:31 +02:00

(Migrated from github.com)

@krrishnarraj Thanks for fixing this. I think there is still a problem with detecting and handling unresponsive daemons, but this should address the tickets you mention.

The app will later poll that endpoint for up to about a minute, so 1 second as a timeout works fine for this even with a 10-12 second initialize time.

Please DM me as kauffj in our Slack if you'd like a tip for this PR.

@krrishnarraj Thanks for fixing this. I think there is still a problem with detecting and handling unresponsive daemons, but this should address the tickets you mention. The app will later poll that endpoint for up to about a minute, so 1 second as a timeout works fine for this even with a 10-12 second initialize time. Please DM me as kauffj in our Slack if you'd like a tip for this PR.

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#191

No description provided.