Store claims by claim_id and fileinfo by sd_hash #192

Merged

6ea86b96 merged 5 commits from claims-by-id into master

2017-06-07 17:09:39 +02:00

6ea86b96 commented

2017-06-04 17:59:09 +02:00

(Migrated from github.com)

No description provided.

kauffj commented

2017-06-05 00:52:20 +02:00

(Migrated from github.com)

@6ea86b96 unfortunately sd_hash is not guaranteed to be unique per fileInfo, while outpoint is. Technically, any number of claim entries could resolve to the same sd_hash.

Storing claims by id is definitely a smart change, please reduce this PR to just that and re-assign to me.

@6ea86b96 unfortunately `sd_hash` is not guaranteed to be unique per `fileInfo`, while `outpoint` is. Technically, any number of claim entries could resolve to the same `sd_hash`. Storing claims by id is definitely a smart change, please reduce this PR to just that and re-assign to me.

6ea86b96 commented

2017-06-05 07:35:05 +02:00

(Migrated from github.com)

Hmm, that's a bummer with the sd_hash. I did that to be able to store pending uploads in the state. Will think about a different way to tackle pending uploads then.

Hmm, that's a bummer with the `sd_hash`. I did that to be able to store pending uploads in the state. Will think about a different way to tackle pending uploads then.

6ea86b96 commented

2017-06-05 07:35:55 +02:00

(Migrated from github.com)

Ok, rebased out the fileinfo stuff @kauffj. It seems I can't assign the PR to you though.

6ea86b96 commented

2017-06-05 08:41:04 +02:00

(Migrated from github.com)

I also have a question about the way claims/certificates work. I just commented this out for now as I didn't really understand what it's doing. https://github.com/lbryio/lbry-app/pull/192/files#diff-152922ea714e848ca916a0fde611d75eR25

6ea86b96 commented

2017-06-05 09:44:25 +02:00

(Migrated from github.com)

Also, it seems that this PR introduces a bug for uris that have no claim. Happens when searching. We end up in an infinite resolve loop.

6ea86b96 commented

2017-06-05 10:19:08 +02:00

(Migrated from github.com)

The loop is caused by the setTimeout that keeps trying to resolve the claim in doFetchCostInfoForUri

The loop is caused by the `setTimeout` that keeps trying to resolve the claim in `doFetchCostInfoForUri`

6ea86b96 commented

2017-06-06 05:18:50 +02:00

(Migrated from github.com)

hmm, ok, so I see that the certificates stuff I commented out has broken the channel pages.

6ea86b96 commented

2017-06-06 06:47:56 +02:00

(Migrated from github.com)

ok, nvm, I fixed those. I think this is good for review now @kauffj

kauffj commented

2017-06-07 00:01:29 +02:00

(Migrated from github.com)

Would you mind cleaning up these merge conflicts? Sorry to have created extra work for you. I was working backwards off of my email and thought this wasn't ready, or I would have merged it first.

6ea86b96 commented

2017-06-07 03:40:44 +02:00

(Migrated from github.com)

rebased