adds open.lbry.io links to socialShare Re: Issue # 1810 #1989

Merged

jessopb merged 1 commit from expandedShare into master

2018-10-04 22:53:24 +02:00

jessopb commented

2018-09-29 20:37:44 +02:00

(Migrated from github.com)

This feels clean to me. Tooltip was causing lots of flow errors, and on reflection, I don't think it's needed.

This feels clean to me. Tooltip was causing lots of flow errors, and on reflection, I don't think it's needed. ![sharenowebnotooltip](https://user-images.githubusercontent.com/36554050/46249128-fe8d2e00-c3f1-11e8-9d7b-c7a94d6c5de9.png) ![sharenotooltip](https://user-images.githubusercontent.com/36554050/46249116-c4239100-c3f1-11e8-8c14-98d50b77d3ec.png)

jessopb commented

2018-09-29 20:41:07 +02:00

(Migrated from github.com)

CopyableText can completely replace Address and provides the ability to be a textarea if needed. I can go through and replace Address in all cases in this PR or the next.

neb-b commented

2018-10-01 04:55:20 +02:00

(Migrated from github.com)

Not feeling very well so I'll give this a better look tomorrow. I think we can rename the top to just Web link (and remove the ":")

I think spee.ch should just stay as an icon button to be consistent and probably centered with the other buttons. I think you said you were having issues with the tooltip? That issue keeps cropping up, I think we should just fix it (not part of this PR, just had that thought).

Not feeling very well so I'll give this a better look tomorrow. I think we can rename the top to just `Web link` (and remove the ":") I think spee.ch should just stay as an icon button to be consistent and probably centered with the other buttons. I think you said you were having issues with the tooltip? That issue keeps cropping up, I think we should just fix it (not part of this PR, just had that thought).

👍 1

jessopb commented

2018-10-03 19:14:37 +02:00

(Migrated from github.com)

I should have the requested changes to labeling done tonight. Infant care + moving!

👍 1

jessopb commented

2018-10-04 04:51:23 +02:00

(Migrated from github.com)

This commit should satisfy the feedback I got.
webShareable was less clear to lbry developers than speechShareable, so I just kept that, and spelled it the way most of the world spells it. Buttons are centered and TooltTip is reenabled. Hopefully 'Web link' and 'LBRY App link' are acceptable labels.
Let me know if there's anything else to change.

This commit should satisfy the feedback I got. webShareable was less clear to lbry developers than speechShareable, so I just kept that, and spelled it the way most of the world spells it. Buttons are centered and TooltTip is reenabled. Hopefully 'Web link' and 'LBRY App link' are acceptable labels. Let me know if there's anything else to change. ![sharefinal](https://user-images.githubusercontent.com/36554050/46450351-d5a4ca00-c75e-11e8-87ee-6d0d03624edc.png)

neb-b commented

2018-10-04 20:42:31 +02:00

(Migrated from github.com)

Great. I'll review the code once more when I get home but this looks great.

neb-b commented

2018-10-04 22:53:19 +02:00

(Migrated from github.com)

Not sure why windows keeps failing. This looks good.

tzarebczan commented

2018-10-05 01:18:03 +02:00

(Migrated from github.com)

Hey @jessopb, thanks for the feature, I love it! Don't forget to shoot us an email if you'd like LBC in appreciation for your efforts :)

Hey @jessopb, thanks for the feature, I love it! Don't forget to [shoot us an email](https://lbry.io/faq/appreciation) if you'd like LBC in appreciation for your efforts :)