Outstanding routing cleanup #2405

Merged
neb-b merged 3 commits from fixes into master 2019-04-04 05:27:21 +02:00
neb-b commented 2019-04-02 23:36:13 +02:00 (Migrated from github.com)
  • Now jumps to top on navigate (will fix this not working on forward/back, but it's better for now)
  • File card hover effect
  • Removed insufficient credits modal for inline elements on the publish/file page. Now it will always be shown if users can't take any actions without getting more LBC.
    • Will come back to the copy after hearing from the growth team
- Now jumps to top on navigate (will fix this not working on forward/back, but it's better for now) - File card hover effect - Removed insufficient credits modal for inline elements on the publish/file page. Now it will always be shown if users can't take any actions without getting more LBC. - Will come back to the copy after hearing from the growth team
neb-b (Migrated from github.com) reviewed 2019-04-03 06:18:13 +02:00
@ -72,3 +72,3 @@
<Header />
<main className="page">
<section className="page">
{enhancedLayout && <Yrbl className="yrbl--enhanced" />}
neb-b (Migrated from github.com) commented 2019-04-03 06:18:12 +02:00

The <Page> component contained <main> too. It makes more sense to keep there.

The `<Page>` component contained `<main>` too. It makes more sense to keep there.
skhameneh (Migrated from github.com) approved these changes 2019-04-03 17:20:01 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2405
No description provided.