LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Comment Styling #2510

Merged
NetOpWibby merged 11 commits from redux-comments into master 2019-06-27 02:32:44 +02:00
Conversation 0 Commits 11 Files changed 23 +350 -92
NetOpWibby commented 2019-05-24 17:10:01 +02:00 (Migrated from github.com)
Copy link

PR Checklist

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Feature
  • Code style update (formatting)

Fixes

What is the current behavior?

Comments are not styled.

What is the new behavior?

Comments are styled.

## PR Checklist - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [x] Feature - [x] Code style update (formatting) ## Fixes ## What is the current behavior? Comments are not styled. ## What is the new behavior? Comments are styled.
neb-b (Migrated from github.com) requested changes 2019-06-20 04:27:32 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

Tested and it seems to work pretty good.

Tested and it seems to work pretty good.
src/ui/component/commentCreate/view.jsx
neb-b (Migrated from github.com) commented 2019-06-20 04:10:04 +02:00
Copy link

Instead of 'no', this can just be a boolean

Instead of `'no'`, this can just be a boolean
neb-b (Migrated from github.com) commented 2019-06-20 04:11:31 +02:00
Copy link

I'm not sure if we need a title along with this? I guess it depends on what that messaging ends up being.

I'm not sure if we need a title along with this? I guess it depends on what that messaging ends up being.
src/ui/component/commentsList/view.jsx
neb-b (Migrated from github.com) commented 2019-06-20 04:19:49 +02:00
Copy link

Comment should be broken into it's own file. Then in CommentsList, pass commentId that can be used to select the comment.

Then if we ever require more data to display a comment, we only have to update one place, instead of having to pass another prop to it in this file

Comment should be broken into it's own file. Then in CommentsList, pass `commentId` that can be used to select the comment. Then if we ever require more data to display a comment, we only have to update one place, instead of having to pass another prop to it in this file
src/ui/component/fileDetails/view.jsx
neb-b (Migrated from github.com) commented 2019-06-20 04:20:43 +02:00
Copy link

This whole thing can just be removed. We don't need to show a snackbar

This whole thing can just be removed. We don't need to show a snackbar
src/ui/constants/settings.js
neb-b (Migrated from github.com) commented 2019-06-20 04:21:24 +02:00
Copy link

We don't need this

We don't need this
src/ui/page/file/view.jsx
neb-b (Migrated from github.com) commented 2019-06-20 04:21:44 +02:00
Copy link

👍

👍
src/ui/redux/selectors/app.js
neb-b (Migrated from github.com) commented 2019-06-20 04:22:36 +02:00
Copy link

here

here
jessopb (Migrated from github.com) reviewed 2019-06-24 05:13:58 +02:00
src/ui/component/commentCreate/view.jsx
jessopb (Migrated from github.com) commented 2019-06-24 05:13:58 +02:00
Copy link

@kauffj was going to do some copy for this section.

@kauffj was going to do some copy for this section.
osilkin98 (Migrated from github.com) reviewed 2019-06-24 07:53:39 +02:00
src/ui/redux/selectors/app.js
osilkin98 (Migrated from github.com) commented 2019-06-24 07:53:39 +02:00
Copy link

here

here
osilkin98 (Migrated from github.com) reviewed 2019-06-24 08:09:50 +02:00
src/ui/scss/component/_comments.scss
osilkin98 (Migrated from github.com) commented 2019-06-24 08:09:50 +02:00
Copy link

We're not doing upvotes/downvotes. The only time I can see that is if when move to using claims as comments, we can count supports with say, 10 confirmations as being upvotes.

We're not doing upvotes/downvotes. The only time I can see that is if when move to using claims as comments, we can count supports with say, 10 confirmations as being upvotes.
kauffj (Migrated from github.com) requested changes 2019-06-26 19:30:51 +02:00
kauffj (Migrated from github.com) left a comment
Copy link

Some suggested changes, but nothing strong.

This review was inspection only until issues introduced by rebase are addressed.

Some suggested changes, but nothing strong. This review was inspection only until issues introduced by rebase are addressed.
src/ui/component/commentCreate/view.jsx
kauffj (Migrated from github.com) commented 2019-06-26 18:55:25 +02:00
Copy link

I am all for consting all special values, but this one could probably be skipped

I am all for `const`ing all special values, but this one could probably be skipped
kauffj (Migrated from github.com) commented 2019-06-26 19:00:20 +02:00
Copy link

The new here is a value that comes from <ChannelSection>, which is the right time to use a const (otherwise, when editing ChannelSection, I'd have to check every place it is embedded and manually read all of that code to see if "new" is being used or checked against).

The `new` here is a value that comes from `<ChannelSection>`, which _is_ the right time to use a `const` (otherwise, when editing `ChannelSection`, I'd have to check every place it is embedded and manually read all of that code to see if `"new"` is being used or checked against).
src/ui/component/commentCreate/view.jsx
@ -0,0 +37,4 @@
return (
<React.Fragment>
{commentAck !== true && (
kauffj (Migrated from github.com) commented 2019-06-26 18:57:00 +02:00
Copy link

if commentAck is false it looks like this returns nothing, so this could probably be tidied down to one check

if `commentAck` is false it looks like this returns nothing, so this could probably be tidied down to one check
src/ui/component/commentsList/view.jsx
kauffj (Migrated from github.com) commented 2019-06-26 19:01:35 +02:00
Copy link

<strong>{this.props.author ? this.props.author : __("Anonymous") }</strong>

` <strong>{this.props.author ? this.props.author : __("Anonymous") }</strong>`
kauffj (Migrated from github.com) commented 2019-06-26 19:01:53 +02:00
Copy link

(note i18n call as well as simplification)

(note i18n call as well as simplification)
kauffj (Migrated from github.com) commented 2019-06-26 19:02:21 +02:00
Copy link

comment is always applied as a class, so could be omitted from both sides

comment is always applied as a class, so could be omitted from both sides
src/ui/component/fileViewer/view.jsx
@ -80,1 +79,4 @@
// Commented out because it would play/pause if you were typing in the comment field
// Need a way to check if you are typing
// window.addEventListener('keydown', this.handleKeyDown);
}
kauffj (Migrated from github.com) commented 2019-06-26 19:07:34 +02:00
Copy link

is this functionality being removed? maybe comment out the function too and explain why if it's anticipated that it returns?

is this functionality being removed? maybe comment out the function too and explain why if it's anticipated that it returns?
src/ui/redux/actions/app.js
kauffj (Migrated from github.com) commented 2019-06-26 19:03:23 +02:00
Copy link

intended?

intended?
src/ui/redux/reducers/app.js
kauffj (Migrated from github.com) commented 2019-06-26 19:03:32 +02:00
Copy link

intended?

intended?
src/ui/scss/component/_comments.scss
kauffj (Migrated from github.com) commented 2019-06-26 19:04:06 +02:00
Copy link

this should be the class comment--reply and be a first-class rule (i.e. not nested) if we're following BEM

this should be the class `comment--reply` and be a first-class rule (i.e. not nested) if we're following BEM
kauffj (Migrated from github.com) commented 2019-06-26 19:05:04 +02:00
Copy link

please comment out any CSS that is not being used

please comment out any CSS that is not being used
jessopb (Migrated from github.com) reviewed 2019-06-26 20:23:25 +02:00
src/ui/component/commentCreate/view.jsx
@ -0,0 +37,4 @@
return (
<React.Fragment>
{commentAck !== true && (
jessopb (Migrated from github.com) commented 2019-06-26 20:23:25 +02:00
Copy link

if it's false, it shows you the acknowledgment box.
if it's true, it shows you the commenting tool.

if it's false, it shows you the acknowledgment box. if it's true, it shows you the commenting tool.
osilkin98 (Migrated from github.com) reviewed 2019-06-26 21:47:33 +02:00
src/ui/component/commentsList/view.jsx
osilkin98 (Migrated from github.com) commented 2019-06-26 21:47:33 +02:00
Copy link

Use this

{this.props.author}

in place of

  <Button className="button--uri-indicator" navigate={this.props.uri}>
          {inner}
 </Button>
  );
}

The schema you're using is a little out of date, you may want to compare it with the one I have on my branch

Use this ```js {this.props.author} ``` in place of ```js <Button className="button--uri-indicator" navigate={this.props.uri}> {inner} </Button> ); } ``` The schema you're using is a little out of date, you may want to compare it with the one I have on [my branch](https://github.com/osilkin98/lbry-desktop/blob/953ee3988fc6ca4af2514c9dd2a3761764feccfd/src/ui/component/uriIndicator/view.jsx#L6)
kauffj (Migrated from github.com) reviewed 2019-06-26 23:57:33 +02:00
src/ui/component/fileViewer/view.jsx
@ -80,1 +79,4 @@
// Commented out because it would play/pause if you were typing in the comment field
// Need a way to check if you are typing
// window.addEventListener('keydown', this.handleKeyDown);
}
kauffj (Migrated from github.com) commented 2019-06-26 23:57:33 +02:00
Copy link

@jessopb I'm fixing most of my own comments but I don't know what or why this was changed, so I'm leaving as is

@jessopb I'm fixing most of my own comments but I don't know what or why this was changed, so I'm leaving as is
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
kauffj
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2510
No description provided.
Delete branch "redux-comments"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?