Copy path, open, and backup buttons for wallet on Help page #2585

Closed

ghost wants to merge 1 commit from wallet-backup-buttons into 0.33.2

ghost commented

2019-06-28 20:52:51 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #1601 #1635

What is the current behavior?

What is the new behavior?

There are buttons to copy the path of the lbryum folder to the clipboard, open that folder in the system's file manager, and create a backup zip archive of the folder's contents. The backup zip's filename includes a timestamp, and it gets placed (in order of preference) in the user's Downloads folder, in their home folder, or right next to the lbryum folder itself. Afterwards, the backup zip is shown in the system file manager at which point the user can choose what to do with it.

Other information

The zipping functionality is provided by the adm-zip package, and it is unfortunately synchronous, locking the UI for a second or so. I initially tested the asynchronous archiver package but was unable to get it to work in Electron.

Similar to #1628 and #1638 which were closed but not merged. If desired, I could attempt to make the "copy path" functionality more in line with what was discussed in those PRs with a new CopyableInput component.

I hesitate to submit features unsolicited, so no worries if this isn't quite what you're looking for. My main goal with this work has been to learn more about Electron and freshen up on React, but I hope you find it useful.

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #1601 #1635 ## What is the current behavior? ## What is the new behavior? There are buttons to copy the path of the lbryum folder to the clipboard, open that folder in the system's file manager, and create a backup zip archive of the folder's contents. The backup zip's filename includes a timestamp, and it gets placed (in order of preference) in the user's Downloads folder, in their home folder, or right next to the lbryum folder itself. Afterwards, the backup zip is shown in the system file manager at which point the user can choose what to do with it. ## Other information The zipping functionality is provided by the `adm-zip` package, and it is unfortunately synchronous, locking the UI for a second or so. I initially tested the asynchronous `archiver` package but was unable to get it to work in Electron. Similar to #1628 and #1638 which were closed but not merged. If desired, I could attempt to make the "copy path" functionality more in line with what was discussed in those PRs with a new CopyableInput component. I hesitate to submit features unsolicited, so no worries if this isn't quite what you're looking for. My main goal with this work has been to learn more about Electron and freshen up on React, but I hope you find it useful.

tzarebczan commented

2019-06-28 20:54:37 +02:00

(Migrated from github.com)

hey @jcamp0x2a , thanks so much for the PR and explanation, this is awesome! We'll get a review on it...

Can we show you some appreciation for your contribution?

hey @jcamp0x2a , thanks so much for the PR and explanation, this is awesome! We'll get a review on it... Can we show you some [appreciation](https://lbry.com/faq/appreciation) for your contribution?

neb-b commented

2019-06-28 20:54:56 +02:00

(Migrated from github.com)

Thank your for the PR! Could you reopen a new one against the master branch? A lot has changed with it since the release of 0.33.2

Thank your for the PR! Could you reopen a new one against the `master` branch? A lot has changed with it since the release of `0.33.2`

ghost commented

2019-06-29 00:15:30 +02:00

(Migrated from github.com)

Will do :)