changes splash experience #2721

Merged
jessopb merged 3 commits from splashchange into master 2019-08-09 19:13:31 +02:00
jessopb commented 2019-08-09 00:32:22 +02:00 (Migrated from github.com)
  • disable spin button
  • startup status changes from tzarebczan

Comments on button presentation?
Worth deconstructing some feather icons (aperture?) to make a spiral?

- disable spin button - startup status changes from tzarebczan Comments on button presentation? Worth deconstructing some feather icons (aperture?) to make a spiral?
neb-b (Migrated from github.com) reviewed 2019-08-09 00:32:22 +02:00
tzarebczan (Migrated from github.com) reviewed 2019-08-09 11:31:17 +02:00
tzarebczan (Migrated from github.com) commented 2019-08-09 11:31:17 +02:00

@jessopb what are these yarn lock changes? Maybe need to rebase, or someone overwrote the last PR I had for electron builder?

@jessopb what are these yarn lock changes? Maybe need to rebase, or someone overwrote the last PR I had for electron builder?
tzarebczan commented 2019-08-09 18:17:01 +02:00 (Migrated from github.com)

Made some small changes so we don't show blocks behind if it's a short status. @seanyesmunt mentioned we need to cancel the timeouts, so he'd take care of that (there's 2 fyi).

There is a scenario where it shows the blocks behind anyway - I think the headers component may not be available right away sometimes, so it enters the blocks behind if statement. Doesn't happen all the time, not super worried about it now.

Made some small changes so we don't show blocks behind if it's a short status. @seanyesmunt mentioned we need to cancel the timeouts, so he'd take care of that (there's 2 fyi). There is a scenario where it shows the blocks behind anyway - I think the headers component may not be available right away sometimes, so it enters the blocks behind if statement. Doesn't happen all the time, not super worried about it now.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2721
No description provided.