Add char count and max char info near textarea of comments area #2944

Merged

danielcaldas merged 2 commits from feature/char-count-max-char-info into master

2019-10-01 06:58:56 +02:00

danielcaldas commented

2019-09-30 23:19:38 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

https://github.com/lbryio/lbry-desktop/issues/2859

What is the current behavior?

No information about character count. Also no limit on the textarea for comments.

What is the new behavior?

The new behavior is demonstrated in the below GIF.

## PR Checklist Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: https://github.com/lbryio/lbry-desktop/issues/2859 ## What is the current behavior? No information about character count. Also no limit on the textarea for comments. ## What is the new behavior? The new behavior is demonstrated in the below GIF. ![counter-info](https://user-images.githubusercontent.com/11733994/65917883-b162e400-e3d8-11e9-8e43-0cc1d1338670.gif)

neb-b (Migrated from github.com) requested changes

2019-09-30 23:25:56 +02:00

neb-b (Migrated from github.com) left a comment

Just a couple comments. Great work!

src/ui/component/common/form-components/form-field.jsx

neb-b (Migrated from github.com) commented

2019-09-30 23:25:42 +02:00

Instead of an empty string, this should just be 0

Instead of an empty string, this should just be `0`

src/ui/scss/component/_comments.scss

neb-b (Migrated from github.com) commented

2019-09-30 23:25:17 +02:00

Can you change this to font-size: var(--font-label);

Can you change this to `font-size: var(--font-label);`

danielcaldas (Migrated from github.com) reviewed

2019-10-01 00:07:56 +02:00

src/ui/component/common/form-components/form-field.jsx

danielcaldas (Migrated from github.com) commented

2019-10-01 00:07:55 +02:00

Oh sure, missed that one.

danielcaldas (Migrated from github.com) reviewed

2019-10-01 00:08:05 +02:00

src/ui/scss/component/_comments.scss

danielcaldas (Migrated from github.com) commented

2019-10-01 00:08:05 +02:00

Will do

tzarebczan commented

2019-10-03 22:49:24 +02:00

(Migrated from github.com)

@danielcaldas for the PR! Can we show you some appreciation?

Make sure to check out https://lbry.tech/contribute and sign up for the dev mailing list at the bottom!

Also, see https://lbry.com/news/hacktoberfest-2019 for the latest Hacktoberfest details.

@danielcaldas for the PR! Can we show you some [appreciation](https://lbry.com/faq/appreciation)? Make sure to check out https://lbry.tech/contribute and sign up for the dev mailing list at the bottom! Also, see https://lbry.com/news/hacktoberfest-2019 for the latest Hacktoberfest details.

👍 1