fixes flow error on account/view page #2951

Merged
j-collier merged 1 commit from account-view-flow-fix into master 2019-10-02 05:28:17 +02:00
j-collier commented 2019-10-02 05:27:12 +02:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe: Flow error

Fixes

Issue Number: #2024

What is the current behavior?

Props was improperly used as the type for the function signature even though there is no declared type of Props.

What is the new behavior?

any is used in its place as a proper flow type for props in this case

Other information

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [x] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [x] Other - Please describe: Flow error ## Fixes Issue Number: [#2024](https://github.com/lbryio/lbry-desktop/issues/2024) ## What is the current behavior? `Props` was improperly used as the type for the function signature even though there is no declared type of Props. ## What is the new behavior? `any` is used in its place as a proper flow type for props in this case ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
neb-b commented 2019-10-02 05:28:11 +02:00 (Migrated from github.com)

Thanks!

Thanks!
tzarebczan commented 2019-10-02 05:31:16 +02:00 (Migrated from github.com)

@j-collier thanks for the PR! Can we show you some appreciation?

Make sure to check out https://lbry.tech/contribute and sign up for the dev mailing list at the bottom!

@j-collier thanks for the PR! Can we show you some [appreciation](https://lbry.com/faq/appreciation)? Make sure to check out https://lbry.tech/contribute and sign up for the dev mailing list at the bottom!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2951
No description provided.