fix title on small screen #2974

Merged
ykris45 merged 1 commit from patch-3 into master 2019-10-04 07:27:37 +02:00
ykris45 commented 2019-10-04 07:20:01 +02:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • [x ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [ x] Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #2948

What is the current behavior?

The Current behavior is on css use var(--font-heading),
see this screenshot :
image

What is the new behavior?

So. For Alternative method i use xx-large css style to make this better than before i think.
like this screenshot below. my screen resulution is 1280 x 768
image

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #2948 ## What is the current behavior? The Current behavior is on css use var(--font-heading), see this screenshot : ![image](https://user-images.githubusercontent.com/26609573/66182850-c8d3f280-e6a0-11e9-867d-ffbdd344728a.png) ## What is the new behavior? So. For Alternative method i use xx-large css style to make this better than before i think. like this screenshot below. my screen resulution is 1280 x 768 ![image](https://user-images.githubusercontent.com/26609573/66182963-2ff1a700-e6a1-11e9-9323-292c300e8c77.png)
ykris45 commented 2019-10-04 07:22:11 +02:00 (Migrated from github.com)

This Screenshot is taken from my longest channel title, and after i use as new behavior said on above it will make look this screenshot below
image
image

This Screenshot is taken from my longest channel title, and after i use as new behavior said on above it will make look this screenshot below ![image](https://user-images.githubusercontent.com/26609573/66183008-64fdf980-e6a1-11e9-8484-5064368394d0.png) ![image](https://user-images.githubusercontent.com/26609573/66183023-747d4280-e6a1-11e9-8abb-2af6ee9e3611.png)
neb-b commented 2019-10-04 07:27:39 +02:00 (Migrated from github.com)

Thank you! Sorry this got messed up for your channel.

Thank you! Sorry this got messed up for your channel.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2974
No description provided.