Edit title to 'Latest Transactions' from 'Recent Transactions' #3102

Closed

blokboy wants to merge 1 commit from master into master

blokboy commented

2019-10-21 23:16:15 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/3045

What is the current behavior?

Currently the application displays "Recent Transactions" in the title prop of the TransactionList as passed down from TransactionListRecent, and the page size for the pagination is divided by TX_LIST.PAGE_SIZE which is currently set to 50, so we have 50 items per page.

What is the new behavior?

The application will now display "Recent Transactions" at the top of the Transaction List.

Other information

I'll be submitting a PR to the lbry-redux repo as well to modify the constant for page size so that pages now hold 10 items instead of 50

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [x] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/3045 ## What is the current behavior? - Currently the application displays "Recent Transactions" in the title prop of the TransactionList as passed down from TransactionListRecent, and the page size for the pagination is divided by TX_LIST.PAGE_SIZE which is currently set to 50, so we have 50 items per page. ## What is the new behavior? - The application will now display "Recent Transactions" at the top of the Transaction List. ## Other information - I'll be submitting a PR to the lbry-redux repo as well to modify the constant for page size so that pages now hold 10 items instead of 50

neb-b commented

2019-10-22 17:26:57 +02:00

(Migrated from github.com)

Thanks for the two PR's @blokboy

I left a comment on your lbry-redux PR

Thanks for the two PR's @blokboy I left a comment on your `lbry-redux` PR

tzarebczan commented

2019-10-28 15:24:55 +01:00

(Migrated from github.com)

Thanks for the PR! Looks like there are some additional comments for you to review, please take a peek.

Can we show you some appreciation for the contribution?

Also, we're giving away some Hacktoberfest bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.

Thanks for the PR! Looks like there are some additional comments for you to review, please take a peek. Can we show you some [appreciation](https://lbry.com/faq/appreciation) for the contribution? Also, we're giving away some [Hacktoberfest](https://lbry.com/news/hacktoberfest-2019) bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.

neb-b commented

2019-10-31 19:20:13 +01:00

(Migrated from github.com)

I'm going to close this. Feel free to re-open if you would like to finish it!