[WIP] Include tip with comment #3359

Closed

osilkin98 wants to merge 5 commits from tipping into master

osilkin98 commented

2019-12-11 05:21:32 +01:00

(Migrated from github.com)

Includes an option to add a tip to a comment before posting
Also removes 'Comments' section title to make the design look neater

converse ability in the tipping
tips are coupled with comments

Includes an option to add a tip to a comment before posting Also removes 'Comments' section title to make the design look neater - converse ability in the tipping - tips are coupled with comments

tzarebczan commented

2019-12-11 18:36:19 +01:00

(Migrated from github.com)

Planning to add some indication to the comment that it included a tip?

kauffj commented

2020-01-20 21:26:28 +01:00

(Migrated from github.com)

Let's 🚢

Let's :ship:

neb-b commented

2020-01-23 22:12:38 +01:00

(Migrated from github.com)

@osilkin98 is this ready for review? Or does it require more work?

osilkin98 commented

2020-01-23 23:54:16 +01:00

(Migrated from github.com)

This needs SDK-side work to support the desired functionality.

neb-b commented

2020-01-23 23:55:18 +01:00

(Migrated from github.com)

Why can’t we just send a tip after commenting? The functionality can be separated even if it’s bundled in the ui

osilkin98 commented

2020-01-24 00:04:57 +01:00

(Migrated from github.com)

Jeremy wanted them to be coupled, though I would be perfectly fine with
that solution for the time being.

On Thu, Jan 23, 2020 at 5:55 PM Sean Yesmunt notifications@github.com
wrote:

Why can’t we just send a tip after commenting? The functionality can be
separated even if it’s bundled in the ui

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-desktop/pull/3359?email_source=notifications&email_token=AEAH2R3VYOXURTCMQA3K5KDQ7IN5NA5CNFSM4JZI6NIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJZE2IA#issuecomment-577916192,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEAH2R3ZXVWKNFTQXLDFFQTQ7IN5NANCNFSM4JZI6NIA
.

Jeremy wanted them to be coupled, though I would be perfectly fine with that solution for the time being. On Thu, Jan 23, 2020 at 5:55 PM Sean Yesmunt <notifications@github.com> wrote: > Why can’t we just send a tip after commenting? The functionality can be > separated even if it’s bundled in the ui > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-desktop/pull/3359?email_source=notifications&email_token=AEAH2R3VYOXURTCMQA3K5KDQ7IN5NA5CNFSM4JZI6NIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJZE2IA#issuecomment-577916192>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEAH2R3ZXVWKNFTQXLDFFQTQ7IN5NANCNFSM4JZI6NIA> > . >

neb-b commented

2020-01-24 15:43:41 +01:00

(Migrated from github.com)

is that something you plan to work on soon sdk side?

osilkin98 commented

2020-01-24 17:15:15 +01:00

(Migrated from github.com)

Yes

On Jan 24, 2020, at 9:43 AM, Sean Yesmunt notifications@github.com wrote:

is that something you plan to work on soon sdk side?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes > On Jan 24, 2020, at 9:43 AM, Sean Yesmunt <notifications@github.com> wrote: > > is that something you plan to work on soon sdk side? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or unsubscribe.

kauffj commented

2020-01-25 00:06:36 +01:00

(Migrated from github.com)

There may have been some confusion in what I meant by coupling. It needs to be presented to user as a unitary function and ideally both tip and comment would happen atomically.

However, I think it would be okay to send the tip, let that succeed, and then submit the comment if providing atomicity across tip and comment is hard.

There may have been some confusion in what I meant by coupling. It needs to be presented to user as a unitary function and _ideally_ both tip and comment would happen atomically. However, I think it would be okay to send the tip, let that succeed, and then submit the comment if providing atomicity across tip and comment is hard.