LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Packages Projects Releases 238 Wiki Activity

Adds the ability for users to update & delete comments #3453

Merged
osilkin98 merged 2 commits from comment-options into master 2020-01-31 22:30:52 +01:00
Conversation 5 Commits 2 Files changed 11 +202 -43
osilkin98 commented 2020-01-07 06:49:45 +01:00 (Migrated from github.com)
Copy link

Adds the ability for users to update & delete their comments.

Changes:

  • Two new SVG icon are introduced of three circles aligned horizontally and vertically.
  • A new modal is created for the user to confirm before deleting a comment
  • Overall overhaul for the Comment component

This PR depends on #259 for redux to work properly.

Adds the ability for users to update & delete their comments. ### Changes: - Two new SVG icon are introduced of three circles aligned horizontally and vertically. - A new modal is created for the user to confirm before deleting a comment - Overall overhaul for the `Comment` component This PR depends on [#259](https://github.com/lbryio/lbry-redux/pull/259) for redux to work properly.
neb-b (Migrated from github.com) reviewed 2020-01-07 06:49:45 +01:00
neb-b (Migrated from github.com) requested changes 2020-01-23 22:08:27 +01:00
neb-b (Migrated from github.com) left a comment
Copy link

mostly small stuff, this is pretty close.

I also saw an error when I tried to edit a comment. The snackbar was displayed and it said:

there was an error hiding this comment
mostly small stuff, this is pretty close. I also saw an error when I tried to edit a comment. The snackbar was displayed and it said: ``` there was an error hiding this comment ```
package.json
neb-b (Migrated from github.com) commented 2020-01-23 21:58:36 +01:00
Copy link

This should not be removed

This should not be removed
ui/component/comment/view.jsx
@ -28,46 +38,144 @@ function Comment(props: Props) {
timePosted,
message,
neb-b (Migrated from github.com) commented 2020-01-23 22:05:12 +01:00
Copy link

You are already wrapping this in commentIsMine so these aren't needed

You are already wrapping this in `commentIsMine` so these aren't needed
neb-b (Migrated from github.com) commented 2020-01-23 22:06:07 +01:00
Copy link

set a classname based on if it's hovering, then we can use css variables. Currently in dark mode, the dots get darker when you hover.

set a classname based on if it's hovering, then we can use css variables. Currently in dark mode, the dots get darker when you hover.
neb-b (Migrated from github.com) commented 2020-01-23 22:06:34 +01:00
Copy link

The space in between { and commentIsMine is because you disabled the precommit hook which formats the code.

The space in between `{` and `commentIsMine` is because you disabled the precommit hook which formats the code.
neb-b (Migrated from github.com) commented 2020-01-23 22:07:06 +01:00
Copy link

these ^ comments aren't needed

these ^ comments aren't needed
ui/component/comment/view.jsx
@ -69,0 +148,4 @@
</MenuItem>
<MenuItem className="comment__menu-option" onSelect={handleDeleteComment}>
{__('Delete')}
</MenuItem>
neb-b (Migrated from github.com) commented 2020-01-23 22:02:45 +01:00
Copy link

This can just delete the comment, we don't need a modal for it.

This can just delete the comment, we don't need a modal for it.
ui/component/commentsList/view.jsx
@ -13,0 +15,4 @@
// todo: implement comment_list --mine in SDK so redux can grab with selectCommentIsMine
const isMyComment = (channelId: string) => {
if (myChannels != null && channelId != null) {
neb-b (Migrated from github.com) commented 2020-01-23 22:04:30 +01:00
Copy link

This was causing an error when I refreshed on a page with comments

"Cannot read property 'length' of undefined
    at isMyComment"
This was causing an error when I refreshed on a page with comments ``` "Cannot read property 'length' of undefined at isMyComment" ```
ui/constants/icons.js
@ -81,6 +81,7 @@ export const SIGN_IN = 'SignIn';
export const TRENDING = 'Trending';
neb-b (Migrated from github.com) commented 2020-01-23 22:03:50 +01:00
Copy link

remove this one since we aren't using it

remove this one since we aren't using it
ui/modal/modalDeleteComment/view.jsx
neb-b (Migrated from github.com) commented 2020-01-23 22:03:28 +01:00
Copy link

lets get rid of this modal

lets get rid of this modal
osilkin98 (Migrated from github.com) reviewed 2020-01-25 21:01:16 +01:00
package.json
osilkin98 (Migrated from github.com) commented 2020-01-25 21:01:15 +01:00
Copy link

That must've snuck into the commit somehow, will revert.

That must've snuck into the commit somehow, will revert.
osilkin98 (Migrated from github.com) reviewed 2020-01-25 22:11:04 +01:00
ui/component/commentsList/view.jsx
@ -13,0 +15,4 @@
// todo: implement comment_list --mine in SDK so redux can grab with selectCommentIsMine
const isMyComment = (channelId: string) => {
if (myChannels != null && channelId != null) {
osilkin98 (Migrated from github.com) commented 2020-01-25 22:11:04 +01:00
Copy link

Was using myChannels !== null instead of myChannels != null

Was using `myChannels !== null` instead of `myChannels != null`
osilkin98 (Migrated from github.com) reviewed 2020-01-25 23:30:51 +01:00
ui/component/comment/view.jsx
@ -28,46 +38,144 @@ function Comment(props: Props) {
timePosted,
message,
osilkin98 (Migrated from github.com) commented 2020-01-25 23:30:51 +01:00
Copy link

done

done
neb-b commented 2020-01-27 16:41:55 +01:00 (Migrated from github.com)
Copy link

@osilkin98 I still see "error hiding comment" when I edit a comment. It looks like the edit works correctly, but I see the error message every time.

@osilkin98 I still see "error hiding comment" when I edit a comment. It looks like the edit works correctly, but I see the error message every time.
osilkin98 commented 2020-01-28 22:22:13 +01:00 (Migrated from github.com)
Copy link

@seanyesmunt Was this in the web version or the desktop?

@seanyesmunt Was this in the web version or the desktop?
osilkin98 commented 2020-01-28 23:22:16 +01:00 (Migrated from github.com)
Copy link

@seanyesmunt In regards to the toast message, PR #265 should display the correct message in the snackbar.

In regards to displaying the comments as being updated but getting an error, the #265 also fixes that.

@seanyesmunt In regards to the toast message, [PR #265](https://github.com/lbryio/lbry-redux/pull/265) should display the correct message in the snackbar. In regards to displaying the comments as being updated but getting an error, the [#265](https://github.com/lbryio/lbry-redux/pull/265/commits) also fixes that.
osilkin98 commented 2020-01-28 23:37:53 +01:00 (Migrated from github.com)
Copy link

Everything works perfectly fine now, should be safe to merge.

Everything works perfectly fine now, should be safe to merge.
neb-b commented 2020-01-29 20:33:29 +01:00 (Migrated from github.com)
Copy link

@osilkin98 Please squash your commits and rebase, then it's good to merge.

@osilkin98 Please squash your commits and rebase, then it's good to merge.
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#3453
No description provided.
Delete branch "comment-options"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?