LBRYCommunity/lbry-desktop

Fork 0

Choosing "New Publish" Now Clears the Publish Form #3463

Merged

dalhill merged 3 commits from 3348-clear-fields-for-new-publish into master

2020-01-14 16:49:52 +01:00

dalhill commented

2020-01-09 03:04:54 +01:00

(Migrated from github.com)

PR Checklist

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

Bugfix

Fixes

Issue Number: #3348

What is the current behavior?

Font size of cancel button set to --font-small.

The publish form is not cleared by the following actions.

User clicks the "New Publish" drop-down item from the Navigation bar.
User clicks the "Publish something new" button when they go to their publishes and have not published previously.
User clicks the "New Publish" link when they go to their publishes and have already published content.

What is the new behavior?

Font size of cancel button set to --font-large.

Has changed to just "Publish" and continues its behavior of not clearing the form.
Now clears form on click.
Now clears form on click.

## PR Checklist - [X] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [X] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [X] Bugfix ## Fixes Issue Number: #3348 ## What is the current behavior? Font size of cancel button set to `--font-small`. ![cancel](https://user-images.githubusercontent.com/15717854/72314205-951b4800-3653-11ea-849e-3be50e12a3a3.png) The publish form is **not** cleared by the following actions. 1. User clicks the "New Publish" drop-down item from the Navigation bar. ![publish-navbar](https://user-images.githubusercontent.com/15717854/72031153-24d68600-3251-11ea-96f2-f7b6c5c8e3d4.png) 2. User clicks the "Publish something new" button when they go to their publishes and have not published previously. ![publish-button](https://user-images.githubusercontent.com/15717854/72031164-299b3a00-3251-11ea-8223-29a8ec5dc27d.png) 3. User clicks the "New Publish" link when they go to their publishes and have already published content. ![publish-link](https://user-images.githubusercontent.com/15717854/72031178-34ee6580-3251-11ea-80b9-c4b9f427b34c.png) ## What is the new behavior? Font size of cancel button set to `--font-large`. ![cancel-updated](https://user-images.githubusercontent.com/15717854/72314182-803eb480-3653-11ea-8ada-80f2857859b2.png) 1. Has changed to just "Publish" and continues its behavior of not clearing the form. ![publish-navbar-updated](https://user-images.githubusercontent.com/15717854/72313243-6059c180-3650-11ea-8ad2-c8f7aaeddb1f.png) 2. Now clears form on click. 3. Now clears form on click.

neb-b (Migrated from github.com) reviewed 2020-01-09 03:04:54 +01:00

tzarebczan commented

2020-01-09 03:51:26 +01:00

(Migrated from github.com)

Thanks for the PR @dalhill ! Can you squash your commits? We'll get a review on this soon..

After that, can we show you some appreciation?

Thanks for the PR @dalhill ! Can you squash your commits? We'll get a review on this soon.. After that, can we show you some [appreciation](https://LBRY.com/faq/appreciation)?

dalhill commented

2020-01-09 06:40:35 +01:00

(Migrated from github.com)

@tzarebczan I squashed the 3 most recent commits. I should have been more mindful of the commits. If you want the commits further squashed let me know and I'll see what I can do.

kauffj commented

2020-01-09 20:07:44 +01:00

(Migrated from github.com)

@seanyesmunt this code looks fine but there is a big UX question around when users will expect the publish to clear.

@dalhill part of the idea of this behavior was that you should be able to start a publish, navigate elsewhere, and then return.

Two alternate ideas:

Track the last time publish state changed and do not auto clear if it was updated recently
Show a more prominent reset/clear option when resuming

@seanyesmunt this code looks fine but there is a big UX question around when users will expect the publish to clear. @dalhill part of the idea of this behavior was that you should be able to start a publish, navigate elsewhere, and then return. Two alternate ideas: - Track the last time publish state changed and do not auto clear if it was updated recently - Show a more prominent reset/clear option when resuming

kauffj commented

2020-01-09 20:08:30 +01:00

(Migrated from github.com)

@dalhill Sean is off work for the rest of this week so we may have to pick this up next week

dalhill commented

2020-01-10 03:18:02 +01:00

(Migrated from github.com)

@kauffj That makes sense. Out of the two options I like "Show a more prominent reset/clear option when resuming". I think that having a timer may give users the impression of an inconsistent app. Thanks for the response and I'll wait for @seanyesmunt to return.

neb-b commented

2020-01-13 16:47:13 +01:00

(Migrated from github.com)

One option is to change the menu dropdown to just say Publish, and then reset the publish state for every button that specifically says New Publish

One option is to change the menu dropdown to just say `Publish`, and then reset the publish state for every button that specifically says `New Publish`

tzarebczan commented

2020-01-13 18:21:23 +01:00

(Migrated from github.com)

Thanks for the PR @dalhill ! Once this is reviewed/merged, can we show you some appreciaiton?

Thanks for the PR @dalhill ! Once this is reviewed/merged, can we show you some [appreciaiton](https://lbry.com/faq/appreciation)?

dalhill commented

2020-01-14 05:34:43 +01:00

(Migrated from github.com)

In response to feedback from @seanyesmunt

I changed the navbar dropdown to just say "Publish" and it continues to not clear the form.
The other two button/links will clear the form as they still say "new".

In response to feedback from @kauffj

I increased the font size of the cancel button at the top of the publish form. It's a fairy subtle change and may not be enough.

In response to feedback from @seanyesmunt 1. I changed the navbar dropdown to just say "Publish" and it continues to not clear the form. 2. The other two button/links will clear the form as they still say "new". In response to feedback from @kauffj 1. I increased the font size of the cancel button at the top of the publish form. It's a fairy subtle change and may not be enough.