Updated the broken link #4171

Merged

imanishbarnwal merged 2 commits from update-contributing into master

2020-05-11 15:30:31 +02:00

imanishbarnwal commented

2020-05-11 09:25:54 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #4166

What is the current behavior?

src/platforms/electron/index.js had the broken link.

What is the new behavior?

Now I had updated this src/platforms/electron/index.js with the live link.

Other information

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [x] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [x] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: [#4166](https://github.com/lbryio/lbry-desktop/issues/4166) ## What is the current behavior? [`src/platforms/electron/index.js`](https://github.com/lbryio/lbry-desktop/blob/master/src/platforms/electron/index.js) had the broken link. ## What is the new behavior? Now I had updated this [`src/platforms/electron/index.js`](https://github.com/lbryio/lbry-desktop/blob/master/electron/index.js) with the live link. ## Other information

harshkhandeparkar (Migrated from github.com) reviewed

2020-05-11 13:02:52 +02:00

harshkhandeparkar (Migrated from github.com) left a comment

Needs a few changes. Also, did you find any other mistakes?

CONTRIBUTING.md

harshkhandeparkar (Migrated from github.com) commented

2020-05-11 13:02:22 +02:00

You changed the link but did not change the text for the link.

imanishbarnwal commented

2020-05-11 13:09:24 +02:00

(Migrated from github.com)

Needs a few changes. Also, did you find any other mistakes?

I checked that very closely but didn't find any other issues like that. So I just change that.

> Needs a few changes. Also, did you find any other mistakes? I checked that very closely but didn't find any other issues like that. So I just change that.

👍 1

harshkhandeparkar (Migrated from github.com) approved these changes

2020-05-11 13:36:42 +02:00

harshkhandeparkar commented

2020-05-11 13:36:55 +02:00

(Migrated from github.com)

TY!