Allow double-clicking in header to maximize the app. #4208

Merged
jeffslofish merged 1 commit from issue-4207 into master 2020-05-25 21:00:36 +02:00
jeffslofish commented 2020-05-18 06:30:56 +02:00 (Migrated from github.com)

Closes #4207

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #4207

What is the current behavior?

Double clicking in the header of the app does nothing.

What is the new behavior?

Double clicking in the header of the app maximizes the app window.

Other information

Closes #4207 ## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #4207 ## What is the current behavior? Double clicking in the header of the app does nothing. ## What is the new behavior? Double clicking in the header of the app maximizes the app window. ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
neb-b (Migrated from github.com) reviewed 2020-05-18 06:30:56 +02:00
tzarebczan (Migrated from github.com) reviewed 2020-05-18 06:30:56 +02:00
jeffslofish commented 2020-05-18 06:50:53 +02:00 (Migrated from github.com)

I am only able to test this on a mac. Can someone else test this on linux/windows?

I am only able to test this on a mac. Can someone else test this on linux/windows?
neb-b commented 2020-05-18 22:58:57 +02:00 (Migrated from github.com)

Whoops. Didn't mean to close this. Confirmed works on a mac. @tzarebczan or @jessopb can you test on Linux?

Whoops. Didn't mean to close this. Confirmed works on a mac. @tzarebczan or @jessopb can you test on Linux?
jessopb (Migrated from github.com) approved these changes 2020-05-25 20:20:10 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#4208
No description provided.