LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Chromecast integration (experimental) #4252

Closed
mikadoplus wants to merge 0 commits from master into master
pull from: master
merge into: LBRYCommunity:master
Conversation 9 Commits - Files changed -
mikadoplus commented 2020-05-27 00:56:05 +02:00 (Migrated from github.com)
Copy link

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/508

What is the current behavior?

What is the new behavior?

Other information

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/508 ## What is the current behavior? ## What is the new behavior? ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
neb-b (Migrated from github.com) reviewed 2020-05-27 00:56:05 +02:00
neb-b commented 2020-05-27 21:29:16 +02:00 (Migrated from github.com)
Copy link

Awesome! I'll review/test this later today or tomorrow.

Awesome! I'll review/test this later today or tomorrow.
neb-b commented 2020-05-28 18:22:31 +02:00 (Migrated from github.com)
Copy link

This looks like a great start! I'm ok using your changes in your fork if they are absolutely needed.

If we do, I would rather you publish that to NPM.

Can you also make sure this doesn't cause the web build to fail? When I run yarn dev:web if fails with a couple errors.

This looks like a great start! I'm ok using your changes in your fork if they are absolutely needed. If we do, I would rather you publish that to NPM. Can you also make sure this doesn't cause the web build to fail? When I run `yarn dev:web` if fails with a couple errors.
neb-b commented 2020-05-28 19:33:47 +02:00 (Migrated from github.com)
Copy link

I'm seeing this when I try to cast to my TV. It also doesn't actually stop the video that is playing when I click the "cast" button. It's just stuck there

Screen Shot 2020-05-28 at 1 32 54 PM
I'm seeing this when I try to cast to my TV. It also doesn't actually stop the video that is playing when I click the "cast" button. It's just stuck there <img width="800" alt="Screen Shot 2020-05-28 at 1 32 54 PM" src="https://user-images.githubusercontent.com/16882830/83174043-c61e8580-a0e7-11ea-8fd1-86d10875f918.png">
mikadoplus commented 2020-05-29 17:56:00 +02:00 (Migrated from github.com)
Copy link

Hello @seanyesmunt, no big deal for the errors on yarn dev:web, I saw them, and should work, indeed they already work on my side, but somehow the packages weren't up to date when I created the PR.
For the other error, that is what I said on my first comment. The problem here is that videos are played on a localhost URL with a specific port. So I assume Chromecast doesn't see it since it is playing on your mac or pc. I've tried with the web version "CDN Urls" and they worked. The main video stops and it's casted.

I'll investigate on this a bit further by tonight or tomorrow.

I think also that the error handling could be more intuitive for the user.

I see also on your screen some weird design glitches, I do not have, will investigate on that too.

Hello @seanyesmunt, no big deal for the errors on yarn dev:web, I saw them, and should work, indeed they already work on my side, but somehow the packages weren't up to date when I created the PR. For the other error, that is what I said on my first comment. The problem here is that videos are played on a localhost URL with a specific port. So I assume Chromecast doesn't see it since it is playing on your mac or pc. I've tried with the web version "CDN Urls" and they worked. The main video stops and it's casted. I'll investigate on this a bit further by tonight or tomorrow. I think also that the error handling could be more intuitive for the user. I see also on your screen some weird design glitches, I do not have, will investigate on that too.
neb-b commented 2020-05-29 22:42:43 +02:00 (Migrated from github.com)
Copy link

@mikadoplus Ah that makes sense. I'll try not on localhost!

@mikadoplus Ah that makes sense. I'll try not on localhost!
mikadoplus commented 2020-06-01 12:17:31 +02:00 (Migrated from github.com)
Copy link

Hi @seanyesmunt I've update the my last commit, the errors executing warn dev:web. Are now corrected. I've also improved the performance and user experience a bit. Let me know what do you think about this one.

Were you able to play non localhost videos ?

Hi @seanyesmunt I've update the my last commit, the errors executing warn dev:web. Are now corrected. I've also improved the performance and user experience a bit. Let me know what do you think about this one. Were you able to play non localhost videos ?
neb-b commented 2020-06-01 16:36:29 +02:00 (Migrated from github.com)
Copy link

I haven't tested that yet. Will do today. Can you rebase this PR so it doesn't include all of the extra commits?

I haven't tested that yet. Will do today. Can you rebase this PR so it doesn't include all of the extra commits?
mikadoplus commented 2020-06-01 18:09:27 +02:00 (Migrated from github.com)
Copy link

Hi @seanyesmunt I just noticed I messed up this PR, didn't notice I've forced a push out here. Sorry about that. I should have created a new branch instead of continue commiting to the master one. I've pushed a new commit, but don't want to recreate a new PR if there is an other way to roll back this one. Maybe I'm not enough familiar with git but what would be the best way to do it ?

Hi @seanyesmunt I just noticed I messed up this PR, didn't notice I've forced a push out here. Sorry about that. I should have created a new branch instead of continue commiting to the master one. I've pushed a new commit, but don't want to recreate a new PR if there is an other way to roll back this one. Maybe I'm not enough familiar with git but what would be the best way to do it ?

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#4252
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?