LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Open in desktop #6667

Closed
btzr-io wants to merge 13 commits from protocol into master
pull from: protocol
merge into: LBRYCommunity:master
Conversation 16 Commits 13 Files changed 6 +55 -7
btzr-io commented 2021-07-23 07:09:57 +02:00 (Migrated from github.com)
Copy link

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #6703, #6659
Changelog update: #6735

Web -> Desktop

image

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I added a line describing my change to CHANGELOG.md - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #6703, #6659 Changelog update: #6735 # Web -> Desktop ![image](https://user-images.githubusercontent.com/14793624/126739529-6782f1bd-1adc-44b9-afae-1c2d4a852cb4.png)
kauffj commented 2021-07-26 17:09:57 +02:00 (Migrated from github.com)
Copy link

I like the intent of this but we're trying to keep Odysee and LBRY Desktop strongly separated. Please discuss with me over chat.

I like the intent of this but we're trying to keep Odysee and LBRY Desktop strongly separated. Please discuss with me over chat.
👍 1
kauffj commented 2021-07-26 17:11:09 +02:00 (Migrated from github.com)
Copy link

Odysee apps can know about Odysee other apps. LBRY cannot know about Odysee. Odysee can know about LBRY URLs, so this may be a way to facilitate Odysee -> LBRY.

Odysee apps can know about Odysee other apps. LBRY cannot know about Odysee. Odysee can know about LBRY URLs, so this may be a way to facilitate Odysee -> LBRY.
👍 1
btzr-io commented 2021-07-26 19:33:52 +02:00 (Migrated from github.com)
Copy link

Odysee apps can know about Odysee other apps. LBRY cannot know about Odysee. Odysee can know about LBRY URLs, so this may be a way to facilitate Odysee -> LBRY.

I'll remove the 'Open in web' button.

> Odysee apps can know about Odysee other apps. LBRY cannot know about Odysee. Odysee can know about LBRY URLs, so this may be a way to facilitate Odysee -> LBRY. I'll remove the 'Open in web' button.
btzr-io commented 2021-07-26 20:10:36 +02:00 (Migrated from github.com)
Copy link

@kauffj When I open an external 'lbry://' link on the browser, the desktop app doesn't resolve it. This PR also fixes that bug.

@kauffj When I open an external 'lbry://' link on the browser, the desktop app doesn't resolve it. This PR also fixes that bug.
btzr-io commented 2021-07-29 22:54:14 +02:00 (Migrated from github.com)
Copy link

Changelog update: #6735

Changelog update: #6735
btzr-io commented 2021-08-02 22:22:40 +02:00 (Migrated from github.com)
Copy link

Can someone test or review this ?

Can someone test or review this ?
roylee17 commented 2021-08-02 22:37:32 +02:00 (Migrated from github.com)
Copy link

Can someone test or review this ?

Thanks for your contribution.
I'd recommend @jessopb for reviewing.

> Can someone test or review this ? Thanks for your contribution. I'd recommend @jessopb for reviewing.
👍 1
kauffj (Migrated from github.com) reviewed 2021-08-04 00:09:59 +02:00
kauffj (Migrated from github.com) left a comment
Copy link

The code looks fine but I still have concerns about introducing this element on Odysee, where many users will not have LBRY Desktop.

What's the UX like when the user does not have the desktop app installed? Is there a way we can explain to those users what this feature does?

The code looks fine but I still have concerns about introducing this element on Odysee, where many users will not have LBRY Desktop. What's the UX like when the user does not have the desktop app installed? Is there a way we can explain to those users what this feature does?
btzr-io commented 2021-08-04 00:23:02 +02:00 (Migrated from github.com)
Copy link

What's the UX like when the user does not have the desktop app installed?

I think is ignored if there is no protocol handler registered.

> What's the UX like when the user does not have the desktop app installed? I think is ignored if there is no protocol handler registered.
btzr-io commented 2021-08-04 00:25:34 +02:00 (Migrated from github.com)
Copy link

What's the UX like when the user does not have the desktop app installed?

Here are some initial ideas:

  • Show a modal to inform the user about the desktop app
  • Open a link ( on a new tab ) directly to the lbry website: https://lbry.com/get
> What's the UX like when the user does not have the desktop app installed? Here are some initial ideas: - Show a modal to inform the user about the desktop app - Open a link ( on a new tab ) directly to the lbry website: https://lbry.com/get
btzr-io commented 2021-08-04 00:27:40 +02:00 (Migrated from github.com)
Copy link

A similar approach to spotify "Open in desktop" feature will be:

  1. Try to open custom protocol link
  2. Wait a few seconds then redirect to https://lbry.com/get

It will probably require a custom route or param for open.lbry.com:

https://open.lbry.com/desktop/{LBRY_URI}
https://open.lbry.com/{LBRY_URI}?desktop=true

A similar approach to spotify "Open in desktop" feature will be: 1) Try to open custom protocol link 2) Wait a few seconds then redirect to https://lbry.com/get It will probably require a custom route or param for `open.lbry.com`: > https://open.lbry.com/desktop/{LBRY_URI} > https://open.lbry.com/{LBRY_URI}?desktop=true
btzr-io commented 2021-08-04 04:06:15 +02:00 (Migrated from github.com)
Copy link

This requires more additional work, I removed all the UI changes #6779

This requires more additional work, I removed all the UI changes #6779
Snake883 commented 2021-08-07 19:06:02 +02:00 (Migrated from github.com)
Copy link

This half way works. I'll explain...

I want the LBRY Desktop app to accept a parameter for a link, and go to the link.

Functionality

Function 1: Protocol ("LBRY://")

In Windows Run, I want the associated program to open the link:
image

Function 2: LBRY.exe Parameter ("c:\program files\LBRY\LBRY.exe %1")

image

Functional Test 1

LBRY Desktop running.

Test 1A

Failed test.
In both functions, LBRY Desktop receives focus. But, LBRY Desktop does not go to the link.

Test 1B

In both functions, LBRY Desktop receives focus. But, LBRY Desktop does not go to the link.

Functional Test 2

LBRY Desktop not running.

Test 2A

Passed test.
In both functions, LBRY Desktop receives focus and LBRY Desktop goes to the link.

Test 2B

Passed test.
In both functions, LBRY Desktop receives focus and LBRY Desktop goes to the link.

This half way works. I'll explain... I want the LBRY Desktop app to accept a parameter for a link, and go to the link. # Functionality ## Function 1: Protocol ("LBRY://") In Windows Run, I want the associated program to open the link: ![image](https://user-images.githubusercontent.com/8312560/128607664-d4ae1415-8147-4ae1-a3ff-f8bff3ca95b7.png) ## Function 2: LBRY.exe Parameter ("c:\program files\LBRY\LBRY.exe %1") ![image](https://user-images.githubusercontent.com/8312560/128607777-f7d901d6-b215-4d4f-82ce-b45b9272d9c6.png) # Functional Test 1 LBRY Desktop running. ## Test 1A Failed test. In both functions, LBRY Desktop receives focus. But, LBRY Desktop does not go to the link. ## Test 1B In both functions, LBRY Desktop receives focus. But, LBRY Desktop does not go to the link. # Functional Test 2 LBRY Desktop not running. ## Test 2A Passed test. In both functions, LBRY Desktop receives focus and LBRY Desktop goes to the link. ## Test 2B Passed test. In both functions, LBRY Desktop receives focus and LBRY Desktop goes to the link.
btzr-io commented 2021-08-07 20:30:32 +02:00 (Migrated from github.com)
Copy link

@snakyjake1 Did you try https://github.com/lbryio/lbry-desktop/releases/tag/untagged-aa3ae8f9162b42aace2a ?

@snakyjake1 Did you try https://github.com/lbryio/lbry-desktop/releases/tag/untagged-aa3ae8f9162b42aace2a ?
Snake883 commented 2021-08-09 08:09:13 +02:00 (Migrated from github.com)
Copy link

Did you try https://github.com/lbryio/lbry-desktop/releases/tag/untagged-aa3ae8f9162b42aace2a ?

@btzr-io I couldn't get your link to work.

> Did you try https://github.com/lbryio/lbry-desktop/releases/tag/untagged-aa3ae8f9162b42aace2a ? @btzr-io I couldn't get your link to work.
btzr-io commented 2021-08-09 08:30:50 +02:00 (Migrated from github.com)
Copy link

@snakyjake1 Whats your current desktop version ? Where Test 1A, Test 1B run using v0.51.0-rc.2 ?

@snakyjake1 Whats your current desktop version ? Where Test 1A, Test 1B run using v0.51.0-rc.2 ?
Snake883 commented 2021-08-09 18:12:04 +02:00 (Migrated from github.com)
Copy link

Whats your current desktop version?

Both tests on v0.51.1.
image

> Whats your current desktop version? Both tests on v0.51.1. ![image](https://user-images.githubusercontent.com/8312560/128738206-6f97df72-cca9-4c51-9c9d-e79521236a4a.png)

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#6667
No description provided.
Delete branch "protocol"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?