LBRYCommunity/lbry-desktop

Fork

You've already forked lbry-desktop

Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Automatically claim initial rewards (new_user & email_verified) when … #6807

Merged

Ruk33 merged 2 commits from 6788-automatically-claim-initial-rewards into master

2021-08-18 18:34:25 +02:00

Conversation 3 Commits 2 Files changed 6 +110 -42

Ruk33 commented

2021-08-06 20:40:29 +02:00

(Migrated from github.com)

Copy link

…accessing creating channel, edit channel and upload

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I added a line describing my change to CHANGELOG.md
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/6788

What is the current behavior?

N/A

What is the new behavior?

When a user access to create new channel, edit channel, or upload, we will try to automatically claim the rewards email_verified & new_user.

Other information

…accessing creating channel, edit channel and upload ## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I added a line describing my change to CHANGELOG.md - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/6788 ## What is the current behavior? N/A ## What is the new behavior? When a user access to create new channel, edit channel, or upload, we will try to automatically claim the rewards email_verified & new_user. ## Other information

tzarebczan commented

2021-08-11 22:27:11 +02:00

(Migrated from github.com)

Copy link

Thanks again @Ruk33 ! We'll get a code review on this soon, but looks right according to our conversation.

infinite-persistence (Migrated from github.com) reviewed 2021-08-12 05:14:00 +02:00

ui/component/channelEdit/view.jsx

infinite-persistence (Migrated from github.com) commented

2021-08-12 05:13:51 +02:00

Copy link

Room for optimization to not call this every time?

This will get called on every entry. Tom did mention something similar:

Do this when the balance is less than 1 LBC or something.

@tzarebczan, if there's no harm to the unnecessary API call, I guess we can just merge it.

Room for optimization to not call this every time? This will get called on every entry. Tom did mention something similar: > _Do this when the balance is less than 1 LBC or something._ @tzarebczan, if there's no harm to the unnecessary API call, I guess we can just merge it. <img src="https://user-images.githubusercontent.com/64950861/129132705-54006255-e2ef-4687-90ea-72e3bcfe1a5c.png" width="300">

infinite-persistence (Migrated from github.com) reviewed 2021-08-12 05:17:11 +02:00

ui/component/channelEdit/view.jsx

infinite-persistence (Migrated from github.com) commented

2021-08-12 05:17:11 +02:00

Copy link

Maybe check selectUnclaimedRewards first before sending the request?

Maybe check `selectUnclaimedRewards` first before sending the request?

tzarebczan (Migrated from github.com) reviewed 2021-08-13 22:40:50 +02:00

ui/component/channelEdit/view.jsx

tzarebczan (Migrated from github.com) commented

2021-08-13 22:40:50 +02:00

Copy link

Yea, I thought that was happening..it's probably not a big deal. That's why import { selectUnclaimedRewardValue, selectIsClaimingInitialRewards } from 'redux/selectors/rewards'; was brought in on publish page, but it's never used. @Ruk33 take another look please?

Yea, I thought that was happening..it's probably not a big deal. That's why ```import { selectUnclaimedRewardValue, selectIsClaimingInitialRewards } from 'redux/selectors/rewards';``` was brought in on publish page, but it's never used. @Ruk33 take another look please?

kauffj commented

2021-08-16 17:04:10 +02:00

(Migrated from github.com)

Copy link

@Ruk33 I think ball is in your court on this one

Ruk33 (Migrated from github.com) reviewed 2021-08-17 02:29:51 +02:00

ui/component/channelEdit/view.jsx

Ruk33 (Migrated from github.com) commented

2021-08-17 02:29:51 +02:00

Copy link

Hello guys, thanks for the review. Not sure how much performance can we gain since when we call doClaimInitialRewards, internally, it calls doClaimRewardType which do checks for already claimed rewards and if it's claimed already, it does nothing. In any case, will update to first make the checks and then call only if required.

Hello guys, thanks for the review. Not sure how much performance can we gain since when we call `doClaimInitialRewards`, internally, it calls `doClaimRewardType` which do checks for already claimed rewards and if it's claimed already, it does nothing. In any case, will update to first make the checks and then call only if required.

Ruk33 commented

2021-08-17 02:34:50 +02:00

(Migrated from github.com)

Copy link

Hello @kauffj , thanks for the follow-up. On it!

infinite-persistence (Migrated from github.com) reviewed 2021-08-17 09:14:22 +02:00

ui/component/channelEdit/view.jsx

infinite-persistence (Migrated from github.com) commented

2021-08-17 09:14:22 +02:00

Copy link

Bug: email verified without user consent

I see what you mean and it is indeed redundant. On closer inspection, I think the issue is this:

I don't have rewards approved, but the network call was sent regardless.
I got the 0.2 LBC for Email Verified despite not having rewards approved (I really didn't want to verify this email, to keep it for testing scenario purposes.).
Subsequent visits to "edit" or "publish" results in the screenshot above (repeated network calls).

#### Bug: email verified without user consent I see what you mean and it is indeed redundant. On closer inspection, I think the issue is this: - I don't have rewards approved, but the network call was sent regardless. - [ ] I got the 0.2 LBC for `Email Verified` despite not having rewards approved (I really didn't want to verify this email, to keep it for testing scenario purposes.). - [ ] Subsequent visits to "edit" or "publish" results in the screenshot above (repeated network calls).

Reviewers

No reviewers

Labels

Clear labels

Work is part of a proposal

Beamer is waiting on you!

Discuss this issue at the next planning meeting, then remove this label

Welcome to Hacktoberfest

No knowledge of the existing code required

level: 2

Some knowledge of the existing code is recommended

level: 3

Significant knowledge of the existing code is recommended

level: 4

Intimate knowledge of the existing code is recommended

merge when green

needs: exploration

Solution unclear, needs research

needs: grooming

Issue needs to be groomed before work can start

needs: priority

Priority level needs to be defined

needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

needs: tech design

Needs technical design signoff before implementation can begin

Issue is blocking release, do ASAP

priority: high

Work needs to be moved into sprint ASAP

priority: low

Work should be done but can stay in the backlog for now

priority: medium

Work needs to be done within 2-3 sprints

protocol dependent

recsys

redesign

general redesign not prioritize for anyone release

regression

resilience

sdk dependent

Requires work on lbry-sdk repo

Tom's Wishlist

trending

type: bug

Existing functionality is wrong or broken

type: discussion

A conversation. No specific changes requested

type: improvement

Existing (or partially existing) functionality needs to be changed

type: new feature

New functionality that does not exist yet

type: refactor

Minimal user-visible changes, but significant internal work

type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

type: testing

Solution needs additional user testing

unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#6807

Reference in a new issue

Repository

LBRYCommunity/lbry-desktop

Title

Body

No description provided.

Delete branch "6788-automatically-claim-initial-rewards"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?