Stripe move transactions to wallet #6861

Closed
mayeaux wants to merge 54 commits from stripe-move-transactions-to-wallet into master
mayeaux commented 2021-08-11 15:05:32 +02:00 (Migrated from github.com)

Moves Stripe transactions to wallet

Moves Stripe transactions to wallet
jessopb (Migrated from github.com) reviewed 2021-08-12 15:37:00 +02:00
jessopb (Migrated from github.com) left a comment

some comments

some comments
jessopb (Migrated from github.com) commented 2021-08-11 23:53:05 +02:00

fetchAccountStatus()

fetchAccountStatus()
@ -0,0 +12,4 @@
const WalletBalance = (props: Props) => {
// receive transactions from parent component
let accountTransactions = props.transactions;
jessopb (Migrated from github.com) commented 2021-08-11 23:51:58 +02:00

we're prefering destructure to dot. used to be a lint rule - maybe still is.
const { accountTransactions } = props;

we're prefering destructure to dot. used to be a lint rule - maybe still is. const { accountTransactions } = props;
jessopb (Migrated from github.com) commented 2021-08-11 23:52:50 +02:00

orderedTransactions = accountTransactions ? accountTransactions.reverse() : [];

orderedTransactions = accountTransactions ? accountTransactions.reverse() : [];
@ -0,0 +5,4 @@
import { Lbryio } from 'lbryinc';
import moment from 'moment';
type Props = {
jessopb (Migrated from github.com) commented 2021-08-11 23:39:05 +02:00

this should mostly match the select in the index.js

this should mostly match the select in the index.js
jessopb (Migrated from github.com) commented 2021-08-11 23:49:52 +02:00

we use 'fetch' for this meaning as it denotes an async fetch. get we sometimes use for synchronous transformations.

we use 'fetch' for this meaning as it denotes an async fetch. get we sometimes use for synchronous transformations.
jessopb (Migrated from github.com) commented 2021-08-11 23:50:03 +02:00
No description provided.
<Tabs>

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#6861
No description provided.