Add play button on pause ios #6975

Closed

mayeaux wants to merge 4 commits from add-play-button-on-pause-ios into master

mayeaux commented

2021-08-27 17:57:12 +02:00

(Migrated from github.com)

Adds a play button when content is paused on iOS. Useful because the current play button is very small and in an annoying place for righthanded users, and because iOS Safari is requiring a manual play intervention on each video upload.

infinite-persistence commented

2021-08-27 18:24:59 +02:00

(Migrated from github.com)

We are currently using videojs-mobile-ui for Android for the mobile style. It was disabled for IOS back then due to something (I forgot what) which I think was recently fixed.

Update: I recall a bit now ... I think it was "use native on iOS for some reason", but we recently switched to just use the regular videojs version on iOS, so at that point we can use videojs-mobile-us again.

The plugin was never tested on IOS, but if it works, maybe we should just use common code rather than introduce new one for IOS? It'll provide other functionality like "tap-to-seek-5s"

const mobileUi = function(options) {
  // if (videojs.browser.IS_ANDROID || videojs.browser.IS_IOS) {
  if (videojs.browser.IS_ANDROID) {
    this.ready(() => {
      onPlayerReady(this, videojs.mergeOptions(defaults, options));
    });
  }
};

We are currently using `videojs-mobile-ui` for Android for the mobile style. It was disabled for IOS back then due to something (I forgot what) which I think was recently fixed. - Update: I recall a bit now ... I think it was "use native on iOS for some reason", but we recently switched to just use the regular videojs version on iOS, so at that point we can use `videojs-mobile-us` again. The plugin was never tested on IOS, but if it works, maybe we should just use common code rather than introduce new one for IOS? It'll provide other functionality like "tap-to-seek-5s" ``` const mobileUi = function(options) { // if (videojs.browser.IS_ANDROID || videojs.browser.IS_IOS) { if (videojs.browser.IS_ANDROID) { this.ready(() => { onPlayerReady(this, videojs.mergeOptions(defaults, options)); }); } }; ```

👍 2

jessopb (Migrated from github.com) approved these changes 2021-08-29 18:20:16 +02:00

jessopb (Migrated from github.com) approved these changes 2021-08-29 18:41:48 +02:00

jessopb (Migrated from github.com) left a comment

This may be a sideways change if @infinite-persistence is right. Explore it?

mayeaux commented

2021-08-30 15:29:12 +02:00

(Migrated from github.com)

We are currently using videojs-mobile-ui for Android for the mobile style. It was disabled for IOS back then due to something (I forgot what) which I think was recently fixed.

Update: I recall a bit now ... I think it was "use native on iOS for some reason", but we recently switched to just use the regular videojs version on iOS, so at that point we can use videojs-mobile-us again.

The plugin was never tested on IOS, but if it works, maybe we should just use common code rather than introduce new one for IOS? It'll provide other functionality like "tap-to-seek-5s"
const mobileUi = function(options) {
  // if (videojs.browser.IS_ANDROID || videojs.browser.IS_IOS) {
  if (videojs.browser.IS_ANDROID) {
    this.ready(() => {
      onPlayerReady(this, videojs.mergeOptions(defaults, options));
    });
  }
};

Thanks for the info I will try that out right now!

> We are currently using `videojs-mobile-ui` for Android for the mobile style. It was disabled for IOS back then due to something (I forgot what) which I think was recently fixed. > > * Update: I recall a bit now ... I think it was "use native on iOS for some reason", but we recently switched to just use the regular videojs version on iOS, so at that point we can use `videojs-mobile-us` again. > > The plugin was never tested on IOS, but if it works, maybe we should just use common code rather than introduce new one for IOS? It'll provide other functionality like "tap-to-seek-5s" > > ``` > const mobileUi = function(options) { > // if (videojs.browser.IS_ANDROID || videojs.browser.IS_IOS) { > if (videojs.browser.IS_ANDROID) { > this.ready(() => { > onPlayerReady(this, videojs.mergeOptions(defaults, options)); > }); > } > }; > ``` Thanks for the info I will try that out right now!

👍 1