Changes to improve videojs playing experience on iOS #7058

Closed
mayeaux wants to merge 2 commits from fix-videojs-ios into master
mayeaux commented 2021-09-10 17:59:53 +02:00 (Migrated from github.com)

Re-enables mobile-ui for videojs on iOS and plays videos by default as muted with the 'Tap to unmute' button

Re-enables mobile-ui for videojs on iOS and plays videos by default as muted with the 'Tap to unmute' button
infinite-persistence (Migrated from github.com) requested changes 2021-09-30 04:00:53 +02:00
@ -155,2 +154,3 @@
if (videojs.browser.IS_ANDROID) {
// target both iOS and Android
if (videojs.browser.IS_ANDROID || videojs.browser.IS_IOS) {
this.ready(() => {
infinite-persistence (Migrated from github.com) commented 2021-09-30 03:56:04 +02:00

This comment feels redundant, since the variables are self-explanatory.

This comment feels redundant, since the variables are self-explanatory.
@ -290,3 +289,4 @@
// }
};
const player = playerRef.current;
infinite-persistence (Migrated from github.com) commented 2021-09-30 03:56:32 +02:00

Why was this removed? It disables i18n.

Why was this removed? It disables i18n.
@ -338,0 +356,4 @@
}
setTimeout(function(){
console.log('running here124')
const isPaused = player.paused();
infinite-persistence (Migrated from github.com) commented 2021-09-30 03:57:27 +02:00

Lint

Lint
infinite-persistence (Migrated from github.com) requested changes 2021-09-30 04:09:12 +02:00
infinite-persistence (Migrated from github.com) commented 2021-09-30 04:09:01 +02:00
  • Is there an alternative to a hardcoded timeout?
  • If it's really needed, do the IS_IOS check first (instead of checking inside the timeout), so that it only runs for IOS.
- Is there an alternative to a hardcoded timeout? - If it's really needed, do the `IS_IOS` check first (instead of checking inside the timeout), so that it only runs for IOS.

Pull request closed

Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#7058
No description provided.