Stream Key Button #7127

Merged
GlobalGamer2015 merged 12 commits from master into master 2021-09-23 08:17:59 +02:00
4 changed files with 104 additions and 2 deletions

View file

@ -22,6 +22,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Clicking on the title of a floating player will take you back to the list ([#6921](https://github.com/lbryio/lbry-desktop/pull/6921))
- Fix floating player stopping on markdown or image files ([#7073](https://github.com/lbryio/lbry-desktop/pull/7073))
- Fix list thumbnail upload ([#7074](https://github.com/lbryio/lbry-desktop/pull/7074))
- Stream Key is now hidden. ([#7127](https://github.com/lbryio/lbry-desktop/pull/7127))
## [0.51.2] - [2021-08-20]
@ -1955,4 +1956,4 @@ This release includes a breaking change that will reset many of your settings. T
- Use local file for publishing
- Use local file and html5 for video playback
- Misc changes needed to make UI compatible with electron.
- Misc changes needed to make UI compatible with electron.

View file

@ -0,0 +1,7 @@
infinite-persistence commented 2021-09-22 07:09:43 +02:00 (Migrated from github.com)
Review

Rename to CopyableStreamkey

Rename to `CopyableStreamkey`
GlobalGamer2015 commented 2021-09-23 04:46:34 +02:00 (Migrated from github.com)
Review

Renamed

Renamed
infinite-persistence commented 2021-09-22 07:09:43 +02:00 (Migrated from github.com)
Review

Rename to CopyableStreamkey

Rename to `CopyableStreamkey`
GlobalGamer2015 commented 2021-09-23 04:46:34 +02:00 (Migrated from github.com)
Review

Renamed

Renamed
import { connect } from 'react-redux';
infinite-persistence commented 2021-09-22 07:09:43 +02:00 (Migrated from github.com)
Review

Rename to CopyableStreamkey

Rename to `CopyableStreamkey`
GlobalGamer2015 commented 2021-09-23 04:46:34 +02:00 (Migrated from github.com)
Review

Renamed

Renamed
import { doToast } from 'redux/actions/notifications';
infinite-persistence commented 2021-09-22 07:09:43 +02:00 (Migrated from github.com)
Review

Rename to CopyableStreamkey

Rename to `CopyableStreamkey`
GlobalGamer2015 commented 2021-09-23 04:46:34 +02:00 (Migrated from github.com)
Review

Renamed

Renamed
import CopyableStreamkey from './view';
infinite-persistence commented 2021-09-22 07:09:43 +02:00 (Migrated from github.com)
Review

Rename to CopyableStreamkey

Rename to `CopyableStreamkey`
GlobalGamer2015 commented 2021-09-23 04:46:34 +02:00 (Migrated from github.com)
Review

Renamed

Renamed
infinite-persistence commented 2021-09-22 07:09:43 +02:00 (Migrated from github.com)
Review

Rename to CopyableStreamkey

Rename to `CopyableStreamkey`
GlobalGamer2015 commented 2021-09-23 04:46:34 +02:00 (Migrated from github.com)
Review

Renamed

Renamed
export default connect(null, {
infinite-persistence commented 2021-09-22 07:09:43 +02:00 (Migrated from github.com)
Review

Rename to CopyableStreamkey

Rename to `CopyableStreamkey`
GlobalGamer2015 commented 2021-09-23 04:46:34 +02:00 (Migrated from github.com)
Review

Renamed

Renamed
doToast,
infinite-persistence commented 2021-09-22 07:09:43 +02:00 (Migrated from github.com)
Review

Rename to CopyableStreamkey

Rename to `CopyableStreamkey`
GlobalGamer2015 commented 2021-09-23 04:46:34 +02:00 (Migrated from github.com)
Review

Renamed

Renamed
})(CopyableStreamkey);
infinite-persistence commented 2021-09-22 07:09:43 +02:00 (Migrated from github.com)
Review

Rename to CopyableStreamkey

Rename to `CopyableStreamkey`
GlobalGamer2015 commented 2021-09-23 04:46:34 +02:00 (Migrated from github.com)
Review

Renamed

Renamed

View file

@ -0,0 +1,93 @@
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
// @flow
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
import * as ICONS from 'constants/icons';
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
import { FormField } from 'component/common/form';
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
import Button from 'component/button';
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
import React, { useRef, Fragment } from 'react';
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
type Props = {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
copyable: string,
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
snackMessage: ?string,
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
doToast: ({ message: string }) => void,
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
primaryButton?: boolean,
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
name?: string,
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
onCopy?: (string) => string,
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
enableMask?: boolean,
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
};
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
export default function CopyableStreamkey(props: Props) {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
const { copyable, doToast, snackMessage, primaryButton = false, name, onCopy, enableMask = true } = props;
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
const input = useRef();
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
function copyToClipboard() {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
const topRef = input.current;
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
if (topRef[1].type === 'password') {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
navigator.clipboard.writeText(topRef[1].defaultValue);
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
if (topRef[1].type === 'text') {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
topRef[1].select();
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
if (onCopy) {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
onCopy(topRef[1]);
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
document.execCommand('copy');
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
function checkMaskType() {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
if (enableMask === true) {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
return 'password';
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
if (enableMask === false) {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
return 'text';
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
function showStreamkeyFunc() {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
const topRef = input.current;
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
if (topRef[1].type === 'password') {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
topRef[1].type = 'text';
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
topRef[0].innerText = 'Hide';
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
return;
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
if (topRef[1].type === 'text') {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
topRef[1].type = 'password';
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
topRef[0].innerText = 'Show';
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
return (
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
<Fragment>
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
<form ref={input}>
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
<div>
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
<label name="livestream-key">Stream key</label>{' '}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
<Button
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
className="button--link"
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
label={__('Show')}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
onClick={() => {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
showStreamkeyFunc();
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
/>
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
</div>
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
<FormField
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
type={checkMaskType()}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
className="form-field--copyable-streamkey"
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
readOnly
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
name={name}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
value={copyable || ''}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
inputButton={
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
<Button
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
button={primaryButton ? 'primary' : 'secondary'}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
icon={ICONS.COPY}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
onClick={() => {
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
copyToClipboard();
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
doToast({
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
message: snackMessage || __('Text copied'),
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
});
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
/>
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
/>
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
</form>
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
</Fragment>
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
);
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!
}
infinite-persistence commented 2021-09-21 08:30:44 +02:00 (Migrated from github.com)
Review

Rename to actual function name for clarity

Rename to actual function name for clarity
infinite-persistence commented 2021-09-23 07:10:07 +02:00 (Migrated from github.com)
Review

Issues:

  • The "Show" button didn't work for me.
  • This is still not the React-way -- normally, we don't directly tweak the DOM.
  • The use of <form> is weird, as we are not submitting anything.

Take a look at how to use useState.

A rough guide:

  • We probably don't need <form> and type=password
    • Without password, you don't have to change the way you perform the copy anymore.
  • Create a state, e.g. showKey
  • Replace copyable with asterix if state is hidden
    • e.g. value={showKey ? copyable || '' : '***')
      • Can make the asterix the same length if you want.
Issues: - The "Show" button didn't work for me. - This is still not the React-way -- normally, we don't directly tweak the DOM. - The use of `<form>` is weird, as we are not submitting anything. Take a look at how to use `useState`. A rough guide: - We probably don't need `<form>` and `type=password` - Without `password`, you don't have to change the way you perform the copy anymore. - Create a state, e.g. `showKey` - Replace `copyable` with asterix if state is hidden - e.g. `value={showKey ? copyable || '' : '***')` - Can make the asterix the same length if you want.
GlobalGamer2015 commented 2021-09-23 07:45:51 +02:00 (Migrated from github.com)
Review

Button is fixed.
I'm not using Dom, I'm using what was already in the file itself.
The <form> is being used to hold the main reference instead of a single FormField item.

Button is fixed. I'm not using Dom, I'm using what was already in the file itself. The `<form>` is being used to hold the main reference instead of a single FormField item.
infinite-persistence commented 2021-09-23 08:17:38 +02:00 (Migrated from github.com)
Review
  • The ref was originally used to highlight the text (i.e. .select()) when being copied, which we couldn't do via React.
  • By default, we don't alter text directly that way. Use states.
  • <form> is not the right tag for that use-case. A <div> would probably do.

Merging

It works, and the changes are localized in 1 component, so good to go for now. Thanks!

- The ref was originally used to highlight the text (i.e. `.select()`) when being copied, which we couldn't do via React. - By default, we don't alter text directly that way. Use states. - `<form>` is not the right tag for that use-case. A `<div>` would probably do. ## Merging It works, and the changes are localized in 1 component, so good to go for now. Thanks!

View file

@ -13,6 +13,7 @@ import { Lbry } from 'lbry-redux';
import { toHex } from 'util/hex';
import { FormField } from 'component/common/form';
import CopyableText from 'component/copyableText';
import CopyableStreamkey from 'component/copyableStreamkey';
import Card from 'component/common/card';
import ClaimList from 'component/claimList';
import usePersistedState from 'effects/use-persisted-state';
@ -186,7 +187,7 @@ export default function LivestreamSetupPage(props: Props) {
copyable={LIVESTREAM_RTMP_URL}
snackMessage={__('Copied')}
/>
<CopyableText
<CopyableStreamkey
primaryButton
name="livestream-key"
label={__('Stream key')}