LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Issue #721 fix - Inconsistent thumbnail sizes #744

Merged
akinwale merged 1 commit from issue721 into master 2017-11-15 22:57:48 +01:00
Conversation 0 Commits 1 Files changed 3 +10 -2
3 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CHANGELOG.md
View file

@ -16,7 +16,7 @@ Web UI version numbers should always match the corresponding version of LBRY App
*
### Fixed
*
* Long channel names causing inconsistent thumbnail sizes (#721)
*
### Deprecated

2
ui/js/component/uriIndicator/view.jsx
View file

@ -60,7 +60,7 @@ class UriIndicator extends React.PureComponent {
const inner = (
<span>
{channelName} {" "}
<span className="channel-name">{channelName}</span> {" "}
{!signatureIsValid
? <Icon
icon={icon}

8
ui/scss/component/_channel-indicator.scss
View file

@ -1,4 +1,12 @@
.channel-name {
width: calc(var(--card-small-width) * 2 / 3);
neb-b commented 2017-11-15 18:09:19 +01:00 (Migrated from github.com)
Review
Copy link

Is this needed? I think it should be fine with just the nowrap and ellipsis. If it's extending to the edge, we should add a padding to the card.

Is this needed? I think it should be fine with just the `nowrap` and `ellipsis`. If it's extending to the edge, we should add a padding to the card.
akinwale commented 2017-11-15 18:55:18 +01:00 (Migrated from github.com)
Review
Copy link

Without specifying the width, long text will push the price indicator to the next line. I suppose we could simplify this using a percentage width instead of the calculation. 60% or 70% should be fine.

Without specifying the width, long text will push the price indicator to the next line. I suppose we could simplify this using a percentage width instead of the calculation. 60% or 70% should be fine.
neb-b commented 2017-11-15 18:57:24 +01:00 (Migrated from github.com)
Review
Copy link

Gotcha. This should be fine for now, we will be moving to the new design sometime soon.

Gotcha. This should be fine for now, we will be moving to the new design sometime soon.
kauffj commented 2017-11-15 18:58:07 +01:00 (Migrated from github.com)
Review
Copy link

(Proper solution is probably a flex layout rather than calc, but not demanding propriety. Especially since we're likely to redesign soon anyway.)

(Proper solution is probably a flex layout rather than `calc`, but not demanding propriety. Especially since we're likely to redesign soon anyway.)
display: inline-block;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis
}
.channel-indicator__icon--invalid {
color: var(--color-error);
}