Prevent .deb packages from being opened with archive manager. #7502
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#7502
Loading…
Reference in a new issue
No description provided.
Delete branch "7495-deb-update-fails-to-launch-on-ubuntu"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes
Issue Number: https://github.com/lbryio/lbry-desktop/issues/7495
What is the current behavior?
With Ubuntu >= 20 .deb packages are opened with archive explorer.
What is the new behavior?
.deb
packages are properly installed and the app relaunches when the installation finishes.^ if there is an error (ie, incorrect password or permission wasn't granted), we let the user know.
When the installation finishes, the app will relaunch automatically.
Other information
How to test
From
/lbry-desktop/ui/redux/actions/app.js
, replace lines 218:224 with:And update line 213 with:
yarn build
deb
package from/lbry-desktop/dist/electron
lbry
PR Checklist
Toggle...
What kind of change does this PR introduce?
Please check all that apply to this PR using "x":
Good progress. I can still get into double downloads. Flow feels good otherwise.
Thank you @jessopb for the review. I have sent a fix for it.
I tested this on linux by
yarn build
this branch after changing the version in package.json to 0.52.4. Then installing that build from the .deb.Unfortunately, it's throwing an error looking for
app-update.yml
whenlbry
is launched from console and never shows the update available notifications. It does provide, in help page, the suggestion to download the lastest version which navigates the user to the download website.To confirm it was this branch, I built master locally in the same way, with version set to 0.52.4 as well, and the update notifications and nags were present in that case. And there were no console complaints about
app-update.yml
It doesn't look to me like something in this pr could change that, but it does ???
Hello @jessopb. I'm pretty sure the error you are facing isn't coming from this PR but for this: https://github.com/lbryio/lbry-desktop/pull/7492/files#diff-9e864f33e9f6d8e9a52d5df4de9861f47a3a45222f1f8fb620acd9c37193bb12R198
Notice how we previously, for
.deb
installations, we check for updates usingNative.getAppVersionInfo().then(success, fail);
but after the change, it always uses theipcRenderer.send('check-for-updates', ...)
call.To prevent having this error, you can create the following file
app-update.yml
in/opt/LBRY/resources
And re-open the app. With that, the error no longer shows up:
Hello, is there anything I need to update in this pr? Please let me know, happy to update if required. Thanks.
This may be the right track, but I'm not sure how this is a solution fit for production. The problem is not only the console error, but also the lack of update notification in the app, which did not happen before, if I recall correctly.
https://github.com/lbryio/lbry-desktop/pull/7502#issuecomment-1066832556
Perhaps the solution is this sort of file copy? https://www.electron.build/configuration/contents#extraresources
@jessopb I have sent an update for the missing
app-update.yml
. After reading, it seems like just adding it as a additional resource is the best option. Will keep testing tomorrow to make sure everything is ok.I'm seeing windows misreporting the title of the prerelease as a release, though it upgrades properly.
I'm seeing deb misreporting the release instead of prerelease in the "begin upgrade" modal
sudo... [release].deb
Also, closing the upgrade modal (reexposing the nag) and opening it again reinitiates the download.
I'm going to merge this anyways, but:
Couple small bugs for .deb -
Flood of these while downloading
And, after cancelling download and restarting, progress bar is back at 0 and titled "Downloading Update" (but not making progress). The modal is otherwise ready to upgrade.
Otherwise, the sudo-prompt worked very well.
There's also something strange that happened - I pushed a tag with 'alpha' in it which ended up on top of the list, but there were no builds associated with it (also, the tag erroneously was nested in
""
, so updates were failing. Probably some library code that just gets the last tag with a prerelease keyword in it. After I deleted the bad tag, it was fine.@ -67,6 +67,7 @@
"remove-markdown": "^0.3.0",
"rss": "^1.2.2",
"source-map-explorer": "^2.5.2",
"sudo-prompt": "^9.2.1",
This repository is archived on github. Something to keep an eye on, or fork for our selves.
@ -15,1 +20,4 @@
// LBRY_0.53.5-alpha.test7495b.deb
const fileName = 'LBRY_' + (releaseVersion || '').replace('v', '') + '.deb';
return `https://github.com/lbryio/lbry-desktop/releases/download/${releaseVersion}/${fileName}`;
case 'win32':
This could maybe use some error catching/validation. It's fine though.
frodo after the thing is done