Fix menubar icon for macOS #767
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#767
Loading…
Reference in a new issue
No description provided.
Delete branch "menu-icon"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Somewhat better. I was just playing around with resizing. We might have to rework an icon specifically for mac displays if we want it more precise than this (larger space above/below?). Should be fine for now, definitely looks better than before.
Related issue https://github.com/electron/electron/issues/417
@liamcardenas can you test this on your mac? It should be the same (I think), but not sure since we have different screen sizes.
@ -229,1 +229,3 @@const iconPath = path.join(app.getAppPath(), "/dist/img/fav/32x32.png");let iconPath;if (process.platform === 'darwin') {// Using @2x for mac retina screens so the icon isn't blurryhttps://gist.github.com/lyoshenka/0a43205aa9a072b196ff87e2c689a8b9#gistcomment-2264825
Merge at your convenience. Although the icon is kind of crappy on other systems too... I blame whoever was in charge of the app previously.
@seanyesmunt how can we check and fix this issue on Windows and Debian if needed?
@liamcardenas I'll spend some time once I get home updating windows/linux icons. From what I remember I don't think the windows icon looked that bad.