Add basic menubar #9

Merged
alexliebowitz merged 2 commits from menubar into master 2017-03-09 00:23:04 +01:00

107
app/menu/main-menu.js Normal file
View file

@ -0,0 +1,107 @@
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
const {Menu} = require('electron');
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
const electron = require('electron');
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
const app = electron.app;
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
const baseTemplate = [
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
label: 'Edit',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
submenu: [
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
role: 'undo',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
role: 'redo',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
type: 'separator',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
role: 'cut',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
role: 'copy',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
role: 'paste',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
]
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
label: 'Help',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
submenu: [
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
label: 'Help',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
click(item, focusedWindow) {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
if (focusedWindow) {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
focusedWindow.loadURL(`file://${__dirname}/../dist/index.html?help`);
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
}
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
}
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
}
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
]
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
}
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
];
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
const macOSAppMenuTemplate = {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
label: app.getName(),
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
submenu: [
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
role: 'about',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
type: 'separator',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
role: 'hide',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
role: 'hideothers',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
role: 'unhide',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
type: 'separator',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
role: 'quit',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
]
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
};
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
const developerMenuTemplate = {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
label: 'Developer',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
submenu: [
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
label: 'Reload',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
accelerator: 'CmdOrCtrl+R',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
click(item, focusedWindow) {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
if (focusedWindow) {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
focusedWindow.reload();
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
}
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
}
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
{
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
label: 'Toggle Developer Tools',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
accelerator: process.platform == 'darwin' ? 'Alt+Command+I' : 'Ctrl+Shift+I',
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
click(item, focusedWindow) {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
if (focusedWindow) {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
focusedWindow.webContents.toggleDevTools();
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
}
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
}
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
]
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
};
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
module.exports = {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
showMenubar(showDeveloperMenu) {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
let template = baseTemplate.slice();
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
if (process.platform === 'darwin') {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
template.unshift(macOSAppMenuTemplate);
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
}
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
if (showDeveloperMenu) {
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
template.push(developerMenuTemplate);
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
}
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
Menu.setApplicationMenu(Menu.buildFromTemplate(template));
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
},
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.
};
kauffj commented 2017-03-08 16:00:07 +01:00 (Migrated from github.com)
Review

What do "undo" and "redo" do in context of this app?

What do "undo" and "redo" do in context of this app?
kauffj commented 2017-03-08 16:00:51 +01:00 (Migrated from github.com)
Review

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?

I also have a "paste and match style" option, which I don't see listed here? Is there a way to just add paste without "paste and match style"?
kauffj commented 2017-03-08 16:01:02 +01:00 (Migrated from github.com)
Review

What does this do?

What does this do?
kauffj commented 2017-03-08 16:01:26 +01:00 (Migrated from github.com)
Review

Same as above questions... why do we need/want this?

Same as above questions... why do we need/want this?
kauffj commented 2017-03-08 16:02:14 +01:00 (Migrated from github.com)
Review

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.

We have a help option in the UI. If we add help to the toolbar, it should go to the same place. If we want to encourage FAQ usage, the main "Help" section should do that.
alexliebowitz commented 2017-03-08 18:36:26 +01:00 (Migrated from github.com)
Review

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.

Undo and redo typing, just like in a browser. They're not going to be heavily used, but I feel like people expect that to be in any app with an Edit menu.
alexliebowitz commented 2017-03-08 18:39:23 +01:00 (Migrated from github.com)
Review

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.

I did remove the Paste and Match Style option, so it sounds like you're getting the default Electron menu (the one that appears in developer mode). It looks similar because I based this on the example from the Electron docs which shows you how to make the same menu as the default developer menu. I'll take a look at the office today.
alexliebowitz commented 2017-03-08 18:44:55 +01:00 (Migrated from github.com)
Review

I feel like these options are supposed to be there for text editing in every app that has text boxes.

I checked the macOS HIG here and it confirms:

Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text.

I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.

I feel like these options are supposed to be there for text editing in every app that has text boxes. I checked the macOS HIG [here](https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html#//apple_ref/doc/uid/20000957-CH29-SW7) and it confirms: > Even if your app doesn’t handle text editing within its documents, the expected Edit commands should be available for use in dialogs and wherever users can edit text. I haven't checked the Windows or GNOME/KDE guidelines, though. Might be different there.
alexliebowitz commented 2017-03-08 18:48:48 +01:00 (Migrated from github.com)
Review

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.

True. I wasn't giving this part a lot of thought because I knew it would be at least today before it was merged. Just trying to get the general framework of the menu up for review. We should probably decide today on the full set of menu items and what they should do.
kauffj commented 2017-03-08 22:26:19 +01:00 (Migrated from github.com)
Review

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.

Chrome does not have undo and redo in it's menu bar. I do not think that we should either.
kauffj commented 2017-03-08 22:26:32 +01:00 (Migrated from github.com)
Review

Confirmed, I no longer see this.

Confirmed, I no longer see this.
kauffj commented 2017-03-08 22:26:49 +01:00 (Migrated from github.com)
Review

This should be removed probably.

This should be removed probably.