implement settings redesign #998

2018-02-06T10:14:05+01:00

neb-b commented

2018-02-06 10:14:05 +01:00

(Migrated from github.com)

This PR contains the implemented settings redesign and updates to form elements

neb-b (Migrated from github.com) reviewed 2018-02-06 10:20:35 +01:00

src/renderer/component/fileCard/view.jsx

					
				@ -97,3 +97,3 @@

				        </div>

				        {obscureNsfw && <NsfwOverlay />}

				        {shouldObscureNsfw && <NsfwOverlay />}

				      </section>

neb-b (Migrated from github.com) commented

2018-02-06 10:20:35 +01:00

Accidentally left this on the last PR.

neb-b (Migrated from github.com) reviewed 2018-02-06 10:21:05 +01:00

src/renderer/component/formField/view.jsx

					
				@ -4,3 +4,3 @@

				import PropTypes from 'prop-types';

				import FileSelector from 'component/file-selector.js';

				import FileSelector from 'component/common/file-selector';

				import SimpleMDE from 'react-simplemde-editor';

neb-b (Migrated from github.com) commented

2018-02-06 10:21:05 +01:00

Just updating it here so the app successfully builds.

neb-b (Migrated from github.com) reviewed 2018-02-06 10:22:39 +01:00

src/renderer/page/settings/view.jsx

					
				@ -146,2 +137,4 @@

				    const noDaemonSettings = !daemonSettings || Object.keys(daemonSettings).length === 0;

				    return (

				      <Page>

neb-b (Migrated from github.com) commented

2018-02-06 10:22:39 +01:00

Figured we can remove these. They aren't to complex so adding them back should be easy (when we can).

neb-b (Migrated from github.com) reviewed 2018-02-06 10:41:29 +01:00

src/renderer/page/settings/view.jsx

neb-b (Migrated from github.com) commented

2018-02-06 10:41:29 +01:00

I would like to add exactly what happens when you clear your cache. Other items to add?

neb-b (Migrated from github.com) reviewed 2018-02-06 10:42:04 +01:00

src/renderer/page/settings/view.jsx

neb-b (Migrated from github.com) commented

2018-02-06 10:42:04 +01:00

I would like to add exactly what data we are collecting and what we are doing with it. Not sure what that is

liamcardenas (Migrated from github.com) approved these changes 2018-02-06 17:47:11 +01:00

liamcardenas (Migrated from github.com) left a comment

im good with these changes! the page looks amazing, the only thing i would suggest is giving the input fields (text input and select) a larger height

neb-b (Migrated from github.com) reviewed 2018-02-06 20:54:08 +01:00

src/renderer/component/common/form-components/form-field.jsx

					
				@ -0,0 +25,4 @@

				      Input = () => <input type={type} id={name} {...inputProps} />;

				    } else if (render) {

				      Input = render;

				    }

neb-b (Migrated from github.com) commented

2018-02-06 20:54:08 +01:00

@kauffj Added back the type prop back. You are definitely right it makes more sense to keep it. I do think it will be nice to offer extra customization if a consumer wants it. Still need to add something to handle select elements.

@kauffj Added back the type prop back. You are definitely right it makes more sense to keep it. I do think it will be nice to offer extra customization if a consumer wants it. Still need to add something to handle `select` elements.

Sign in to join this conversation.

No reviewers

liamcardenas