LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity
lbry-desktop/ui/page
History
infinite-persistence 3243ce6e0a
Image Claims: minimum layout shift on desktop layout 
## Issue
6068

## Change
Lock all images to fit a 16:9 container. We have implemented 'ZoomableImg', so no reason in trying to display in full size.

This reduces CLS from 0.4xx to 0.01x.

## Flaws
CLS could probably be zero if not for the spinner shifting things slightly. Also, mobile CLS is 0.07.

The troublesome part in this PR is that FileRenderInitiator, FileRender and their subcomponents are broken apart and it's hard to synchronize their visibility and size. There are time gaps where none of them are visible, etc.

This PR only tackles the major part (most bang for buck), which is the elimination of variable height of the rendered image.

## Aside
I think `claimIsMine` is unused, so don't waste time requesting it.
2021-07-19 14:26:00 +08:00
..
backup add wallet sync message on wallet page 2020-02-21 13:42:17 -05:00
buy filter buy countries on master 2021-07-06 16:06:58 -04:00
channel Apply placeholder images 2021-07-19 12:07:26 +08:00
channelNew claim email_verified reward on channel/new page 2021-04-04 22:16:45 -04:00
channels Set 'activeChannel' before entering Dashboard 2021-06-22 18:32:05 -04:00
channelsFollowing fix colon handling 2021-07-15 17:48:02 -04:00
channelsFollowingDiscover discover channelIds from homepages 2021-07-16 18:31:48 -04:00
collection Playlist style fixes (#6509) 2021-07-16 15:13:28 -04:00
creatorDashboard remove analytics 2021-06-15 13:47:56 -04:00
discover fix livestream display 2021-07-08 15:08:53 -04:00
file Image Claims: minimum layout shift on desktop layout 2021-07-19 14:26:00 +08:00
fileListDownloaded wip 2021-06-08 13:25:52 -04:00
fileListPublished use button-toggle group for page title 2021-03-16 12:04:39 -04:00
help integrate some Odysee code with master 2021-04-27 19:56:30 -04:00
home more recon 2021-07-18 11:27:05 -04:00
invite add youtube sync to first run 2020-09-29 17:12:32 -04:00
invited new layout 🕺 2020-09-29 17:12:32 -04:00
library new lbc icon 2020-09-29 17:12:32 -04:00
listBlocked Moderator Delegation GUI 2021-06-18 15:46:51 -04:00
lists wip 2021-06-08 13:25:52 -04:00
livestream use commentron for live view counts 2021-06-17 14:58:55 -04:00
navigationHistory refactor lbrytv web server 2019-11-11 13:27:29 -05:00
notifications fetch notofication/categories for notification types dropdown 2021-04-30 12:45:46 -04:00
passwordReset new layout 🕺 2020-09-29 17:12:32 -04:00
passwordSet new layout 🕺 2020-09-29 17:12:32 -04:00
publish add initial support for comment API outside of SDK 2021-02-11 10:45:34 -05:00
receive ReceiveLBC: switch from Modal to Page 2021-04-13 14:02:25 -04:00
report Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
reportContent Implement ReportContent page 2021-04-21 10:49:31 -04:00
repost changes, bump 2020-12-28 15:00:15 -05:00
rewards More master reconciliation 2021-04-27 23:05:38 -04:00
rewardsVerify rewards redirect fix for manually approved users 2020-07-03 13:18:28 -04:00
search Remove hardcoded filters in doSearch 2021-07-14 11:16:19 +08:00
send allow sending directly to a channel or content address (#5990) 2021-05-20 15:30:40 -04:00
settings Stripe 2 2021-07-17 13:19:33 -04:00
settingsAdvanced Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
settingsCreator Enable 'slow mode' in comments 2021-07-07 19:31:15 -04:00
settingsNotifications Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
show Reload page when trying to open stale chunks 2021-07-08 15:06:09 +08:00
signIn new layout 🕺 2020-09-29 17:12:32 -04:00
signInVerify review this 2021-07-13 23:45:51 -04:00
signInWalletPassword get sync password out of signing flow 2020-09-21 14:11:25 -04:00
signUp new layout 🕺 2020-09-29 17:12:32 -04:00
swap CoinSwap: websocket + multi-coin 2021-04-13 14:02:25 -04:00
tagsFollowing Enable tile layout for 'Your Tags' page 2020-12-18 14:02:50 -05:00
tagsFollowingManage per channel notification settings 2020-11-02 14:13:13 -05:00
top integrate some Odysee code with master 2021-04-27 19:56:30 -04:00
wallet more lint 2021-07-17 13:19:33 -04:00
welcome new layout 🕺 2020-09-29 17:12:32 -04:00
youtubeSync Sort all language dropdowns, not just in the Settings Page. 2021-06-07 10:15:07 +08:00