lbry-desktop/flow-typed
infinite-persistence e9a2f44899
Commentron: incorporate 'setting.Get' into 'doFetchCreatorSettings'
## General
- `setting.List`: returns full creator settings. Requires signature (i.e. you own the channel)
- `setting.Get`: returns a public subset of the creator settings. No signature required, and it is mainly used by the GUI to determine the constraints of a channel (e.g. comments enabled? min tip requirements? etc.). Does not include private settings like "blocked words list".

`doFetchCreatorSettings` will handle both of these. Clients that uses the stashed results (`settingsByChannelId`) just needs to be aware the result might not contain everything, depending on whether you own the channel or not.

## Misc Related Changes
- Finally fix the reducer for COMMENT_FETCH_SETTINGS_COMPLETED to not purge the data on each call.
- Change `doFetchCreatorSettings` to operate on a single channel instead of multiple. We ended up not using the multple mode anyway, so it was wasteful code trying to batch the promises.
- `commentsDisabledChannelIds` is no longer needed. Previously, this was created just to differentiate between Creator (full) and Channel (subset) settings. It's cleaner to just use one object, so eliminated this.
- Remove unused 'commentingEnabled'.

## Aside
- There are now 2 ways to know if a channel has disabled comments: (1) from `comment.list` and `setting.Get|List`. Both of them updates `settingsByChannelId`, so it'll still be a single place for the GUI to check against.
2021-08-12 14:51:41 +08:00
..
npm flow fixes 2020-12-16 10:52:22 -05:00
18nj.js pr feedback 2019-10-01 01:48:43 -04:00
bluebird.js Fix Flow config 2017-12-07 17:04:19 -03:00
classnames.js Fix Flow config 2017-12-07 17:04:19 -03:00
Comment.js Commentron: incorporate 'setting.Get' into 'doFetchCreatorSettings' 2021-08-12 14:51:41 +08:00
content.js refactor floatingUri to allow inline players in comments/markdown 2020-10-21 15:29:29 -04:00
electron.js Fix Flow config 2017-12-07 17:04:19 -03:00
formik.js Fix Flow config 2017-12-07 17:04:19 -03:00
homepage.js pinning 2021-07-22 23:24:55 -04:00
livestream.js use commentron for live view counts 2021-06-17 14:58:55 -04:00
location.js 0.36.0 sdk changes 2019-04-24 10:02:52 -04:00
notification.js fetch notofication/categories for notification types dropdown 2021-04-30 12:45:46 -04:00
publish.js Propagate thumbnail errors to PublishFormData 2021-04-26 12:24:19 -04:00
qrcode.react.js Fix Flow config 2017-12-07 17:04:19 -03:00
react-markdown.js implement app redesign 2018-03-26 14:32:43 -07:00
react-modal.js implement app redesign 2018-03-26 14:32:43 -07:00
react-paginate.js implement app redesign 2018-03-26 14:32:43 -07:00
react-simplemde-editor.js implement app redesign 2018-03-26 14:32:43 -07:00
react-transition-group.js implement app redesign 2018-03-26 14:32:43 -07:00
redux.js per channel notification settings 2020-11-02 14:13:13 -05:00
reportContent.js Add 'ReportContent' actions/reducers/selectors 2021-04-21 10:49:31 -04:00
reselect.js implement app redesign 2018-03-26 14:32:43 -07:00
reward.js feat: daily reward 2019-09-05 09:40:42 -04:00
search.js Only concatenate results if 'from !== 0' 2021-04-07 12:08:17 -04:00
shapeshift.io.js Fix Flow config 2017-12-07 17:04:19 -03:00
subscription.js Feat publish replays on master (#5863) 2021-04-14 00:06:11 -04:00
user.js make flow shut up 2021-07-05 10:02:03 -04:00
web-file.js fix WebFile flow type 2020-08-13 11:11:23 -04:00
web.js replace insufficient credits modal with inline ui elements 2019-04-03 00:17:00 -04:00