LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity
lbry-desktop/ui/page
History
infinite-persistence f88bfcd7f3 Render whole app on language change 
## Issues
1. We were manually adding `selectLanguage(state)` as a prop to components used in Settings Page to trigger a render. Flaws:
    - Unclear that the unused prop is just to trigger a render.
    - Manually adding on a case-by-case basis will break over time, especially when language can now be changed outside of the Settings Page.

2. The translation file fetching is delayed and also takes time, so the GUI will end up having mixed strings on F5, depending on when the fetch completed.

## Approach
Make the app wrapper have a key that's tied to the language and translation data, so the entire app renders when language changes. Seems like a common design in most apps.

## Ticket
921 language refresh / selection issues
2022-02-26 13:08:17 -05:00
..
backup add wallet sync message on wallet page 2020-02-21 13:42:17 -05:00
buy Fix incorrect usages of I18nMessage 2022-02-18 20:00:36 +08:00
channel MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
channelNew Limit channel-creation count from the UI (#886) 2022-02-16 09:14:08 -05:00
channels MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
channelsFollowing Add a setting to hide scheduled livestreams from home/following (#626) 2022-01-05 16:20:43 -05:00
channelsFollowingDiscover MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
checkoutPage Revert "move stuff to web (#6537)" 2021-07-19 10:12:57 -04:00
collection Lazy-load "Beautiful Drag-N-Drop" (#859) 2022-02-14 14:54:23 -05:00
creatorDashboard Use 'selectHasChannel' instead of the full 'selectMyChannelClaims' 2021-11-08 15:02:44 +08:00
discover Add hint that results are being filtered by language 2022-02-25 16:53:45 -05:00
embedWrapper Restore 'https' to dmca link and remove actual dup 2021-11-30 14:21:33 +08:00
file [Fix] revert fileRenderFloating vs Mobile change (#937) 2022-02-23 16:13:22 -05:00
fileListDownloaded Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
fileListPublished MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
fourOhFour Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
help Update chat channel 2022-02-07 10:22:20 -05:00
home Fix missing homepage placeholder while waiting for livestream data (#904) 2022-02-17 09:18:49 -05:00
invite Defer user/invite_status from startup 2022-01-21 09:19:17 -05:00
invited Fix url selectors 2021-11-17 19:57:04 +08:00
library Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
listBlocked Use 'selectHasChannel' instead of the full 'selectMyChannelClaims' 2021-11-08 15:02:44 +08:00
lists MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
livestream MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
livestreamCurrent Add 'ENABLE_WIP_FEATURES' for live page. 2021-08-12 21:52:58 -07:00
livestreamSetup Feature livestream scheduling (#458) 2021-12-16 16:59:13 -05:00
navigationHistory refactor lbrytv web server 2019-11-11 13:27:29 -05:00
notifications Notifications: use fetched urls instead of resolving (#820) 2022-02-07 15:59:20 -05:00
ownComments Cleanup Comment and CommentsList and fix new pages 2022-02-09 11:48:40 -05:00
passwordReset new layout 🕺 2020-09-29 17:12:32 -04:00
passwordSet new layout 🕺 2020-09-29 17:12:32 -04:00
passwordUpdate Move 'update password' into a subpage 2021-08-23 23:45:31 +08:00
playlists improve playlists display (#232) 2021-11-05 21:00:27 -04:00
popoutChatWrapper [Live Chat] Break down componets for Page Layout + Add ability to Pop Out chat window + Hide chat option (#681) 2022-01-14 15:24:16 -05:00
publish Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
receive Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
report [Report Page] Fix GitHub URL and improve strings (#340) 2021-11-22 09:32:33 -05:00
reportContent Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
repost Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
rewards FAQ stuff (#109) 2021-10-21 16:21:51 -04:00
rewardsVerify rewards redirect fix for manually approved users 2020-07-03 13:18:28 -04:00
search MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
send Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
settings Render whole app on language change 2022-02-26 13:08:17 -05:00
settingsCreator Add "min channel age" setting 2022-02-23 23:01:57 +08:00
settingsNotifications Browser push notifications (#133) 2021-10-27 10:38:10 -04:00
settingsStripeAccount Merge pull request #6917 from lbryio/squashed-and-merged 2021-08-24 18:46:47 +02:00
settingsStripeCard Fiat tip improvements (#7038) 2021-09-09 12:52:03 -04:00
show Fix search replacing 2022-02-24 12:42:43 -03:00
signIn MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
signInVerify MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
signInWalletPassword get sync password out of signing flow 2020-09-21 14:11:25 -04:00
signUp MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
swap Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
tagsFollowing Kill makeSelectClientSetting 2021-11-23 12:29:53 +08:00
tagsFollowingManage per channel notification settings 2020-11-02 14:13:13 -05:00
top Fix incorrect usages of I18nMessage 2022-02-18 20:00:36 +08:00
wallet MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
welcome Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
youtubeSync i18n updates and fixes (#822) 2022-02-07 13:15:22 -05:00