LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity
lbry-desktop/ui/modal
History
infinite-persistence ece2312ec5 selectClaimIsMineForUri to replace makeSelectClaimIsMine 
## Issue
`normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop.

## Change
Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead.

## Results
- in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone.

- in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
2021-11-10 16:49:12 +08:00
..
modalAffirmPurchase Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalAutoGenerateThumbnail Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalAutoUpdateDownloaded
modalBlockChannel Block: pass comment ID for deletion when being blocked. (#255) 2021-11-09 09:43:02 -05:00
modalClaimCollectionAdd
modalCommentAcknowledgement
modalConfirm General-purpose "Confirm" modal 2021-10-29 13:36:27 +08:00
modalConfirmAge Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalConfirmThumbnailUpload Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalConfirmTransaction Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalDownloading
modalError Odysee specific changes and other misc improvements (#219) 2021-11-03 15:47:19 -04:00
modalFileSelection Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalFileTimeout Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalFirstReward
modalFirstSubscription
modalImageUpload
modalIncompatibleDaemon
modalMassTipUnlock FAQ stuff (#109) 2021-10-21 16:21:51 -04:00
modalMobileSearch
modalOpenExternalResource Odysee specific changes and other misc improvements (#219) 2021-11-03 15:47:19 -04:00
modalPasswordUnsave
modalPhoneCollection
modalPublish Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalPublishPreview Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalRemoveCard Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalRemoveCollection selectClaimIsMineForUri to replace makeSelectClaimIsMine 2021-11-10 16:49:12 +08:00
modalRemoveComment Allow moderators to delete comment (#235) 2021-11-08 12:22:40 -05:00
modalRemoveFile selectClaimIsMineForUri to replace makeSelectClaimIsMine 2021-11-10 16:49:12 +08:00
modalRevokeClaim Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalRewardCode FAQ stuff (#109) 2021-10-21 16:21:51 -04:00
modalRouter Fix crash with ModalError 2021-11-03 10:09:01 +08:00
modalSendTip
modalSetReferrer Odysee specific changes and other misc improvements (#219) 2021-11-03 15:47:19 -04:00
modalSignOut
modalSocialShare
modalSupportsLiquidate Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalSyncEnable
modalTransactionFailed
modalUpgrade Fix scrollbar in upgrade modal (#7076) 2021-09-13 11:35:26 -04:00
modalViewImage
modalWalletDecrypt Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalWalletEncrypt Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalWalletUnlock Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
modalYoutubeWelcome
modal.jsx