LBRYCommunity/lbry-docker
1
0
Fork 0
Code Issues 2 Pull requests 2 Projects Releases 1 Packages Wiki Activity

Healthchecks and port mappings for docker-compose #87

Merged
dangarthwaite merged 10 commits from healthchecks_lbryio/lbry-docker#59 into master 2019-10-10 17:14:29 +02:00
Conversation 3 Commits 10 Files changed 12 +73 -81
dangarthwaite commented 2019-10-10 03:47:04 +02:00 (Migrated from github.com)
Copy link
No description provided.
dangarthwaite commented 2019-10-10 03:48:29 +02:00 (Migrated from github.com)
Copy link

For https://github.com/lbryio/lbry-docker/issues/59

For https://github.com/lbryio/lbry-docker/issues/59
Leopere (Migrated from github.com) reviewed 2019-10-10 04:16:18 +02:00
Leopere (Migrated from github.com) left a comment
Copy link

This looks as though it will lose a lot of the features, however your comment in #59 is right it will improve readability significantly.

The idea is that the configuration uses one replacement mechanism to find the source configuration string and replaces it but this said I have not kept up to date on the default state of the Chainquery configuration in a while so this may be the best method to take at this point.

The goal with my previous start.sh script configuration was to allow people to lean on the docker container via environment variables as that seems to be the most multi container platform compatible solution.

All this said upon my review of my own goals here I'm seeing a few flaws in what I decided on using here as well so as long as we don't lose too much in this PR I will gladly merge it.

Thank you for your contributions!

This looks as though it will lose a lot of the features, however your comment in #59 is right it will improve readability significantly. The idea is that the configuration uses one replacement mechanism to find the source configuration string and replaces it but this said I have not kept up to date on the default state of the Chainquery configuration in a while so this may be the best method to take at this point. The goal with my previous start.sh script configuration was to allow people to lean on the docker container via environment variables as that seems to be the most multi container platform compatible solution. All this said upon my review of my own goals here I'm seeing a few flaws in what I decided on using here as well so as long as we don't lose too much in this PR I will gladly merge it. Thank you for your contributions!
dangarthwaite commented 2019-10-10 04:27:15 +02:00 (Migrated from github.com)
Copy link

The proposed start script shouldn't change any behavior. Variables have a
default value that is overridden by environment variables defined in docker.

On Wed, Oct 9, 2019, 10:16 PM Leopere notifications@github.com wrote:

@Leopere commented on this pull request.

This looks as though it will lose a lot of the features, however your
comment in #59 https://github.com/lbryio/lbry-docker/issues/59 is right
it will improve readability significantly.

The idea is that the configuration uses one replacement mechanism to find
the source configuration string and replaces it but this said I have not
kept up to date on the default state of the Chainquery configuration in a
while so this may be the best method to take at this point.

The goal with my previous start.sh script configuration was to allow
people to lean on the docker container via environment variables as that
seems to be the most multi container platform compatible solution.

All this said upon my review of my own goals here I'm seeing a few flaws
in what I decided on using here as well so as long as we don't lose too
much in this PR I will gladly merge it.

Thank you for your contributions!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-docker/pull/87?email_source=notifications&email_token=AAALCOHHVI5BVOYRRRPG57LQN2F7HA5CNFSM4I7GX2L2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHPGN6Q#pullrequestreview-299788026,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALCOEHUIGIOXL55AVCLW3QN2F7HANCNFSM4I7GX2LQ
.

The proposed start script shouldn't change any behavior. Variables have a default value that is overridden by environment variables defined in docker. On Wed, Oct 9, 2019, 10:16 PM Leopere <notifications@github.com> wrote: > *@Leopere* commented on this pull request. > > This looks as though it will lose a lot of the features, however your > comment in #59 <https://github.com/lbryio/lbry-docker/issues/59> is right > it will improve readability significantly. > > The idea is that the configuration uses one replacement mechanism to find > the source configuration string and replaces it but this said I have not > kept up to date on the default state of the Chainquery configuration in a > while so this may be the best method to take at this point. > > The goal with my previous start.sh script configuration was to allow > people to lean on the docker container via environment variables as that > seems to be the most multi container platform compatible solution. > > All this said upon my review of my own goals here I'm seeing a few flaws > in what I decided on using here as well so as long as we don't lose too > much in this PR I will gladly merge it. > > Thank you for your contributions! > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-docker/pull/87?email_source=notifications&email_token=AAALCOHHVI5BVOYRRRPG57LQN2F7HA5CNFSM4I7GX2L2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHPGN6Q#pullrequestreview-299788026>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAALCOEHUIGIOXL55AVCLW3QN2F7HANCNFSM4I7GX2LQ> > . >
Leopere (Migrated from github.com) reviewed 2019-10-10 04:43:13 +02:00
Leopere (Migrated from github.com) left a comment
Copy link

Just looking for replies on the comments, likely 100% acceptable just want to follow up.

Thank you for your PR's

Just looking for replies on the comments, likely 100% acceptable just want to follow up. Thank you for your PR's
chainquery/Dockerfile-linux-x86_64-production
@ -5,3 +5,3 @@
RUN apt-get update && \
apt-get -y install unzip curl && \
apt-get -y install unzip curl busybox-static && \
apt-get autoclean -y && \
Leopere (Migrated from github.com) commented 2019-10-10 04:38:50 +02:00
Copy link

Cool trick, I like this!

Cool trick, I like this!
chainquery/compose/docker-compose.yml-prod-example
@ -12,3 +11,3 @@
## https://hub.docker.com/r/_/mariadb/
## Work is underway to support percona
mysql:
image: mysql:5.7.23
Leopere (Migrated from github.com) commented 2019-10-10 04:19:57 +02:00
Copy link

Has this been decided proper at this point I spoke with @nikooo777 a month or so ago and was told not to bother.

Has this been decided proper at this point I spoke with @nikooo777 a month or so ago and was told not to bother.
Leopere (Migrated from github.com) commented 2019-10-10 04:20:10 +02:00
Copy link

Also thank you for the cleanup.

Also thank you for the cleanup.
chainquery/compose/docker-compose.yml-prod-example
@ -41,4 +44,4 @@
lbry-network:
ipv4_address: 10.6.1.3
env_file:
- env
Leopere (Migrated from github.com) commented 2019-10-10 04:21:14 +02:00
Copy link

Looks awesome!

Looks awesome!
chainquery/compose/docker-compose.yml-prod-example
Leopere (Migrated from github.com) commented 2019-10-10 04:22:41 +02:00
Copy link

Would we prefer to build the production example rather than pull from the LBRY official repo?

Would we prefer to build the production example rather than pull from the LBRY official repo?
chainquery/compose/docker-compose.yml-prod-example
Leopere (Migrated from github.com) commented 2019-10-10 04:23:39 +02:00
Copy link

This is likely fine but I might've been just pulling the lbrycrd env file due to only needing to know the RPC credentials.

This is likely fine but I might've been just pulling the lbrycrd env file due to only needing to know the RPC credentials.
Leopere (Migrated from github.com) approved these changes 2019-10-10 17:13:45 +02:00
Leopere (Migrated from github.com) left a comment
Copy link

Thanks for your contributions.

Thanks for your contributions.
tzarebczan commented 2019-10-15 18:05:49 +02:00 (Migrated from github.com)
Copy link

@dangarthwaite thanks for the PR!

Can we show you some appreciation for the contribution?

Also, we're giving away some Hacktoberfest bonuses and goodies for this month. We'll get you the form required once you send us an email.

@dangarthwaite thanks for the PR! Can we show you some [appreciation](https://lbry.com/faq/appreciation) for the contribution? Also, we're giving away some [Hacktoberfest](https://lbry.com/news/hacktoberfest-2019) bonuses and goodies for this month. We'll get you the form required once you send us an email.
Sign in to join this conversation.
Reviewers
No reviewers
Leopere
Labels
Clear labels   
Accepted

Just for marking accepted PR's

  
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
In Review

Pull Requests that are currently in review and potentially waiting tweaks or feedback for clarity.

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
Accepted
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
Epic
good first issue
hacktoberfest
help wanted
icebox
In Review
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-docker#87
No description provided.
Delete branch "healthchecks_lbryio/lbry-docker#59"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?