5329 commits

Author	SHA1	Message	Date
Gavin Andresen	18379875bf	Optimize -regtest setgenerate block generation ... Speed up generating blocks in regression test mode, by moving block-creating and nonce-finding directly into the setgenerate RPC call (instead of starting up a mining thread and waiting for it to find a block). This makes the forknotify RPC test three times quicker, for example (10 seconds runtime instead of 30 seconds, assuming the initial blockchain cache is already built).	2014-11-14 13:42:15 -05:00
Wladimir J. van der Laan	3d3ce7421e	Merge pull request #5198 ... 1c0aa91 Update serialize comments to be doxygen compatible (Michael Ford)	2014-11-13 19:41:56 +01:00
Wladimir J. van der Laan	6c5c06eff7	Merge pull request #5252 ... b9a36b1 Make comments in /src/script doxygen compatible (Michael Ford)	2014-11-13 17:51:57 +01:00
Philip Kaufmann	cd4d3f1915	Win32: change buffer size for gethotsname in Discover() ... - 256 byte is the maximum, as per http://msdn.microsoft.com/en-us/library/windows/desktop/ms738527%28v=vs.85%29.aspx	2014-11-13 15:26:09 +01:00
Philip Kaufmann	8fa0494e92	Win32: log addresses found in Discover() calls	2014-11-13 15:25:44 +01:00
Philip Kaufmann	13f903187c	init: minor parameter interaction updates ... - use __func__ instead of hard-coded function name for logging - update -discover help message to reflect newly added parameter interaction - use DEFAULT_LISTEN in a parameter interaction check instead a hard coded value	2014-11-13 15:15:53 +01:00
Wladimir J. van der Laan	ed98a6284b	Merge pull request #5203 ... 0d91ae3 The first thing that SelectParams does is call SelectBaseParams. Therefore, we do not need to call SelectBaseParams immediately prior to calling SelectParams. (mruddy)	2014-11-13 13:14:45 +01:00
Jonas Schnelli	4a8fc152a9	[Qt] the RPC Console should be a QWidget to make window more independent ... - fix issue #5254	2014-11-13 12:57:24 +01:00
Pieter Wuille	60672a61ff	Merge pull request #5256 ... f4e0aef Do signature-s negation inside the tests (Pieter Wuille)	2014-11-12 11:44:25 -08:00
Wladimir J. van der Laan	0c7862e968	Merge pull request #5161 ... 845c86d Do not use third party services for IP detection. (Gregory Maxwell)	2014-11-12 18:35:45 +01:00
21E14	cca48f69b0	Reset setBlockIndexCandidates once block index db loaded	2014-11-12 00:35:24 -05:00
Jeff Garzik	e2655e0ab1	Add unauthenticated HTTP REST interface to public blockchain data.	2014-11-11 04:52:43 -05:00
sinetek	d52f072605	Don't show wallet options in the preferences menu when running with -disablewallet	2014-11-10 20:50:41 +01:00
Wladimir J. van der Laan	af3ec17f67	Merge pull request #5246 ... a8a5e01 Adding license. (sinetek)	2014-11-10 17:31:54 +01:00
Wladimir J. van der Laan	33d5ee6830	Merge pull request #5239 ... 65e3a1e Make sure that GetRandomBytes never fails (Wladimir J. van der Laan)	2014-11-10 17:30:13 +01:00
Pieter Wuille	f4e0aefadc	Do signature-s negation inside the tests ... To avoid the need for libsecp256k1 to expose such functionality.	2014-11-10 05:03:24 -08:00
Pieter Wuille	5406f61373	Merge pull request #5249 ... 38c62ae Adding const. (sinetek)	2014-11-10 04:29:57 -08:00
Peter Todd	7c041b3b91	Check against MANDATORY flags prior to accepting to mempool ... Previously transactions were only tested again the STANDARD_SCRIPT_VERIFY_FLAGS prior to mempool acceptance, so any bugs in those flags that allowed actually-invalid transactions to pass would result in allowing invalid transactions into the mempool. Fortunately there is a second check in CreateNewBlock() that would prevent those transactions from being mined, resulting in an invalid block, however this could still be exploited as a DoS attack.	2014-11-10 02:52:28 -05:00
Michael Ford	b9a36b15bf	Make comments in /src/script doxygen compatible	2014-11-10 14:51:55 +08:00
sinetek	38c62aec0d	Adding const.	2014-11-08 18:09:06 -05:00
sinetek	a8a5e0133a	Adding license.	2014-11-08 15:46:21 -05:00
Pieter Wuille	7b7c866160	Merge pull request #5210 ... 1f84793 Avoid a bunch of copying/conversion in script/sign (Pieter Wuille)	2014-11-08 08:01:47 -08:00
Gregory Maxwell	845c86d128	Do not use third party services for IP detection. ... This is a simplified re-do of closed pull #3088. This patch eliminates the privacy and reliability problematic use of centralized web services for discovering the node's addresses for advertisement. The Bitcoin protocol already allows your peers to tell you what IP they think you have, but this data isn't trustworthy since they could lie. So the challenge is using it without creating a DOS vector. To accomplish this we adopt an approach similar to the one used by P2Pool: If we're announcing and don't have a better address discovered (e.g. via UPNP) or configured we just announce to each peer the address that peer told us. Since peers could already replace, forge, or drop our address messages this cannot create a new vulnerability... but if even one of our peers is giving us a good address we'll eventually make a useful advertisement. We also may randomly use the peer-provided address for the daily rebroadcast even if we otherwise have a seemingly routable address, just in case we've been misconfigured (e.g. by UPNP). To avoid privacy problems, we only do these things if discovery is enabled.	2014-11-07 12:13:46 -08:00
Jonas Schnelli	31aac02446	Qt: new icons ... - flat and b/w icons seems to be the new trend - support for HiDPI/retina - change icon sizes - fix assets-attribution.md - removed unused icons	2014-11-07 19:55:25 +01:00
Wladimir J. van der Laan	65e3a1e762	Make sure that GetRandomBytes never fails ... We're using GetRandomBytes in several contexts where it's either unwieldy to return an error, or an error would mean a fatal exception anyhow. @gmaxwell checked OpenSSL a while ago and discovered that it never actually fails, but it can't hurt to be a bit paranoid here.	2014-11-07 13:49:25 +01:00
Ruben Dario Ponticelli	9ec75c5ef4	Add a locking mechanism to IsInitialBlockDownload to ensure it never goes from false to true.	2014-11-07 08:09:31 -03:00
ENikS	5985ba9e61	Fixing warning C4099: 'CExtPubKey' : type name first seen using 'class' now seen using 'struct'	2014-11-06 17:53:25 -05:00
Pieter Wuille	bfe029feeb	Reduce bitcoin-tx dependencies	2014-11-06 00:24:41 -08:00
Pieter Wuille	df0a45503b	Merge pull request #5221 ... 93a6022 Reduce bitcoin-cli dependencies (Pieter Wuille)	2014-11-06 00:06:01 -08:00
Wladimir J. van der Laan	f654f0040b	Change -genproclimit default to 1 ... This is less surprising. Avoids the overload-the-CPU default of using N threads for script verification as well as N threads for generation where N is number of cores.	2014-11-06 08:54:39 +01:00
Wladimir J. van der Laan	9bdec76037	Always log number of threads for script verification ... Helps for troubleshooting.	2014-11-06 08:54:34 +01:00
Pieter Wuille	93a6022400	Reduce bitcoin-cli dependencies	2014-11-05 12:47:33 -08:00
Wladimir J. van der Laan	d064f7f3ee	Merge pull request #5215 ... 93a3f0e Qt: Network-Traffic-Graph: make some distance between line and text (Jonas Schnelli)	2014-11-05 16:04:28 +01:00
Wladimir J. van der Laan	4e0e5e4bc8	Merge pull request #5218 ... 236d96e Qt: Add support for missing scrollbar in peers table (Jonas Schnelli)	2014-11-05 15:58:49 +01:00
Jonas Schnelli	236d96e0a3	Qt: Add support for missing scrollbar in peers table	2014-11-05 11:45:37 +01:00
Jonas Schnelli	93a3f0e7fe	Qt: Network-Traffic-Graph: make some distance between line and text ... Text directly glued on the graph-line looks not so good.	2014-11-05 11:39:47 +01:00
Wladimir J. van der Laan	0778333b8c	Merge pull request #5173 ... 50b43fd Be a bit more verbose during -loadblock if we already have blocks (Matt Corallo) 8375e22 Fix -loadblock after shutdown during IBD (Matt Corallo) 4ead850 Fix for crash during block download (Matt Corallo)	2014-11-05 09:40:25 +01:00
mruddy	84877904c0	bitcoin-tx: Add the "-txid" option. Also add the hex-encoded transaction to the JSON output as the "hex" property.	2014-11-04 21:43:03 -05:00
Pieter Wuille	1f847936c9	Avoid a bunch of copying/conversion in script/sign	2014-11-04 13:59:41 -08:00
Cozz Lovan	9b1627d13e	[Wallet] Reduce minTxFee for transaction creation to 1000 satoshis	2014-11-04 22:29:40 +01:00
Daniel Kraft	af82884ab7	Add "warmup mode" for RPC server. ... Start the RPC server before doing all the (expensive) startup initialisations like loading the block index. Until the node is ready, return all calls immediately with a new error signalling "in warmup" with an appropriate status message (similar to the init message). This is useful for RPC clients to know that the server is there (e. g., they don't have to start it) but not yet available. It is used in Namecoin and Huntercoin already for some time, and there exists a UI hooked onto the RPC interface that actively uses this to its advantage.	2014-11-04 16:01:09 +01:00
Philip Kaufmann	b4347f6035	minor code style cleanup after recent merges ... - add a missing license header - correct some header orderings etc.	2014-11-04 14:36:46 +01:00
Pieter Wuille	1dbabb6521	Merge pull request #5191 ... a2cfae8 util.cpp comment correction (21E14)	2014-11-04 04:38:45 -08:00
mruddy	0d91ae308c	The first thing that SelectParams does is call SelectBaseParams. Therefore, we do not need to call SelectBaseParams immediately prior to calling SelectParams.	2014-11-04 07:24:47 -05:00
Wladimir J. van der Laan	df504e924a	Merge pull request #5196 ... 8473862 Fix all header defines (Pavel Janík)	2014-11-04 09:33:22 +01:00
Wladimir J. van der Laan	73b82a3089	Merge pull request #5162 ... d2e74c5 boost: moveonly: split CPubKey and friends to new files (Cory Fields) 78c228c boost: moveonly: move BIP32Hash to hash.h (Cory Fields) 900078a boost: moveonly: create eccryptoverify.h|cpp and move helper functions there (Cory Fields)	2014-11-04 09:26:45 +01:00
Wladimir J. van der Laan	ff17816abf	Merge pull request #3727 ... e69a587 RPC: submitblock: Support for returning specific rejection reasons (Luke Dashjr)	2014-11-03 20:55:46 +01:00
Wladimir J. van der Laan	7f7fede0eb	Merge pull request #5157 ... b4ee0bd Introduce preferred download peers (Pieter Wuille)	2014-11-03 16:40:36 +01:00
Pavel Janík	84738627ce	Fix all header defines	2014-11-03 16:16:40 +01:00
Wladimir J. van der Laan	4e852e57b1	Merge pull request #5186 ... 771d500 minor cleanup: include orders, end comments etc. (Philip Kaufmann)	2014-11-03 15:03:28 +01:00
Wladimir J. van der Laan	84d26d3a36	Merge pull request #5106 ... 1bea2bb Rename ProcessBlock to ProcessNewBlock to indicate change of behaviour, and document it (Luke Dashjr) d29a291 Rename RPC_TRANSACTION_* errors to RPC_VERIFY_* and use RPC_VERIFY_ERROR for submitblock (Luke Dashjr) f877aaa Bugfix: submitblock: Use a temporary CValidationState to determine accurately the outcome of ProcessBlock, now that it no longer does the full block validity check (Luke Dashjr) 24e8896 Add CValidationInterface::BlockChecked notification (Luke Dashjr)	2014-11-03 12:22:45 +01:00
Wladimir J. van der Laan	2a6972133f	Merge pull request #5185 ... 2191eac add tests to travis (Cory Fields) 7667850 tests: replace the old (unused since Travis) tests with new rpc test scripts (Cory Fields) fa7f8cd tests: remove old pull-tester scripts (Cory Fields) 5122ea7 tests: fix forknotify.py on windows (Cory Fields) 7a41614 tests: allow rpc-tests to get filenames for bitcoind and bitcoin-cli from the environment (Cory Fields) f635269 tests: enable alertnotify test for Windows (Cory Fields)	2014-11-03 09:23:17 +01:00
Wladimir J. van der Laan	7a9356bf16	Merge pull request #5169 ... 20a5f61 Don't relay alerts to peers before version negotiation (Wladimir J. van der Laan)	2014-11-03 08:49:31 +01:00
21E14	a2cfae8e18	util.cpp comment correction	2014-11-01 09:41:48 -04:00
Wladimir J. van der Laan	04e988c6ce	Merge pull request #5145 ... 484e350 Update comments in client version to be doxygen compatible (Michael Ford) 6395ba3 Update comments in version to be doxygen compatible (Michael Ford)	2014-10-31 16:30:55 +01:00
Pieter Wuille	7cd85f431a	Merge pull request #5187 ... e743678 fix a typo (Yoichi Hirai)	2014-10-31 05:47:08 -07:00
Yoichi Hirai	e743678d5a	fix a typo	2014-10-31 20:51:05 +09:00
Wladimir J. van der Laan	917b83127d	qt: translations update from Transifex	2014-10-31 11:19:05 +01:00
Wladimir J. van der Laan	96012e83f1	Merge pull request #5077 ... 2aa6329 Enable customising node policy for datacarrier data size with a -datacarriersize option (Luke Dashjr)	2014-10-31 11:16:09 +01:00
Wladimir J. van der Laan	7bb681d407	Merge pull request #5168 ... 023e63d qt: Move transaction notification to transaction table model (Wladimir J. van der Laan)	2014-10-31 10:46:05 +01:00
Philip Kaufmann	771d500283	minor cleanup: include orders, end comments etc. ... - no code changes	2014-10-31 09:41:15 +01:00
Cory Fields	d2e74c55bd	boost: moveonly: split CPubKey and friends to new files	2014-10-31 01:19:37 -04:00
Cory Fields	78c228c6e5	boost: moveonly: move BIP32Hash to hash.h	2014-10-31 01:13:07 -04:00
Cory Fields	900078aeb4	boost: moveonly: create eccryptoverify.h|cpp and move helper functions there ... Eventually (after 0.10) these files will hold the logic for crypto verification routines, and CKey/CPubKey will call into them.	2014-10-31 01:13:07 -04:00
Michael Ford	1c0aa9110e	Update serialize comments to be doxygen compatible	2014-10-31 13:07:05 +08:00
Cory Fields	f635269cd1	tests: enable alertnotify test for Windows ... The semantics of "echo" are different there and they change the resulting text, but they're still correct and predictable.	2014-10-31 00:04:14 -04:00
Michael Ford	484e350f04	Update comments in client version to be doxygen compatible	2014-10-31 08:27:27 +08:00
Michael Ford	6395ba3036	Update comments in version to be doxygen compatible	2014-10-31 08:20:17 +08:00
Wladimir J. van der Laan	8d2396c9c4	Merge pull request #5164 ... 71697f9 Separate protocol versioning from clientversion (Cory Fields)	2014-10-30 17:24:36 +01:00
Wladimir J. van der Laan	c4761ffb70	Merge pull request #5146 ... 5b40d88 Update comments in wallet to be doxygen compatible (Michael Ford)	2014-10-30 17:15:09 +01:00
Wladimir J. van der Laan	393a28a50c	Merge pull request #5174 ... 7792040 Update comments in rpcserver to be doxygen compatible (Michael Ford)	2014-10-30 17:13:25 +01:00
Wladimir J. van der Laan	4f5f490ce0	Merge pull request #5167 ... 2d06c0f Add missing reserved address spaces. (Matt Corallo)	2014-10-30 17:09:18 +01:00
Wladimir J. van der Laan	d5e5d1412e	Merge pull request #5172 ... eadcd0c Print parameter interactions to console, too (Matt Corallo)	2014-10-30 17:03:30 +01:00
Wladimir J. van der Laan	c1def0df51	Merge pull request #5176 ... 981f790 [Qt] fix slot connection problems when no wallet is loaded (Philip Kaufmann)	2014-10-30 14:41:45 +01:00
Wladimir J. van der Laan	f157cbb443	Merge pull request #5142 ... 02fe12d Update generate-seeds.py to produce doxygen compatible comments (Michael Ford) f2e03ff Update comments in chainparams to be doxygen compatible (Michael Ford) 2fdc335 Update comments in chain to be doxygen compatible (Michael Ford)	2014-10-30 10:28:42 +01:00
Wladimir J. van der Laan	4bbcc8d0e7	Merge pull request #5148 ... 2b173d3 Update comments in keystore to be doxygen compatible (Michael Ford) ffd8edd Update comments in key to be doxygen compatible (Michael Ford)	2014-10-30 10:09:23 +01:00
Philip Kaufmann	981f7907c4	[Qt] fix slot connection problems when no wallet is loaded ... - guard 4 connect calls by an #ifdef when no wallet is loaded to fix "No such slot" warnings - also add comments when #ifdef ENABLE_WALLET end - fixes #5175	2014-10-30 09:31:36 +01:00
Michael Ford	7792040294	Update comments in rpcserver to be doxygen compatible	2014-10-30 10:14:08 +08:00
Matt Corallo	eadcd0c802	Print parameter interactions to console, too	2014-10-29 19:10:00 -07:00
Luke Dashjr	e69a5873e7	RPC: submitblock: Support for returning specific rejection reasons	2014-10-30 02:03:43 +00:00
Luke Dashjr	b468e81443	Qt: Clarify sign/verify dialog text to specifically state that these messages only prove one receives with the address in question, and makes no claim to sender of transactions	2014-10-30 01:36:50 +00:00
Matt Corallo	50b43fda08	Be a bit more verbose during -loadblock if we already have blocks	2014-10-29 17:02:48 -07:00
Matt Corallo	8375e2215f	Fix -loadblock after shutdown during IBD	2014-10-29 17:01:18 -07:00
Matt Corallo	4ead850fe5	Fix for crash during block download	2014-10-29 17:01:01 -07:00
jtimon	092b58d13d	CBlockIndex::GetBlockWork() + GetProofIncrement(nBits) -> GetBlockProof(CBlockIndex)	2014-10-29 21:01:07 +01:00
jtimon	22c4272bf4	MOVEONLY: Move void UpdateTime() from pow.o to miner.o (plus fix include main.h -> chain.h)	2014-10-29 21:00:05 +01:00
Pieter Wuille	b4ee0bddad	Introduce preferred download peers	2014-10-29 08:08:13 -07:00
Wladimir J. van der Laan	20a5f610d3	Don't relay alerts to peers before version negotiation ... Fixes #1436	2014-10-29 16:05:46 +01:00
Matt Corallo	2d06c0febf	Add missing reserved address spaces.	2014-10-28 23:54:39 -07:00
Cory Fields	71697f97d3	Separate protocol versioning from clientversion	2014-10-29 00:24:40 -04:00
Ruben Dario Ponticelli	a2d0fc658a	Fix IsInitialBlockDownload which was broken by headers first.	2014-10-28 18:16:52 -03:00
Wladimir J. van der Laan	023e63df78	qt: Move transaction notification to transaction table model ... Move transaction new/update notification to TransactionTableModel. This moves the concerns to where they're actually handled. No need to bounce this through wallet model. - Do wallet transaction preprocessing on signal handler side; avoids locking cs_main/cs_wallet on notification in GUI thread (except for new transactions)	2014-10-28 21:20:55 +01:00
Pieter Wuille	723c752636	Merge pull request #5100 ... 99f41b9 MOVEONLY: core.o -> core/block.o (jtimon) 561e9e9 MOVEONLY: Move script/compressor out of script and put CTxOutCompressor (from core) with it (jtimon) 999a2ab MOVEONLY: separate CTxUndo out of core (jtimon) 4a3587d MOVEONLY: Separate CTransaction and dependencies from core (jtimon) eda3733 MOVEONLY: Move CFeeRate and Amount constants to amount.o (jtimon)	2014-10-28 05:27:41 -07:00
Wladimir J. van der Laan	cd9114e513	Merge pull request #5065 ... 16d78bd Add valid invert of invalid every numeric opcode tests (Peter Todd) 2b62e17 Clearly separate PUSHDATA and numeric argument MINIMALDATA tests (Peter Todd) dfeec18 Test every numeric-accepting opcode for correct handling of the numeric minimal encoding rule (Peter Todd) 554147a Ensure MINIMALDATA invalid tests can only fail one way (Peter Todd) 6004e77 Improve CScriptNum() comment (Peter Todd) 698c6ab Add SCRIPT_VERIFY_MINIMALDATA (BIP62 rules 3 and 4) (Pieter Wuille) d752ba8 Add SCRIPT_VERIFY_SIGPUSHONLY (BIP62 rule 2) (Pieter Wuille)	2014-10-28 13:19:38 +01:00
Luke Dashjr	1bea2bbddc	Rename ProcessBlock to ProcessNewBlock to indicate change of behaviour, and document it	2014-10-28 08:15:14 +00:00
Michael Ford	2b173d3bcc	Update comments in keystore to be doxygen compatible	2014-10-28 12:06:59 +08:00
Michael Ford	ffd8eddab5	Update comments in key to be doxygen compatible	2014-10-28 12:02:25 +08:00
Michael Ford	5b40d88688	Update comments in wallet to be doxygen compatible	2014-10-28 11:47:49 +08:00
Pieter Wuille	068b7f8ee2	Merge pull request #5118 ... 50f71cd boost: code movement only: split CECKey into separate files (Cory Fields) bdaec6a boost: remove CPubKey dependency from CECKey. Follow-up of e405aa48 (Cory Fields)	2014-10-27 20:47:32 -07:00
Cory Fields	50f71cd52e	boost: code movement only: split CECKey into separate files	2014-10-27 15:00:58 -04:00
Cory Fields	bdaec6abd3	boost: remove CPubKey dependency from CECKey. Follow-up of e405aa48	2014-10-27 14:39:32 -04:00
Gavin Andresen	35ece7dd07	Merge pull request #5135 ... a31e8ba Make CBlockIndex* returned by GetDepthInMainChain const. (Daniel Kraft) Signed-off-by: Gavin Andresen <gavinandresen@gmail.com>	2014-10-27 13:42:01 -04:00
jtimon	99f41b9cf7	MOVEONLY: core.o -> core/block.o	2014-10-27 13:54:37 +01:00
jtimon	561e9e9de9	MOVEONLY: Move script/compressor out of script and put CTxOutCompressor (from ... core) with it	2014-10-27 13:54:37 +01:00
jtimon	999a2ab41e	MOVEONLY: separate CTxUndo out of core	2014-10-27 13:54:37 +01:00
jtimon	4a3587d8db	MOVEONLY: Separate CTransaction and dependencies from core	2014-10-27 13:54:37 +01:00
jtimon	eda3733091	MOVEONLY: Move CFeeRate and Amount constants to amount.o	2014-10-27 13:54:37 +01:00
jtimon	071473c55c	Build util and common before building server	2014-10-27 13:34:25 +01:00
Wladimir J. van der Laan	1bd8a7b2b9	Merge pull request #5086 ... 1723862 build: fix libtool's refusal to link static libs into a dll (Cory Fields) 28d412f build: quit abusing LIBS for Windows builds. (Cory Fields)	2014-10-27 12:28:02 +01:00
Pieter Wuille	60abd463ac	Merge pull request #5119 ... fa73619 boost: split stream classes out of serialize.h (Cory Fields)	2014-10-27 04:16:48 -07:00
Wladimir J. van der Laan	d9702bcf7c	Merge pull request #5115 ... 33dfbf5 rpc: Fix leveldb iterator leak, and flush before `gettxoutsetinfo` (Wladimir J. van der Laan)	2014-10-27 11:05:20 +01:00
Luke Dashjr	2aa632921e	Enable customising node policy for datacarrier data size with a -datacarriersize option	2014-10-27 09:41:57 +00:00
Wladimir J. van der Laan	2ffdf21ce3	Merge pull request #5134 ... 6261e6e getblockhash: throw JSONRPCError (not runtime_error) (dexX7)	2014-10-27 10:18:26 +01:00
Peter Todd	16d78bd68e	Add valid invert of invalid every numeric opcode tests	2014-10-25 03:13:15 -07:00
Peter Todd	2b62e1796b	Clearly separate PUSHDATA and numeric argument MINIMALDATA tests	2014-10-25 03:12:39 -07:00
Peter Todd	dfeec18b85	Test every numeric-accepting opcode for correct handling of the numeric minimal encoding rule	2014-10-25 03:12:06 -07:00
Peter Todd	554147ad9e	Ensure MINIMALDATA invalid tests can only fail one way ... Removes the need for the 'negated' versions of the tests, and ensures other failures don't mask what we're trying to test.	2014-10-25 03:11:38 -07:00
Peter Todd	6004e77b92	Improve CScriptNum() comment ... Edited-by: Pieter Wuille <pieter.wuille@gmail.com>	2014-10-25 03:03:20 -07:00
Pieter Wuille	698c6abb25	Add SCRIPT_VERIFY_MINIMALDATA (BIP62 rules 3 and 4) ... Also use the new flag as a standard rule, and replace the IsCanonicalPush standardness check with it (as it is more complete).	2014-10-25 03:03:20 -07:00
Pieter Wuille	d752ba86c1	Add SCRIPT_VERIFY_SIGPUSHONLY (BIP62 rule 2)	2014-10-25 03:03:16 -07:00
Pieter Wuille	65e4e8427d	Merge pull request #5093 ... 4b0e2d7 Squashed 'src/leveldb/' changes from 7924331..7d41e6f (Pieter Wuille)	2014-10-25 02:39:56 -07:00
Michael Ford	f2e03ffae9	Update comments in chainparams to be doxygen compatible	2014-10-25 17:24:16 +08:00
Michael Ford	2fdc3351d7	Update comments in chain to be doxygen compatible	2014-10-25 16:46:54 +08:00
Wladimir J. van der Laan	b847e0139e	Merge pull request #5131 ... 24f5c94 Update comments in addrman to be doxygen compatible (Michael Ford) c772f4c Add doc/doxygen to .gitignore (Michael Ford)	2014-10-25 09:10:40 +02:00
Wladimir J. van der Laan	5c85fde550	Merge pull request #5117 ... 7014f38 [Qt] Remove CAmount from BitcoinAmountField Q_PROPERTY (Cozz Lovan)	2014-10-25 08:36:26 +02:00
Cozz Lovan	7014f382e3	[Qt] Remove CAmount from BitcoinAmountField Q_PROPERTY	2014-10-24 23:43:27 +02:00
dexX7	6261e6e6e0	getblockhash: throw JSONRPCError (not runtime_error)	2014-10-24 19:18:03 +02:00
Daniel Kraft	a31e8bad53	Make CBlockIndex* returned by GetDepthInMainChain const. ... Make the CBlockIndex* (optionally) returned by GetDepthInMainChain const. This prevents accidental modification. The result is for reading its properties rather than modifying it.	2014-10-24 16:13:41 +02:00
Michael Ford	24f5c94015	Update comments in addrman to be doxygen compatible ... Also correct the file license	2014-10-24 15:45:27 +08:00
Wladimir J. van der Laan	7c0f36c431	Clear vFixedSeeds for regtest network ... It shouldn't inherit these from testnet. (seems to be already done for unit test network but forgotten here...) Fixes #5127.	2014-10-24 09:34:55 +02:00
Cory Fields	3a757c5294	fix build with libc++ after 85c579e	2014-10-23 14:24:22 -04:00
Wladimir J. van der Laan	d2833de424	qt: remove monitoreddatamapper ... We haven't used the viewModified signal in ages, so we can use a normal QDataWidgetMapper.	2014-10-23 19:09:34 +02:00
Cory Fields	fa7361907a	boost: split stream classes out of serialize.h ... serialization now has no dependencies.	2014-10-22 15:21:06 -04:00
Wladimir J. van der Laan	25cc1cf8dc	Merge pull request #4981 ... 85c579e script: add a slew of includes all around and drop includes from script.h (Cory Fields) db8eb54 script: move ToString and ValueString out of the header (Cory Fields) e9ca428 script: add ToByteVector() for converting anything with begin/end (Cory Fields) 066e2a1 script: move CScriptID to standard.h and add a ctor for creating them from CScripts (Cory Fields)	2014-10-22 12:16:50 +02:00
Wladimir J. van der Laan	13bddef870	Merge pull request #4988 ... 7b2bb96 Replace some function names with __func__ (Pieter Wuille) ed6d1a2 Keep information about all block files in memory (Pieter Wuille)	2014-10-22 12:06:03 +02:00
Wladimir J. van der Laan	f984c7d7ad	Merge pull request #5108 ... a873823 CAutoFile: Explicit Get() and remove unused methods (Wladimir J. van der Laan) fef24ca Add IsNull() to class CAutoFile and remove operator ! (Ruben Dario Ponticeli)	2014-10-22 10:47:14 +02:00
Wladimir J. van der Laan	7305620599	Merge pull request #5110 ... a3c26c2 Fixes for missing boost tuple.hpp header include. (randy-waterhouse)	2014-10-22 10:37:52 +02:00
Wladimir J. van der Laan	93cb689e52	Merge pull request #5104 ... b7ae2c1 Chain::SetTip return type to void (21E14)	2014-10-22 10:24:16 +02:00
Wladimir J. van der Laan	a873823864	CAutoFile: Explicit Get() and remove unused methods ... Also add documentation to some methods.	2014-10-22 10:18:19 +02:00
Pieter Wuille	7b2bb96271	Replace some function names with __func__	2014-10-21 16:17:13 -07:00
Wladimir J. van der Laan	33dfbf57d3	rpc: Fix leveldb iterator leak, and flush before gettxoutsetinfo ... This fixes an iterator leak resulting in bitcoind: db/version_set.cc:789: leveldb::VersionSet::~VersionSet(): Assertion `dummy_versions_.next_ == &dummy_versions_' failed." exception on shutdown. Also make sure to flush pcoinsTip before calling GetStats() to make sure we apply them to the current height.	2014-10-21 16:16:55 +02:00
Wladimir J. van der Laan	9acbb4180a	qt: small English language updates from translators ... More friendly language, use placeholders where possible	2014-10-21 15:40:43 +02:00
Wladimir J. van der Laan	6d3ab8564c	qt: English translation update after 0a08aa8	2014-10-21 14:55:45 +02:00
Wladimir J. van der Laan	5f3ea3362a	Merge pull request #5076 ... c0195b1 Bugfix: Remove default from -zapwallettxes description (inaccurate) (Luke Dashjr) 0a08aa8 Parameterise command line option defaults, so translations are independent of them (Luke Dashjr)	2014-10-21 14:53:55 +02:00
Wladimir J. van der Laan	b88cb1a96e	Merge pull request #5105 ... a96d113 Rename CWalletInterface to CValidationInterface (Pieter Wuille)	2014-10-21 11:56:10 +02:00
Luke Dashjr	d29a2917ff	Rename RPC_TRANSACTION_* errors to RPC_VERIFY_* and use RPC_VERIFY_ERROR for submitblock	2014-10-21 04:48:31 +00:00
Luke Dashjr	f877aaaf16	Bugfix: submitblock: Use a temporary CValidationState to determine accurately the outcome of ProcessBlock, now that it no longer does the full block validity check	2014-10-21 04:48:31 +00:00
Luke Dashjr	24e8896430	Add CValidationInterface::BlockChecked notification	2014-10-21 04:41:46 +00:00
randy-waterhouse	a3c26c2e85	Fixes for missing boost tuple.hpp header include.	2014-10-21 17:33:06 +13:00
21E14	b7ae2c172a	Chain::SetTip return type to void	2014-10-20 17:56:19 -04:00
Pieter Wuille	a96d113962	Rename CWalletInterface to CValidationInterface ... It's useful for much more than wallets.	2014-10-20 10:59:12 -07:00
Ruben Dario Ponticeli	fef24cab1a	Add IsNull() to class CAutoFile and remove operator !	2014-10-20 12:46:56 +02:00
Wladimir J. van der Laan	64ffc995d6	Merge pull request #5095 ... d4746d5 Add a SECURE style flag for ThreadSafeMessageBox, which indicates that the message contains sensitive information. This keeps the message from being output to the debug log by bitcoind. Fixes a possible security risk when starting bitcoind in server mode without the 'rpcpassword' option configured, resulting in the "suggested" password being output to the debug log. (Mark Friedenbach)	2014-10-20 11:36:40 +02:00
Cory Fields	85c579e3a6	script: add a slew of includes all around and drop includes from script.h ... Lots of files ended up with indirect includes from script.h.	2014-10-17 13:44:57 -04:00
Cory Fields	db8eb54bd7	script: move ToString and ValueString out of the header	2014-10-17 13:44:14 -04:00
Cory Fields	e9ca4280f3	script: add ToByteVector() for converting anything with begin/end ... This should move to a util header once their dependencies are cleaned up.	2014-10-17 13:44:14 -04:00
Cory Fields	066e2a1403	script: move CScriptID to standard.h and add a ctor for creating them from CScripts ... This allows for a reversal of the current behavior. This: CScript foo; CScriptID bar(foo.GetID()); Becomes: CScript foo; CScriptID bar(foo); This way, CScript is no longer dependent on CScriptID or Hash();	2014-10-17 13:44:14 -04:00
Wladimir J. van der Laan	84d13eef88	Merge pull request #4468 ... e11b2ce Fix large reorgs (Pieter Wuille) afc32c5 Fix rebuild-chainstate feature and improve its performance (Pieter Wuille) 16d5194 Skip reindexed blocks individually (Pieter Wuille) ad96e7c Make -reindex cope with out-of-order blocks (Wladimir J. van der Laan) e17bd58 Rename setBlockIndexValid to setBlockIndexCandidates (Pieter Wuille) 1af838b Add height to "Requesting block" debug (R E Broadley) 1bcee67 Better logging of stalling (R E Broadley) 4c93322 Improve getheaders (sending) logging (R E Broadley) f244c99 Remove CheckMinWork, as we always know all parent headers (Pieter Wuille) ad6e601 RPC additions after headers-first (Pieter Wuille) 341735e Headers-first synchronization (Pieter Wuille)	2014-10-17 12:30:54 +02:00
Wladimir J. van der Laan	971a3b46a3	Merge pull request #5092 ... 6f155bd Add LIBTOOLFLAGS CXX tag to qt makefile include (Michael Ford)	2014-10-17 10:24:56 +02:00
Mark Friedenbach	d4746d56c0	Add a SECURE style flag for ThreadSafeMessageBox, which indicates that the message contains sensitive information. This keeps the message from being output to the debug log by bitcoind. Fixes a possible security risk when starting bitcoind in server mode without the 'rpcpassword' option configured, resulting in the "suggested" password being output to the debug log.	2014-10-17 00:33:31 -07:00
Wladimir J. van der Laan	494ff05a4c	Merge pull request #4804 from jtimon/chainparams3 ... Remove CBaseChainParams::NetworkID()	2014-10-17 08:47:11 +02:00
jtimon	e8ea0fd19e	MOVEONLY: CInPoint from core to txmempool	2014-10-17 01:58:43 +02:00
jtimon	ca3ce0fa03	squashme on 3fdb9e8c (Bluematt's bikeshedding)	2014-10-16 22:49:33 +02:00
Pieter Wuille	5b9f8425a5	Merge src/leveldb changes for LevelDB 1.18.	2014-10-16 12:23:50 -07:00
Michael Ford	6f155bdb80	Add LIBTOOLFLAGS CXX tag to qt makefile include ... Related #4993	2014-10-16 19:50:49 +08:00
Cory Fields	5f4bcf6b14	boost: drop boost dependency in version.cpp. ... Also add a test to verify.	2014-10-15 15:13:20 -04:00
Cory Fields	352058e8b0	boost: drop boost dependency in utilstrencodings.cpp	2014-10-15 15:13:20 -04:00
Cory Fields	e1c9467766	boost: drop boost dependency in core.cpp	2014-10-15 15:13:20 -04:00
Cory Fields	e405aa48c7	boost: remove CPrivKey dependency from CECKey ... This allows CECKey to be used without directly depending on the secure allocators	2014-10-15 15:13:20 -04:00
Cory Fields	52955068b7	boost: drop dependency on tuple in serialization ... There's only one user of this form of serialization, so it can be easily dropped. It could be re-added if desired when we switch to c++11.	2014-10-15 15:13:19 -04:00
Cory Fields	1d9b86d584	boost: drop dependency on is_fundamental in serialization ... There's only one case where a vector containing a fundamental type is serialized all-at-once, unsigned char. Anything else would lead to strange results. Use a dummy argument to overload in that case.	2014-10-15 15:13:19 -04:00
Pieter Wuille	e11b2ce4c6	Fix large reorgs	2014-10-14 16:13:42 -07:00
Pieter Wuille	afc32c5eea	Fix rebuild-chainstate feature and improve its performance ... Previous refactorings broke the ability to rebuild the chainstate by deleting the chainstate directory, resulting in an incorrect "Incorrect or no genesis block found" error message. Fix that. Also, improve the performance of ActivateBestBlockStep by using the skiplist to only discover a few potential blocks to connect at a time, instead of all blocks forever - as we likely bail out after connecting a single one anyway.	2014-10-14 15:42:01 -07:00
Pieter Wuille	16d5194165	Skip reindexed blocks individually ... Instead of skipping to the last reindexed block in each file (which could jump over processed out-of-order blocks), just skip each already processed block individually.	2014-10-14 15:42:01 -07:00
Wladimir J. van der Laan	ad96e7ccd9	Make -reindex cope with out-of-order blocks ... Remember out-of-order block headers along with disk positions. This is likely the simplest and least-impact way to make -reindex work with headers first. Based on top of #4468.	2014-10-14 15:42:01 -07:00
Pieter Wuille	e17bd58392	Rename setBlockIndexValid to setBlockIndexCandidates	2014-10-14 15:42:01 -07:00
R E Broadley	1af838b339	Add height to "Requesting block" debug	2014-10-14 15:42:01 -07:00
R E Broadley	1bcee67ee7	Better logging of stalling	2014-10-14 15:42:01 -07:00
R E Broadley	4c93322923	Improve getheaders (sending) logging	2014-10-14 15:42:01 -07:00
Pieter Wuille	f244c99c96	Remove CheckMinWork, as we always know all parent headers	2014-10-14 15:42:01 -07:00
Pieter Wuille	ad6e601712	RPC additions after headers-first	2014-10-14 15:42:01 -07:00
Pieter Wuille	341735eb8f	Headers-first synchronization ... Many changes: * Do not use 'getblocks', but 'getheaders', and use it to build a headers tree. * Blocks are fetched in parallel from all available outbound peers, using a limited moving window. When one peer stalls the movement of the window, it is disconnected. * No more orphan blocks. At all. We only ever request a block for which we have verified the headers, and store it to disk immediately. This means that a disk-fill attack would require PoW. * Require protocol version 31800 for every peer (released in december 2010). * No more syncnode (we sync from everyone we can, though limited to 1 during initial *headers* sync). * Introduce some extra named constants, comments and asserts.	2014-10-14 15:42:01 -07:00
Luke Dashjr	c0195b1c31	Bugfix: Remove default from -zapwallettxes description (inaccurate)	2014-10-14 20:13:44 +00:00
Wladimir J. van der Laan	992ab87114	Merge pull request #4942 ... 9406471 Write fee estimate and peers files only when initialized (Wladimir J. van der Laan)	2014-10-14 11:35:17 +02:00
Cory Fields	28d412ff20	build: quit abusing LIBS for Windows builds. ... Similar to the INCLUDES changes in 6b099402b4, split out LIBS into individual entries for more fine-grained control. Also add MINIUPNPC_LIBS which was missing before, and hook it up to executables.	2014-10-13 21:21:27 -04:00
Luke	e21b2e0d5f	Typo in test	2014-10-13 16:57:09 +01:00
Peter Todd	ba7fcc8de0	Discourage fee sniping with nLockTime	2014-10-13 08:18:06 -04:00
Wladimir J. van der Laan	d7e1950483	Merge pull request #4937 ... ccca27a [Wallet] Watch-only fixes (Cozz Lovan)	2014-10-13 13:57:07 +02:00
jtimon	ebdb9ff639	SQUASHME: fix "Reserve only one network specific cached path per session"	2014-10-11 20:56:27 +02:00
Luke Dashjr	0a08aa8f2a	Parameterise command line option defaults, so translations are independent of them	2014-10-11 08:22:26 +00:00
Cory Fields	d5fd094569	build: fix qt test build when libprotobuf is in a non-standard path	2014-10-10 13:03:28 -04:00
jtimon	b796cb084b	SQUASHME: NetworkIdFromCommandLine() function instead of method	2014-10-10 12:05:20 +02:00
Wladimir J. van der Laan	023690c0f2	Merge pull request #4802 ... 6fd546d Remove CChainParams::NetworkID() (jtimon) cc97210 Add fTestnetToBeDeprecatedFieldRPC to CChainParams (jtimon) e11712d Move checkpoint data selection to chainparams (jtimon) 6de50c3 qt: add network-specific style object (Wladimir J. van der Laan)	2014-10-10 11:56:58 +02:00
jtimon	6fd546dd96	Remove CChainParams::NetworkID()	2014-10-10 11:01:00 +02:00
jtimon	cc97210799	Add fTestnetToBeDeprecatedFieldRPC to CChainParams	2014-10-10 11:01:00 +02:00
jtimon	e11712df7e	Move checkpoint data selection to chainparams	2014-10-10 11:00:59 +02:00
Wladimir J. van der Laan	6de50c3c9a	qt: add network-specific style object ... Mainly cleanups: Gets rid of isTestNet everywhere, by keeping track of network-specific theming in a central place. Also makes GUI no longer dependent on the network ID enumeration, which alleviates concerns about #4802.	2014-10-10 11:00:59 +02:00
Wladimir J. van der Laan	fe36e031cd	Merge pull request #5032 ... 4bd1185 Qt: allow "emergency" shutdown during startup (Philip Kaufmann)	2014-10-09 18:10:29 +02:00
Gavin Andresen	3222802ea1	Merge pull request #5059 ... dbca89b Trigger -alertnotify if network is upgrading without you (Gavin Andresen) e01a793 Refactor -alertnotify code (Gavin Andresen) Signed-off-by: Gavin Andresen <gavinandresen@gmail.com>	2014-10-09 10:39:29 -04:00
Gavin Andresen	dbca89b74b	Trigger -alertnotify if network is upgrading without you ... This adds a -regetest-only undocumented (for regression testing only) command-line option -blockversion=N to set block.nVersion. Adds to the "has the rest of the network upgraded to a block.nVersion we don't understand" code so it calls -alertnotify when 51 of the last 100 blocks are up-version. But it only alerts once, not with every subsequent new, upversion block. And adds a forknotify.py regression test to make sure it works. Tested using forknotify.py: Before adding CAlert::Notify, get: Assertion failed: -alertnotify did not warn of up-version blocks Before adding code to only alert once: Assertion failed: -alertnotify excessive warning of up-version blocks After final code in this pull: Tests successful	2014-10-09 10:28:27 -04:00
Gavin Andresen	e01a7939d3	Refactor -alertnotify code ... Refactor common -alertnotify code into static CAlert::Notify method.	2014-10-09 10:25:30 -04:00
Pieter Wuille	dec58922d0	Merge pull request #4996 ... d0c4197 change exit(1) to an assert in CWallet::EncryptWallet (Philip Kaufmann) 870da77 fix possible memory leaks in CWallet::EncryptWallet (Philip Kaufmann) f606bb9 fix a possible memory leak in CWalletDB::Recover (Philip Kaufmann)	2014-10-08 15:51:32 -07:00
Pieter Wuille	9df9cf5a9f	Make SCRIPT_VERIFY_STRICTENC compatible with BIP62 ... * Delete canonical_tests.cpp, and move the tests to script_tests.cpp. * Split off SCRIPT_VERIFY_DERSIG from SCRIPT_VERIFY_STRICTENC (the BIP62 part of it). * Change signature STRICTENC/DERSIG semantics to fail the script entirely rather than the CHECKSIG result (softfork safety, and BIP62 requirement). * Add many autogenerated tests for several odd cases. * Mention specific BIP62 rules in the script verification flags.	2014-10-08 15:42:29 -07:00
Pieter Wuille	d4a42334d4	Merge pull request #4834 ... 7c70438 Get rid of the dummy CCoinsViewCache constructor arg (Pieter Wuille) ed27e53 Add coins_tests with a large randomized CCoinViewCache test. (Pieter Wuille) 058b08c Do not keep fully spent but unwritten CCoins entries cached. (Pieter Wuille) c9d1a81 Get rid of CCoinsView's SetCoins and SetBestBlock. (Pieter Wuille) f28aec0 Use ModifyCoins instead of mutable GetCoins. (Pieter Wuille)	2014-10-08 14:58:16 -07:00
Wladimir J. van der Laan	6860a55ea0	Merge pull request #4979 ... de10efd add -timeout default as constant and use them (Philip Kaufmann)	2014-10-08 09:16:19 +02:00
Wladimir J. van der Laan	ad9cd64d3b	Merge pull request #5055 ... 2c930d9 Prettify JSON tests and minimize diffs (Pieter Wuille)	2014-10-08 09:12:39 +02:00
Wladimir J. van der Laan	7c6cbff0e5	Merge pull request #4976 ... 27c3e91 qt: add proxy to options overridden if necessary. (Cory Fields)	2014-10-07 12:33:45 +02:00
Wladimir J. van der Laan	3eaa9462f8	Merge pull request #5047 ... 3e61eb9 minor txindex documentation improvement (Cozz Lovan)	2014-10-07 10:17:05 +02:00
Pieter Wuille	2c930d932b	Prettify JSON tests and minimize diffs	2014-10-07 09:41:33 +02:00
Wladimir J. van der Laan	953f16cb4e	Merge pull request #4954 ... 9d7cd4c Don't return an address for invalid pubkeys (Andy Alness)	2014-10-07 08:51:20 +02:00
Andy Alness	9d7cd4c598	Don't return an address for invalid pubkeys	2014-10-06 21:54:34 -04:00
Cozz Lovan	3e61eb9c51	minor txindex documentation improvement	2014-10-06 18:52:51 +02:00
Philip Kaufmann	de10efd154	add -timeout default as constant and use them ... - update help message text - simplify code in init to check for -timeout	2014-10-06 13:13:25 +02:00
Philip Kaufmann	4dc5eb057c	fix a lock indentation in main.cpp ... - also ensure alphabetical ordering in file header	2014-10-06 13:04:02 +02:00
Philip Kaufmann	5eed8c21c7	minor license, header end comment etc. cleanup in /script ... - ensure all licenses are just MIT - add a missing header end comment - ensure alphabetical ordering	2014-10-06 13:00:55 +02:00
Pieter Wuille	ed6d1a2c7b	Keep information about all block files in memory	2014-10-06 07:32:00 +02:00
Wladimir J. van der Laan	5505a1b13f	Merge pull request #5036 ... eb6b3b2 Update English translation (Wladimir J. van der Laan) b9b2e3f Don't translate state.Abort() messages (Wladimir J. van der Laan)	2014-10-06 04:42:09 +02:00
Wladimir J. van der Laan	5f1aee066a	Merge pull request #4890 ... e790c37 Replace SCRIPT_VERIFY_NOCACHE by flag directly to checker (Pieter Wuille) 5c1e798 Make signature cache optional (Pieter Wuille) c7829ea Abstract out SignatureChecker (Pieter Wuille)	2014-10-06 04:39:17 +02:00
Wladimir J. van der Laan	cd91ed4f5f	Merge pull request #4982 ... b5ec5fe update getnetworkinfo help with subversion (Philip Kaufmann)	2014-10-03 15:27:58 +02:00
Cozz Lovan	44bc988e7b	[Wallet] Do not flush the wallet in AddToWalletIfInvolvingMe(..)	2014-10-03 05:11:27 +02:00
Pieter Wuille	5ccd735d30	Merge pull request #4887 ... 4bb30a1 Correct logging AcceptBlock()->AcceptBlockHeader() (R E Broadley)	2014-10-03 04:31:44 +02:00
Cozz Lovan	ccca27a788	[Wallet] Watch-only fixes	2014-10-03 04:29:51 +02:00
Wladimir J. van der Laan	29f96e8bc6	Merge pull request #4994 ... 54510f2 DRY: Avoid repetitions in script_test (jtimon)	2014-10-02 22:41:54 +02:00
Wladimir J. van der Laan	0e64566a82	Merge pull request #4978 ... 938bcce CAutoFile: make file private (Philip Kaufmann) 0c35486 CBufferedFile: add explicit close function (Philip Kaufmann) c9fb27d CBufferedFile: convert into a non-refcounted RAII wrapper (Philip Kaufmann)	2014-10-02 22:35:36 +02:00
Wladimir J. van der Laan	eb6b3b245c	Update English translation	2014-10-02 22:20:23 +02:00
Wladimir J. van der Laan	b9b2e3fabd	Don't translate state.Abort() messages ... There is only one message passed to AbortNode() that makes sense to translate to the user specifically: Disk space is low. For the others show a generic message and refer to debug.log for details. Reduces the number of confusing jargon translation messages.	2014-10-02 22:20:16 +02:00
jtimon	54510f2672	DRY: Avoid repetitions in script_test	2014-10-02 21:48:29 +02:00
Pieter Wuille	e790c370b5	Replace SCRIPT_VERIFY_NOCACHE by flag directly to checker	2014-10-02 20:26:58 +02:00
Pieter Wuille	5c1e798a8e	Make signature cache optional	2014-10-02 20:26:17 +02:00
Pieter Wuille	c7829ea797	Abstract out SignatureChecker	2014-10-02 20:26:16 +02:00
R E Broadley	4bb30a1eb8	Correct logging AcceptBlock()->AcceptBlockHeader()	2014-10-03 01:35:51 +08:00
Wladimir J. van der Laan	20a4b69360	Merge pull request #4985 ... bc470c4 Changed mixed indentation to four spaces (Eric Shaw) 31d6390 Fixed setaccount accepting foreign address (Eric Shaw)	2014-10-02 19:31:50 +02:00
Eric Shaw	bc470c43ee	Changed mixed indentation to four spaces ... Put `test/rpc_wallet_tests.cpp` through clang-format.	2014-10-02 19:23:30 +02:00
Eric Shaw	31d6390fd1	Fixed setaccount accepting foreign address ... Fixed issue #4209 where using setaccount with a foreign address causes the address to be added to your receiving addresses.	2014-10-02 19:21:46 +02:00
Wladimir J. van der Laan	45c41c05a0	Merge pull request #5030 ... fbd36d8 Avoid introducing a virtual into CChainParams (Wladimir J. van der Laan) f0fd00c Switch testing framework from MAIN to new UNITTEST network (SergioDemianLerner)	2014-10-02 15:28:27 +02:00
Wladimir J. van der Laan	fbd36d8fb5	Avoid introducing a virtual into CChainParams ... Treat fSkipProofOfWorkCheck the same as other parameters.	2014-10-02 13:54:26 +02:00
SergioDemianLerner	f0fd00cb77	Switch testing framework from MAIN to new UNITTEST network ... UNITTEST inherites from MAIN but allows synamically changing its parameters using the ModifiableParams() interface	2014-10-02 13:51:39 +02:00
Philip Kaufmann	4bd1185280	Qt: allow "emergency" shutdown during startup ... - allows closing our splash screen to abort startup	2014-10-02 11:26:36 +02:00
Philip Kaufmann	e2efdf3937	amount.h: update license, add header end comment + rem from util.h	2014-10-02 11:25:21 +02:00
Philip Kaufmann	938bccebf1	CAutoFile: make file private	2014-10-02 10:59:28 +02:00
Philip Kaufmann	0c35486dc9	CBufferedFile: add explicit close function ... - also use identical close function for CAutoFile (avoids setting file to NULL under wrong conditions)	2014-10-02 10:56:10 +02:00
Philip Kaufmann	c9fb27da0a	CBufferedFile: convert into a non-refcounted RAII wrapper ... - it now takes over the passed file descriptor and closes it in the destructor - this fixes a leak in LoadExternalBlockFile(), where an exception could cause the file to not getting closed - disallow copies (like recently added for CAutoFile) - make nType and nVersion private	2014-10-02 10:46:31 +02:00
Wladimir J. van der Laan	8d132431b4	Revert merge of pull #4845 ... It breaks the new mingw tests! See - https://travis-ci.org/bitcoin/bitcoin/jobs/36845581 - https://travis-ci.org/bitcoin/bitcoin/jobs/36845582 This reverts commit 4705902777, 5e2e7fcb99, a25fd6be13.	2014-10-02 10:39:55 +02:00
Wladimir J. van der Laan	ad51e14583	Merge pull request #4845 ... 4705902 Avoid introducing a virtual into CChainParams (Wladimir J. van der Laan) 5e2e7fc Suggested corrections on comments, variable names. Also new test case testing the PoW skip in UNITTEST. (SergioDemianLerner) a25fd6b Switch testing framework from MAIN to new UNITTEST network (SergioDemianLerner)	2014-10-02 09:47:54 +02:00
Wladimir J. van der Laan	00eef5d6e9	Merge pull request #5017 ... f74fc9b Print input index when signature validation fails, to aid debugging. (Mark Friedenbach) 217a5c9 When transaction outputs exceed inputs, show the offending amounts so as to aid debugging. (Mark Friedenbach)	2014-10-02 08:44:08 +02:00
Pieter Wuille	76c171033c	Merge pull request #4926 ... 584a358 Do merkle root and txid duplicates check simultaneously (Pieter Wuille)	2014-10-02 06:10:19 +02:00
Pieter Wuille	471d38b015	Merge pull request #4980 ... 20a11ff minor variable init changes in init.cpp (Philip Kaufmann)	2014-10-02 04:29:01 +02:00
Mark Friedenbach	f74fc9b22d	Print input index when signature validation fails, to aid debugging.	2014-10-01 19:14:38 +02:00
Mark Friedenbach	217a5c9238	When transaction outputs exceed inputs, show the offending amounts so as to aid debugging.	2014-10-01 19:14:38 +02:00
Wladimir J. van der Laan	1fbccda8d0	Merge pull request #4940 ... 62e5f8f CMessageHeader sanity changes (Wladimir J. van der Laan)	2014-10-01 13:28:16 +02:00
Wladimir J. van der Laan	a419f82670	Merge pull request #5022 ... c375b5c remove dead/unused code in walletdb.cpp (Philip Kaufmann)	2014-10-01 12:56:11 +02:00
Wladimir J. van der Laan	3fd192f8b4	Merge pull request #4234 ... c122f55 qt: Register CAmount metatype (Wladimir J. van der Laan) a372168 Use a typedef for monetary values (Mark Friedenbach)	2014-10-01 11:28:55 +02:00
Wladimir J. van der Laan	c122f5528c	qt: Register CAmount metatype ... This allows sending the type over queued connections. Also normalize signal/slot names.	2014-10-01 11:06:41 +02:00
Philip Kaufmann	c375b5c102	remove dead/unused code in walletdb.cpp ... - closes #5021	2014-10-01 11:00:29 +02:00
Philip Kaufmann	b5ec5fe0cb	update getnetworkinfo help with subversion ... - add missing subversion field to getnetworkinfo help - fix style and format errors in help string - remove unneeded int casts	2014-10-01 10:23:00 +02:00
Wladimir J. van der Laan	a6f3e9d843	Merge pull request #5014 ... 41d67c7 tests: fix python test-runner for windows (Cory Fields)	2014-10-01 08:55:34 +02:00
Philip Kaufmann	d0c4197ef6	change exit(1) to an assert in CWallet::EncryptWallet	2014-10-01 08:50:24 +02:00
Philip Kaufmann	870da77da6	fix possible memory leaks in CWallet::EncryptWallet ... - add missing deletes for pwalletdbEncryption - add an assert before trying to reserve memory for pwalletdbEncryption - add a destructor to CWallet, which ensures deletion of pwalletdbEncryption on object destruction	2014-10-01 08:48:23 +02:00
Philip Kaufmann	f606bb9baf	fix a possible memory leak in CWalletDB::Recover ... - convert pdbCopy into a boost::scoped_ptr to ensure memory gets freed in all cases (e.g. after "ret > 0")	2014-10-01 08:48:22 +02:00
Gavin Andresen	e5836eb692	Merge pull request #5015 from theuni/win64test ... tests: fix false-positive under win64	2014-09-30 19:54:08 -04:00
Cory Fields	63c17613ab	tests: fix false-positive under win64 ... BN_ULONG isn't necessarily an unsigned long, as is the case on win64.	2014-09-30 18:16:14 -04:00
Cory Fields	41d67c78bf	tests: fix python test-runner for windows ... Windows needed a few fixups to get the tests running: 1. bitcoin-tx needs a file extension in Windows. Take this opportunity to add an env file, which pulls variables out of our build config. This can be extended as needed, for now it's very simple. 2. After #1, split the args out of the exec key in the test data. 3. Correct the line-endings from windows stdout	2014-09-30 16:26:22 -04:00
Pieter Wuille	a329097f92	Merge pull request #4990 ... 7bec6dd cleanup license and header end comment in chain.cpp/.h (Philip Kaufmann) 0db65d8 update license of compat and crypto (Philip Kaufmann)	2014-09-30 01:35:11 +02:00
Pieter Wuille	68af7d02cf	Fix vector out of bounds in script tests	2014-09-29 19:26:23 +02:00
Pieter Wuille	2884b9a4ae	Merge pull request #4960 ... 8138cbe Add automatic script test generation, and actual checksig tests (Pieter Wuille)	2014-09-29 18:36:04 +02:00
Wladimir J. van der Laan	4705902777	Avoid introducing a virtual into CChainParams ... Treat fSkipProofOfWorkCheck the same as other parameters.	2014-09-29 13:13:47 +02:00
SergioDemianLerner	5e2e7fcb99	Suggested corrections on comments, variable names. ... Also new test case testing the PoW skip in UNITTEST.	2014-09-29 13:03:23 +02:00
SergioDemianLerner	a25fd6be13	Switch testing framework from MAIN to new UNITTEST network ... UNITTEST inherites from MAIN but allows synamically changing its parameters using the ModifiableParams() interface	2014-09-29 13:03:22 +02:00
Wladimir J. van der Laan	41150d601d	Merge pull request #4970 ... 93e24dd travis: use debug for one build (Cory Fields) be6d87a script: don't read past the end (Cory Fields) a94496f tests: don't split an empty string (Cory Fields) 00522cd depends: disable reduced exports for debug builds (Cory Fields) 1f7fff2 depends: add docs for debug (Cory Fields) dc66ff5 depends: make LDFLAGS act like the other flags (Cory Fields) b1efba8 depends: give miniupnpc cppflags (Cory Fields) 1d154db depends: teach qt to honor debug/release (Cory Fields) 3b63df5 depends: boost: build for debug or release as requested (Cory Fields) 7e99df7 depends: make sure openssl sees cppflags (Cory Fields) f397304 depends: add debug/release flags for linux/osx/win (Cory Fields) 2027ad3 depends: add the debug/release concept to depends (Cory Fields)	2014-09-29 09:36:54 +02:00
Wladimir J. van der Laan	76182e7cb6	Merge pull request #4999 ... 775b7b8 LLu is standard, but not portable. use ULL (sinetek)	2014-09-29 09:35:47 +02:00
Philip Kaufmann	7bec6dd230	cleanup license and header end comment in chain.cpp/.h	2014-09-29 08:22:03 +02:00
Philip Kaufmann	0db65d8798	update license of compat and crypto ... - change license to be just MIT for all files in compat and crypto - also add missing header end comments - ensure default header include style	2014-09-29 08:21:11 +02:00
Pieter Wuille	bf3a5dd7f0	Merge pull request #4796 ... e8b5f0d Move CBlockIndex, CChain and related code out of main (jtimon) 6db83db Decouple CChain from mapBlockIndex (jtimon)	2014-09-29 06:06:57 +02:00
sinetek	775b7b8d70	LLu is standard, but not portable. use ULL	2014-09-28 18:22:44 -04:00
Mark Friedenbach	a372168e77	Use a typedef for monetary values	2014-09-26 15:42:04 -07:00
Pieter Wuille	8138cbea3c	Add automatic script test generation, and actual checksig tests	2014-09-26 21:58:48 +02:00
Pieter Wuille	64cfaf891f	Merge pull request #4986 ... 6eb67b0 autofile: Disallow by-value copies of CAutoFile (Cory Fields) eee030f autofile: don't copy CAutoFile by value (Cory Fields)	2014-09-26 20:31:18 +02:00
Pieter Wuille	610a3d3a1b	Merge pull request #4983 ... d14d7de SanitizeString: allow '(' and ')' (Wladimir J. van der Laan)	2014-09-26 19:36:08 +02:00
Pieter Wuille	c2db599c1f	Merge pull request #4977 ... cf42c36 Apply clang-format on crypto/* and compat/* (Pieter Wuille)	2014-09-26 19:31:18 +02:00
Cory Fields	6eb67b0ed2	autofile: Disallow by-value copies of CAutoFile ... One might assume that CAutoFile would be ref-counted so that a copied object would delay closing the underlying file until all copies have gone out of scope. Since that's not the case with CAutoFile, explicitly disable copying.	2014-09-26 13:27:40 -04:00
Cory Fields	eee030f6bc	autofile: don't copy CAutoFile by value	2014-09-25 19:25:19 -04:00
Cory Fields	27c3e91014	qt: add proxy to options overridden if necessary. ... If proxy is disabled in the gui but enabled via the command line, it needs to be added to the override list.	2014-09-25 17:47:32 -04:00
Cory Fields	be6d87aa60	script: don't read past the end	2014-09-25 14:56:26 -04:00
Cory Fields	a94496fbb6	tests: don't split an empty string	2014-09-25 14:56:26 -04:00
Wladimir J. van der Laan	4b2b78b9f2	Merge pull request #4969 ... cda45b5 Reinitializing list's begin iterator after few elements were erased from the head (ENikS)	2014-09-25 15:58:56 +02:00
ENikS	1e73504865	Fixing C4146 warning ... Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>	2014-09-25 15:24:36 +02:00
Philip Kaufmann	20a11ffabf	minor variable init changes in init.cpp ... - explicit init of pcoinsdbview and pwalletMain (even if not needed, as globals are init to NULL, it seems cleaner) - remove check if (pwalletMain) in Shutdown() as delete is valid even if pwalletMain is NULL	2014-09-25 13:49:49 +02:00
Wladimir J. van der Laan	d14d7deff0	SanitizeString: allow '(' and ')' ... '(' and ')' are valid in user agent strings, so should be reported as such in RPC `getpeerinfo`. Fixes #4537.	2014-09-25 12:45:46 +02:00
Wladimir J. van der Laan	b50e5fe099	Merge pull request #4968 ... 219372f script: Fix reference into empty vector run time exception (ENikS)	2014-09-25 11:48:33 +02:00
ENikS	219372f1dd	script: Fix reference into empty vector run time exception ... Edit by laanwj: `begin_ptr(sourcedata) + sourcedata.size()` -> `end_ptr(sourcedata)`	2014-09-25 11:46:52 +02:00
Wladimir J. van der Laan	375cb4c253	Merge pull request #4959 ... bb26e2c [Qt] minor changes in splashscreen.cpp (Philip Kaufmann)	2014-09-25 11:31:53 +02:00
Wladimir J. van der Laan	8152f4efd8	Merge pull request #4967 ... 459a2d2 Avoiding referencing elements of an empty vector (ENikS)	2014-09-25 11:31:10 +02:00
Wladimir J. van der Laan	82e370b4b0	Merge pull request #4782 ... 2e5361b remove code below asserts in limitedmap.h (fixes a ToDo) (Philip Kaufmann)	2014-09-25 11:21:43 +02:00
Wladimir J. van der Laan	29a9d4483e	Merge pull request #4966 ... c8063b5 Fixing out of bounds asses error (ENikS)	2014-09-25 10:21:01 +02:00
Jeff Garzik	ff36cbe8d0	RPC getnetworkinfo: export local node's client sub-version string	2014-09-25 10:09:21 +02:00
Philip Kaufmann	e6beedc496	[Qt] add more NULL pointer checks in bitcoingui ... - add missing checks for clientModel and optionsModel - small cleanups for an #ifdef on Mac - remove an unneeded else	2014-09-25 09:16:45 +02:00
Pieter Wuille	cf42c36e99	Apply clang-format on crypto/* and compat/*	2014-09-25 08:23:32 +02:00
Pieter Wuille	584a358997	Do merkle root and txid duplicates check simultaneously ... Move the txid duplicates check into BuildMerkleTree, where it can be done much more efficiently (without needing to build a full txid set to detect duplicates). The previous version (using the std::set<uint256> to detect duplicates) was also slightly too weak. A block mined with actual duplicate transactions (which is invalid, due to the inputs of the duplicated transactions being seen as double spends) would trigger the duplicates logic, resulting in the block not being stored on disk, and rerequested. This change fixes that by only triggering in the case of duplicated transactions that can actually result in an identical merkle root.	2014-09-24 19:17:02 +02:00
Pieter Wuille	7c70438dc6	Get rid of the dummy CCoinsViewCache constructor arg	2014-09-24 03:19:04 +02:00
ENikS	cda45b5131	Reinitializing list's begin iterator after few elements were erased from the head	2014-09-23 18:33:16 -04:00
Pieter Wuille	ed27e53c9b	Add coins_tests with a large randomized CCoinViewCache test.	2014-09-23 22:29:45 +02:00
Pieter Wuille	058b08c147	Do not keep fully spent but unwritten CCoins entries cached. ... Instead of storing CCoins entries directly in CCoinsMap, store a CCoinsCacheEntry which additionally keeps track of whether a particular entry is: * dirty: potentially different from its parent view. * fresh: the parent view is known to not have a non-pruned version. This allows us to skip non-dirty cache entries when pushing batches of changes up, and to remove CCoins entries about transactions that are fully spent before the parent cache learns about them.	2014-09-23 22:29:43 +02:00
Pieter Wuille	c9d1a81ce7	Get rid of CCoinsView's SetCoins and SetBestBlock. ... All direct modifications are now done through ModifyCoins, and BatchWrite is used for pushing batches of queued modifications up, so we don't need the low-level SetCoins and SetBestBlock anymore in the top-level CCoinsView class.	2014-09-23 22:29:21 +02:00
Pieter Wuille	f28aec014e	Use ModifyCoins instead of mutable GetCoins. ... Replace the mutable non-copying GetCoins method with a ModifyCoins, which returns an encapsulated iterator, so we can keep track of concurrent modifications (as iterators can be invalidated by those) and run cleanup code after a modification is finished. This also removes the overloading of the 'GetCoins' name.	2014-09-23 22:29:12 +02:00
Pieter Wuille	7a04f3d708	Merge pull request #4955 ... 87314c1 Fixing improper input syntax and failing bounds check (ENikS)	2014-09-23 20:20:58 +02:00
ENikS	459a2d25e0	Avoiding referencing elements of an empty vector	2014-09-23 11:54:12 -04:00
ENikS	c8063b5712	Fixing out of bounds asses error	2014-09-23 11:17:43 -04:00
Wladimir J. van der Laan	35ee2dac67	Merge pull request #4949 ... c8589bf Add actual signature tests (Pieter Wuille) 76ec867 Use actually valid transactions for script tests (Pieter Wuille)	2014-09-23 13:14:19 +02:00
Peter Todd	426a74ed3c	Add scriptPubKey field to validateaddress RPC call	2014-09-23 05:24:27 -04:00
ENikS	6f3ae9b5df	Fixing out of bounds error in GetKey()	2014-09-23 10:45:04 +02:00
Philip Kaufmann	bb26e2c896	[Qt] minor changes in splashscreen.cpp ... - guard an unused variable with Q_UNUSED() macro - remove a commented out line of code	2014-09-23 09:56:46 +02:00
Pieter Wuille	c8589bf99e	Add actual signature tests	2014-09-22 19:26:17 +02:00
Pieter Wuille	76ec867796	Use actually valid transactions for script tests	2014-09-22 19:26:17 +02:00
Wladimir J. van der Laan	3cdae61aa2	Merge pull request #4787 ... 4b0deb3 Clean up CMerkleTx::SetMerkleBranch. (Daniel Kraft)	2014-09-22 14:18:54 +02:00
Wladimir J. van der Laan	565da68ed0	Merge pull request #4852 ... 5e83bc4 [Qt] include and file header cleanup (Philip Kaufmann)	2014-09-22 12:20:36 +02:00
Wladimir J. van der Laan	321fd7dbee	Merge pull request #4947 ... 6134b43 Fixing condition 'sabotaging' MSVC build (ENikS)	2014-09-22 10:34:12 +02:00
Wladimir J. van der Laan	aa340a8f07	Merge pull request #4951 ... d6712db Also create pid file in non-daemon mode (Wladimir J. van der Laan)	2014-09-22 10:32:21 +02:00
Wladimir J. van der Laan	cfc5cfb0f0	qt: Make splash and shutdown window ignore close events ... It's strange to be able to close these windows while there is work in progress. Also set Qt::WA_DeleteOnClose on both windows to make sure that they are deleted eventually, no matter what happens.	2014-09-22 10:13:52 +02:00
Philip Kaufmann	2e5361b9c2	remove code below asserts in limitedmap.h (fixes a ToDo)	2014-09-22 09:35:40 +02:00
Wladimir J. van der Laan	6b09bc45b1	Merge pull request #4941 ... a49f11d qt: Change splash screen to normal window (Wladimir J. van der Laan)	2014-09-22 09:33:34 +02:00
Wladimir J. van der Laan	5547f08ec7	Merge pull request #4952 ... 01c2807 Add warning about the merkle-tree algorithm duplicate txid flaw (Peter Todd)	2014-09-22 09:03:59 +02:00
ENikS	87314c1c5e	Fixing improper input syntax and failing bounds check	2014-09-21 21:18:48 -04:00
Wladimir J. van der Laan	ae9966ed85	Merge pull request #4950 ... 33a2771 test: Fix DoS tests after c74332c (Wladimir J. van der Laan)	2014-09-21 21:25:25 +02:00
jtimon	3fdb9e8c15	Remove CBaseChainParams::NetworkID()	2014-09-21 21:25:15 +02:00
jtimon	f297479a19	Reserve only one network specific cached path per session	2014-09-21 21:21:09 +02:00
Pieter Wuille	934b153a2c	Merge pull request #4933 ... 20e01b1 Apply clang-format on some infrequently-updated files (Pieter Wuille)	2014-09-21 01:10:14 +02:00
Peter Todd	01c28073ba	Add warning about the merkle-tree algorithm duplicate txid flaw ... Lots of people read the Bitcoin Core codebase to learn more about crypto; better to warn about flaws explicitly so they don't blindly copy the code for other uses and create broken systems.	2014-09-20 13:23:44 -04:00
Wladimir J. van der Laan	d6712db354	Also create pid file in non-daemon mode ... Always make a pid file, not only when `-daemon` specified. This is useful for troubleshooting, for attaching debuggers and loggers and such. - Write the pid file only after the datadir lock was acquired - Don't create or remove a pid file on WIN32, and also don't show the option	2014-09-20 11:03:59 +02:00
Wladimir J. van der Laan	33a27716fc	test: Fix DoS tests after c74332c ... Fix data structure mismatch ... The mind boggles that they were still passing at all.	2014-09-20 09:55:14 +02:00
Pieter Wuille	25308337d6	Merge pull request #4835 ... ab15b2e Avoid copying undo data (Pieter Wuille)	2014-09-20 05:11:09 +02:00
ENikS	6134b43ba9	Fixing condition 'sabotaging' MSVC build	2014-09-19 18:29:58 -04:00
Pieter Wuille	20e01b1a03	Apply clang-format on some infrequently-updated files	2014-09-19 19:21:46 +02:00
ENikS	018cec7c41	Fixing 'vector out of bounds' issue in base 32 and 64	2014-09-18 16:57:01 -04:00
Wladimir J. van der Laan	94064710b9	Write fee estimate and peers files only when initialized ... Fixes #4669. Move the loading of addresses to StartNode() to make it more self-contained.	2014-09-18 14:20:18 +02:00
Philip Kaufmann	5e83bc404c	[Qt] include and file header cleanup ... - alphabetical ordering - correct ordering own headers before normal headers etc.	2014-09-18 14:11:44 +02:00
Wladimir J. van der Laan	a49f11d9ed	qt: Change splash screen to normal window ... Makes it possible to move, minimize, unminimize the window while Bitcoin Core is initializing.	2014-09-18 13:21:26 +02:00
Wladimir J. van der Laan	7fd8813675	Merge pull request #4667 ... bbad683 [Qt] simplify return code and return values in txtablemodel (Philip Kaufmann) 21f1516 [Qt] add all used colors in txtablemodel to guiconstants (Philip Kaufmann)	2014-09-18 12:08:46 +02:00
Wladimir J. van der Laan	62e5f8f961	CMessageHeader sanity changes ... - Remove spurious `pchCommand[1] = 1` in CMessageHeader() - Make sure that pchCommand is zero-padded if length is shorter than COMMAND_SIZE - Use strnlen to determine length of pcmCommand in GetCommand	2014-09-18 10:15:48 +02:00
Wladimir J. van der Laan	c14bfea8ee	Merge pull request #4936 ... c15e483 typo fix of booleamn to boolean (imharrywu)	2014-09-18 09:50:21 +02:00
Philip Kaufmann	93f84d0417	cleanup class private and public areas in walletdb ... - only code movement	2014-09-18 07:21:49 +02:00
Philip Kaufmann	22d7e7014f	prefer const string& over char* in CDB and CWalletDB constructor ... - also make parameter of CDBEnv::CheckpointLSN a constant reference	2014-09-18 07:21:49 +02:00
imharrywu	c15e483f23	typo fix of booleamn to boolean	2014-09-18 08:15:09 +08:00
Pieter Wuille	ab15b2ec71	Avoid copying undo data	2014-09-17 20:38:20 +02:00
Wladimir J. van der Laan	438c7e4cd2	Merge pull request #4555 ... 6dcfda2 Don't pass nHashType to EvalScript nor CheckSig (jtimon) 2b23a87 Don't pass nHashType to VerifyScript (jtimon) ce3649fb Remove CScriptCheck::nHashType (was always 0) (jtimon) 358562b Remove unused function main:VerifySignature (jtimon)	2014-09-17 13:44:22 +02:00
Wladimir J. van der Laan	5b9d1e10a8	Merge pull request #4863 ... 1a61396 fix missing gettransaction entries in rpcclient (Benedict Chan) 57e1716 update rpc help message for gettransaction to add includeWatchonly param (Benedict Chan)	2014-09-17 13:05:41 +02:00
Wladimir J. van der Laan	69dd8c919a	Merge pull request #4899 ... 0be990b Move CTxDestination from script/script to script/standard (Pieter Wuille)	2014-09-17 13:04:54 +02:00
Pieter Wuille	651a1fcf81	Merge pull request #4927 ... ee304b6 minor changes for help message of getpeerinfo (Philip Kaufmann)	2014-09-16 21:25:51 +02:00
Pieter Wuille	0be990ba34	Move CTxDestination from script/script to script/standard	2014-09-16 19:14:32 +02:00
Pieter Wuille	ab3834baae	Merge pull request #4928 ... e9992fb remove include of chainparams.h (imharrywu)	2014-09-16 19:10:32 +02:00
Pieter Wuille	13168ea46c	Merge pull request #4903 ... efad808 Avoid reject message feedback loops (Pieter Wuille)	2014-09-16 18:54:46 +02:00
Wladimir J. van der Laan	cf04923618	Merge pull request #4930 ... f4fe205 add nModSize init to default constructor of CTxMemPoolEntry (Philip Kaufmann)	2014-09-16 15:21:24 +02:00
Philip Kaufmann	f4fe205034	add nModSize init to default constructor of CTxMemPoolEntry	2014-09-16 15:07:45 +02:00
Benedict Chan	1a613963e1	fix missing gettransaction entries in rpcclient	2014-09-16 11:12:01 +00:00
Benedict Chan	57e1716de6	update rpc help message for gettransaction to add includeWatchonly param	2014-09-16 11:12:01 +00:00
Wladimir J. van der Laan	6fc1dc1a32	Merge pull request #4719 ... 52a5f90 Create the common location for all m4 autotool build scripts, build-aux/m4.	2014-09-16 12:00:18 +02:00
randy-waterhouse	52a5f90360	Create the common location for all m4 autotool build scripts, build-aux/m4. ... Update .gitignore.	2014-09-16 11:55:15 +02:00
Wladimir J. van der Laan	f010344156	Merge pull request #4460 ... 604ee2a Remove tx from AlreadyAskedFor list once we receive it, not when we process it. (R E Broadley)	2014-09-16 11:31:54 +02:00
Wladimir J. van der Laan	edb1eebabc	Merge pull request #4853 ... 2605b94 [Qt] update form files for setting autoDefault explicitly to false (Philip Kaufmann)	2014-09-16 10:49:47 +02:00
imharrywu	e9992fb645	remove include of chainparams.h ... chainparams.h has not been used in this cpp file already, consider to remove it for clean.	2014-09-16 15:53:04 +08:00
Philip Kaufmann	ee304b6e35	minor changes for help message of getpeerinfo	2014-09-16 09:00:36 +02:00
Pieter Wuille	dc54e9db98	Merge pull request #4825 ... 8d657a6 Fixing compiler warning C4800: 'type' forcing value to bool 'true' or 'false' (ENikS)	2014-09-16 04:47:55 +02:00
Pieter Wuille	7388b74cd2	Merge pull request #4911 ... 611116d header include cleanup (Philip Kaufmann)	2014-09-16 04:12:52 +02:00
Pieter Wuille	765f398436	Merge pull request #4875 ... f7e3637 Eliminate extra assignment (Suhas Daftuar) ec7eb0f When reindexing check for file before trying to open (refactored) (Suhas Daftuar)	2014-09-16 03:21:21 +02:00
Wladimir J. van der Laan	327dcfece7	Merge pull request #4869 ... 6050ab6 netbase: Make SOCKS5 negotiation interruptible (Wladimir J. van der Laan)	2014-09-15 17:25:12 +02:00
Suhas Daftuar	f7e36370f3	Eliminate extra assignment	2014-09-15 09:56:10 -04:00
ENikS	ec91092df8	Fixing compiler warning C4101 ... Github-Pull: #4856	2014-09-15 14:35:32 +02:00
Wladimir J. van der Laan	c362c57568	Merge pull request #4798 ... d920f7d Move g_signals.SetBestChain(..) below SyncWithWallets (Cozz Lovan)	2014-09-15 10:32:59 +02:00
Pieter Wuille	2ec82e94e6	Merge pull request #4817 ... c26649f Track modified size in TxMemPoolEntry so that we can correctly compute priority. (Alex Morcos)	2014-09-15 07:29:04 +02:00
Jeff Garzik	a0a8700bc8	Merge pull request #4909	2014-09-14 19:27:22 -04:00
Philip Kaufmann	611116d4e3	header include cleanup ... - ensures alphabetical ordering for includes etc. in source file headers	2014-09-14 12:43:56 +02:00
Philip Kaufmann	2d79bba36b	cleanup new script files (no code changes) ... - add missing header end comments - ensure alphabetical ordering - update copyright year and license	2014-09-14 12:25:38 +02:00
Luke Dashjr	a65e320747	bitcoin-util-test: Test bitcoin-tx with null scriptPubKey	2014-09-14 06:28:22 +00:00
Luke Dashjr	15ef1b905b	Bugfix: bitcoin-tx: scriptPubKey may be null, so accept outscript=<n>:	2014-09-14 05:28:41 +00:00
jtimon	6dcfda2dc4	Don't pass nHashType to EvalScript nor CheckSig	2014-09-12 20:04:31 +02:00
jtimon	2b23a87599	Don't pass nHashType to VerifyScript	2014-09-12 20:04:31 +02:00
jtimon	ce3649fb61	Remove CScriptCheck::nHashType (was always 0)	2014-09-12 20:03:03 +02:00
jtimon	358562b651	Remove unused function main:VerifySignature	2014-09-12 20:03:03 +02:00
Pieter Wuille	b9307d2f55	Merge pull request #4876 ... 6022b5d Make script_{valid,invalid}.json validation flags configurable (Pieter Wuille)	2014-09-12 18:33:02 +02:00
Pieter Wuille	efad808aae	Avoid reject message feedback loops	2014-09-12 17:50:31 +02:00
Wladimir J. van der Laan	3fa1c81b94	Merge pull request #4885 ... aa3c697 Store fewer orphan tx by default, add -maxorphantx option (Gavin Andresen) c74332c Stricter handling of orphan transactions (Gavin Andresen)	2014-09-11 14:46:27 +02:00
Gavin Andresen	aa3c697e90	Store fewer orphan tx by default, add -maxorphantx option ... There is no reason to store thousands of orphan transactions; normally an orphan's parents will either be broadcast or mined reasonably quickly. This pull drops the maximum number of orphans from 10,000 down to 100, and adds a command-line option (-maxorphantx) that is just like -maxorphanblocks to override the default.	2014-09-10 14:09:40 -04:00
Gavin Andresen	c74332c678	Stricter handling of orphan transactions ... Prevent denial-of-service attacks by banning peers that send us invalid orphan transactions and only storing orphan transactions given to us by a peer while the peer is connected.	2014-09-10 14:09:40 -04:00
Suhas Daftuar	ec7eb0fa80	When reindexing check for file before trying to open (refactored)	2014-09-10 13:51:53 -04:00
Adam Weiss	e982b574a5	Use explicit fflush() instead of setvbuf() ... Flushing after every line when printing to console is desirable when running with systemd but setvbuf() has slightly different semantics on Windows that causes warnings. Just do an explicit fflush() after each line print to console instead.	2014-09-10 12:48:13 -04:00
Gavin Andresen	def2fdb4b9	Fix crashing bug caused by orphan(s) with duplicate prevout.hash	2014-09-10 16:53:54 +02:00
Wladimir J. van der Laan	d6af9856b0	Merge pull request #4878 ... 540ac45 Avoid returning many "inv" orphans (Jeff Garzik) d4168c8 Limit CNode::mapAskFor (Wladimir J. van der Laan)	2014-09-10 16:52:57 +02:00
Wladimir J. van der Laan	f23869e14b	Merge pull request #4623 ... e84843c Broken addresses on command line no longer trigger testnet. (Ross Nicoll)	2014-09-10 15:07:58 +02:00
jtimon	c1e433b717	Rename scriptutils.o to wallet_ismine.o	2014-09-10 12:48:35 +02:00
jtimon	8b59a3d366	Move CAffectedKeysVisitor to wallet.cpp (remove ExtractAffectedKeys)	2014-09-10 12:44:43 +02:00
jtimon	0d2fa14a34	Move scriptutils.o to wallet	2014-09-10 12:42:56 +02:00
Wladimir J. van der Laan	6050ab6855	netbase: Make SOCKS5 negotiation interruptible ... Avoids that SOCKS5 negotiation will hold up the shutdown process. - Sockets can stay in non-blocking mode, no need to switch it on/off anymore - Adds a timeout (20 seconds) on SOCK5 negotiation. This should be enough for even Tor to get a connection to a hidden service, and avoids blocking the opencon thread indefinitely on a hanging proxy. Fixes #2954.	2014-09-10 11:33:13 +02:00
Wladimir J. van der Laan	4e8cc3cb86	Merge pull request #4867 ... a95b119 qt: Remove thousands separators after decimal point (Wladimir J. van der Laan)	2014-09-10 10:28:47 +02:00
Pieter Wuille	f7cdcb80ab	Merge pull request #4822 ... 629d75f Combine CCoinsViewCache's HaveCoins and const GetCoins into AccessCoins. (Pieter Wuille)	2014-09-10 01:44:30 +02:00
Pieter Wuille	4ebd80298d	Merge pull request #4882 ... faadbe1 remove unneeded cast in rpcmisc.cpp (Philip Kaufmann)	2014-09-10 01:37:46 +02:00
Philip Kaufmann	faadbe1733	remove unneeded cast in rpcmisc.cpp	2014-09-09 19:23:29 +02:00
Pieter Wuille	1575c5171f	Merge pull request #4868 ... 2c2cc5d Remove some unnecessary c_strs() in logging and the GUI (Philip Kaufmann) f7d0a86 netbase: Use .data() instead of .c_str() on binary string (Wladimir J. van der Laan)	2014-09-09 16:43:06 +02:00
Philip Kaufmann	2c2cc5dac1	Remove some unnecessary c_strs() in logging and the GUI ... Includes `core: remove unneeded c_str() / Qt: replace c_str() with Qt code` by P. Kaufmann.	2014-09-09 11:31:17 +02:00
Jeff Garzik	540ac4514d	Avoid returning many "inv" orphans	2014-09-09 09:26:52 +02:00
Wladimir J. van der Laan	d4168c82be	Limit CNode::mapAskFor ... Tighten resource constraints on CNode.	2014-09-09 09:19:15 +02:00
Wladimir J. van der Laan	8bc0a0173e	Merge pull request #4873 ... 89d91f6 Avoid repeated lookups in mapOrphanTransactions and mapOrphanTransactionsByPrev (Wladimir J. van der Laan)	2014-09-09 09:16:22 +02:00
Pieter Wuille	6022b5dc6b	Make script_{valid,invalid}.json validation flags configurable	2014-09-08 22:38:26 +02:00
jtimon	e8b5f0d549	Move CBlockIndex, CChain and related code out of main	2014-09-08 22:17:19 +02:00
jtimon	6db83db3eb	Decouple CChain from mapBlockIndex	2014-09-08 22:14:24 +02:00
jtimon	e088d65acb	Separate script/sign	2014-09-08 20:21:35 +02:00
jtimon	9294a4bbe7	Separate CScriptCompressor	2014-09-08 20:21:35 +02:00
jtimon	c4408a6c85	Separate script/standard	2014-09-08 20:21:35 +02:00
jtimon	da03e6ed7c	Separate script/interpreter	2014-09-08 20:21:33 +02:00
jtimon	cbd22a50c4	Move CScript class and dependencies to script/script	2014-09-08 20:19:31 +02:00
jtimon	86dbeea2cd	Rename script.h/.cpp to scriptutils.h/.cpp (plus remove duplicated includes)	2014-09-08 20:19:31 +02:00
Wladimir J. van der Laan	89d91f6aa7	Avoid repeated lookups in mapOrphanTransactions and mapOrphanTransactionsByPrev	2014-09-08 17:38:43 +02:00
Alex Morcos	c26649f9ed	Track modified size in TxMemPoolEntry so that we can correctly compute priority.	2014-09-08 11:28:46 -04:00
Pieter Wuille	df623d83da	Merge pull request #4865 ... 8e44f2e Clarify 'compressed nor uncompressed' error message (Peter Todd)	2014-09-08 15:13:55 +02:00
Wladimir J. van der Laan	f7d0a86bf6	netbase: Use .data() instead of .c_str() on binary string ... `.c_str()` is only guaranteed to return the data up to the first NUL character.	2014-09-08 12:20:50 +02:00
Wladimir J. van der Laan	bb4ef1e9dc	Merge pull request #4712 ... 80daee0 [Qt] Call checkBalanceChanged() periodically instead for every updated transaction (Cozz Lovan)	2014-09-08 12:00:08 +02:00
Wladimir J. van der Laan	297998808a	Merge pull request #4697 ... da2ede2 [Wallet] Improve ReorderTransactions(..) (Cozz Lovan)	2014-09-08 11:07:00 +02:00
Wladimir J. van der Laan	a95b1199db	qt: Remove thousands separators after decimal point ... Revert thousands separators after decimal point, as introduced in #4167.	2014-09-08 10:46:52 +02:00
Peter Todd	8e44f2e00a	Clarify 'compressed nor uncompressed' error message	2014-09-07 22:32:57 -04:00
Andreas Schildbach	45a4baf100	Add testnet DNS seed of Andreas Schildbach. ... It runs sipas crawler, but rather than using its custom nameserver implementation it serves a generated zonefile via bind9. The zone always contains 25 IPv4 and 25 IPv6 peers. FWIW, the zone is secured using DNSSEC.	2014-09-07 11:16:10 +02:00
ENikS	8d657a6517	Fixing compiler warning C4800: 'type' forcing value to bool 'true' or 'false'	2014-09-06 15:59:59 -04:00
Pieter Wuille	93193c8ffd	Merge pull request #4851 ... 41ef558 univalue: make spaceStr thread-safe (Wladimir J. van der Laan)	2014-09-06 21:10:13 +02:00
Wladimir J. van der Laan	6eb427ed6e	Merge pull request #4839 ... 346193b Cleanup messy error messages (R E Broadley)	2014-09-06 11:05:50 +02:00
R E Broadley	346193bd93	Cleanup messy error messages	2014-09-06 14:18:32 +07:00
Pieter Wuille	0c558288cb	Merge pull request #4849 ... a264e44 remove dup include of foreach.hpp in script.cpp (Philip Kaufmann)	2014-09-05 22:54:03 +02:00
Wladimir J. van der Laan	41ef558aa9	univalue: make spaceStr thread-safe ... Simply add spaces to the existing string instead of using a temporary. Fixes #4756.	2014-09-05 14:42:22 +02:00
Philip Kaufmann	2605b94d73	[Qt] update form files for setting autoDefault explicitly to false ... - also fixes indentation in one file (auto fixed by Qt Designer) - removes several default parameters, which are not needed in the files - related to #4840 (but not intended as fix for a no-bug)	2014-09-05 13:54:16 +02:00
Teran McKinney	f79323b0dd	Improve readability of CAddrInfo::IsTerrible ... - Replaced 86400 with 24*60*60 - Remove references to specific timespans in comments Github-Pull: #4724	2014-09-05 13:49:08 +02:00
Philip Kaufmann	1ffb99b07f	[Qt] copyright, style and indentation cleanup of Qt tests	2014-09-05 13:23:21 +02:00
Philip Kaufmann	a264e445ff	remove dup include of foreach.hpp in script.cpp	2014-09-05 09:49:57 +02:00
Pieter Wuille	af9c3b0cff	Merge pull request #4838 ... 1e4f87f Use memcmp for uint256 equality/inequality (Pieter Wuille) 8a41e1e Use boost::unordered_map for mapBlockIndex (Pieter Wuille) 145d5be Introduce BlockMap type for mapBlockIndex (Pieter Wuille) a0dbe43 checkpoints.cpp depends on main, it can use mapBlockIndex directly (Pieter Wuille)	2014-09-04 23:49:35 +02:00
Wladimir J. van der Laan	b4cd0975fb	Merge pull request #4783 ... fbe0fca [Qt] minor watch-only changes (Philip Kaufmann)	2014-09-04 16:44:39 +02:00
Wladimir J. van der Laan	65b529ba93	Merge pull request #4833 ... bbda402 net: Remove MilliSleep from StopNode (Wladimir J. van der Laan)	2014-09-04 13:31:15 +02:00
Wladimir J. van der Laan	f2cc1ee439	Merge pull request #4790 ... 9189f5f remove useless millisleep (phantomcircuit)	2014-09-04 13:30:34 +02:00
Pieter Wuille	1e4f87f5a1	Use memcmp for uint256 equality/inequality	2014-09-04 02:27:04 +02:00
Pieter Wuille	8a41e1edd4	Use boost::unordered_map for mapBlockIndex	2014-09-04 02:05:20 +02:00
Pieter Wuille	145d5be896	Introduce BlockMap type for mapBlockIndex	2014-09-04 02:04:51 +02:00
Pieter Wuille	a0dbe433bd	checkpoints.cpp depends on main, it can use mapBlockIndex directly	2014-09-04 02:01:10 +02:00
Pieter Wuille	961c4a04c2	Merge pull request #4808 ... 3f6540a Rename IMPLEMENT_SERIALIZE to ADD_SERIALIZE_METHODS (Pieter Wuille) 47eb765 Serializer simplifications after IMPLEMENT_SERIALIZE overhaul (Pieter Wuille)	2014-09-03 21:01:39 +02:00
Pieter Wuille	52c1deb745	Merge pull request #4820 ... 910526d Use OR of respective block flags for masks (Pieter Wuille)	2014-09-03 20:50:57 +02:00
Pieter Wuille	629d75faac	Combine CCoinsViewCache's HaveCoins and const GetCoins into AccessCoins. ... The efficient version of CCoinsViewCache::GetCoins only works for known-to-exist cache entries, requiring a separate HaveCoins call beforehand. This is inefficient as both perform a hashtable lookup. Replace the non-mutable GetCoins with AccessCoins, which returns a potentially-NULL pointer. This also decreases the overloading of GetCoins. Also replace some copying (inefficient) GetCoins calls with equivalent AccessCoins, decreasing the copying.	2014-09-03 14:24:52 +02:00
Wladimir J. van der Laan	bbda40226b	net: Remove MilliSleep from StopNode ... I don't understand why it would be there in the first place. This looks like voodoo, not programming.	2014-09-03 12:23:34 +02:00
Matt Corallo	550d4fa7a7	Remove DNS Seeds run by entities which were never well-established.	2014-09-03 00:41:54 -07:00
phantomcircuit	9189f5fe4d	remove useless millisleep ... reduces time to service requests improving performance	2014-09-02 21:25:53 -07:00
Pieter Wuille	910526d848	Use OR of respective block flags for masks	2014-09-02 18:57:43 +02:00
Pieter Wuille	b8d92236f6	Merge pull request #4812 ... 53efb09 Discover some missing includes (jtimon) 8d5e510 Remove unused function StackString() and class CCoins; (jtimon)	2014-09-02 15:11:55 +02:00
Pieter Wuille	3f6540ad8f	Rename IMPLEMENT_SERIALIZE to ADD_SERIALIZE_METHODS	2014-09-02 09:58:09 +02:00
jtimon	53efb09e4c	Discover some missing includes	2014-09-02 02:27:03 +02:00
jtimon	8d5e5102f6	Remove unused function StackString() and class CCoins;	2014-09-02 02:27:03 +02:00
ENikS	c0f5d4aba5	Fixing Compiler Error C2466	2014-09-01 19:51:25 -04:00
Pieter Wuille	47eb76597e	Serializer simplifications after IMPLEMENT_SERIALIZE overhaul	2014-09-01 22:00:19 +02:00
Pieter Wuille	2e731f24b5	Merge pull request #4737 ... 31e9a83 Use CSizeComputer to avoid counting sizes in SerializationOp (Pieter Wuille) 84881f8 rework overhauled serialization methods to non-static (Kamil Domanski) 5d96b4a remove fields of ser_streamplaceholder (Kamil Domanski) 3d796f8 overhaul serialization code (Kamil Domanski)	2014-09-01 21:23:01 +02:00